[PATCH] drm/amd/amdgpu: Add more config data for debugfs

[PATCH] drm/amd/amdgpu: Add more config data for debugfs

[Tom St Denis]

Adds rev_id as well as cg/pg flags to help debug runtime.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 53763614c6e0..bbd3173cc5ea 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2653,7 +2653,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
 		return -ENOMEM;
 
 	/* version, increment each time something is added */
-	config[no_regs++] = 0;
+	config[no_regs++] = 1;
 	config[no_regs++] = adev->gfx.config.max_shader_engines;
 	config[no_regs++] = adev->gfx.config.max_tile_pipes;
 	config[no_regs++] = adev->gfx.config.max_cu_per_sh;
@@ -2678,6 +2678,11 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
 	config[no_regs++] = adev->gfx.config.gb_addr_config;
 	config[no_regs++] = adev->gfx.config.num_rbs;
 
+	/* rev==1 */
+	config[no_regs++] = adev->rev_id;
+	config[no_regs++] = adev->pg_flags;
+	config[no_regs++] = adev->cg_flags;
+
 	while (size && (*pos < no_regs * 4)) {
 		uint32_t value;
 
-- 
2.9.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/amdgpu: Add more config data for debugfs

[StDenis, Tom]

[-- Attachment #1.1: Type: text/plain, Size: 1902 bytes --]

Hi all,


If I could get an ACK/NAK that would be appreciated.  I have a commit pending on the debug tool (that reads these) that I'd like to get out.


Thanks,

Tom


________________________________
From: Tom St Denis <tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Sent: Friday, August 12, 2016 15:28
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: StDenis, Tom
Subject: [PATCH] drm/amd/amdgpu: Add more config data for debugfs

Adds rev_id as well as cg/pg flags to help debug runtime.

Signed-off-by: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 53763614c6e0..bbd3173cc5ea 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2653,7 +2653,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
                 return -ENOMEM;

         /* version, increment each time something is added */
-       config[no_regs++] = 0;
+       config[no_regs++] = 1;
         config[no_regs++] = adev->gfx.config.max_shader_engines;
         config[no_regs++] = adev->gfx.config.max_tile_pipes;
         config[no_regs++] = adev->gfx.config.max_cu_per_sh;
@@ -2678,6 +2678,11 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
         config[no_regs++] = adev->gfx.config.gb_addr_config;
         config[no_regs++] = adev->gfx.config.num_rbs;

+       /* rev==1 */
+       config[no_regs++] = adev->rev_id;
+       config[no_regs++] = adev->pg_flags;
+       config[no_regs++] = adev->cg_flags;
+
         while (size && (*pos < no_regs * 4)) {
                 uint32_t value;

--
2.9.2


[-- Attachment #1.2: Type: text/html, Size: 3702 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/amdgpu: Add more config data for debugfs

[Christian König]

[-- Attachment #1.1: Type: text/plain, Size: 2324 bytes --]

Am 15.08.2016 um 14:26 schrieb StDenis, Tom:
>
> Hi all,
>
>
> If I could get an ACK/NAK that would be appreciated.  I have a commit 
> pending on the debug tool (that reads these) that I'd like to get out.
>
>
> Thanks,
>
> Tom
>
>
>
> ------------------------------------------------------------------------
> *From:* Tom St Denis <tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> *Sent:* Friday, August 12, 2016 15:28
> *To:* amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> *Cc:* StDenis, Tom
> *Subject:* [PATCH] drm/amd/amdgpu: Add more config data for debugfs
> Adds rev_id as well as cg/pg flags to help debug runtime.
>
> Signed-off-by: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>

Acked-by: Christian König <christian.koenig-5C7GfCeVMHo@public.gmane.org>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 53763614c6e0..bbd3173cc5ea 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2653,7 +2653,7 @@ static ssize_t 
> amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
>                  return -ENOMEM;
>
>          /* version, increment each time something is added */
> -       config[no_regs++] = 0;
> +       config[no_regs++] = 1;
>          config[no_regs++] = adev->gfx.config.max_shader_engines;
>          config[no_regs++] = adev->gfx.config.max_tile_pipes;
>          config[no_regs++] = adev->gfx.config.max_cu_per_sh;
> @@ -2678,6 +2678,11 @@ static ssize_t 
> amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
>          config[no_regs++] = adev->gfx.config.gb_addr_config;
>          config[no_regs++] = adev->gfx.config.num_rbs;
>
> +       /* rev==1 */
> +       config[no_regs++] = adev->rev_id;
> +       config[no_regs++] = adev->pg_flags;
> +       config[no_regs++] = adev->cg_flags;
> +
>          while (size && (*pos < no_regs * 4)) {
>                  uint32_t value;
>
> -- 
> 2.9.2
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx



[-- Attachment #1.2: Type: text/html, Size: 6020 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx