From: Sebastian Reichel <sre@kernel.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>,
"Ville Tervo" <ville.tervo@iki.fi>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Pavel Machek" <pavel@ucw.cz>,
"Pali Rohár" <pali.rohar@gmail.com>,
ivo.g.dimitrov.75@gmail.com, linux-bluetooth@vger.kernel.org,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver
Date: Mon, 15 Aug 2016 03:12:10 +0200 [thread overview]
Message-ID: <20160815011210.vnqwdpapzx2q6gzg@earth> (raw)
In-Reply-To: <CAP=VYLo4ptVzhPjKoiiakbCgBSmpQndNzf0LHWxCZs7LiZ7PYw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
Hi Paul,
On Sun, Aug 14, 2016 at 07:54:28PM -0400, Paul Gortmaker wrote:
> On Fri, Aug 12, 2016 at 11:14 PM, Sebastian Reichel <sre@kernel.org> wrote:
> > This driver adds support for Nokia H4+ procotol used
> > for example by Nokia's internet tablets (N770 - N950).
> >
> > [...]
> >
> > +config BT_HCIUART_NOKIA
> > + bool "UART Nokia H4+ protocol support"
>
> If the option is a bool, then you don't need module.h or any MODULE
> macros, nor do you need any __exit or unregister related code.
>
> Alternatively, if there is a use case for it to be modular, then maybe you
> want to change the above to a tristate.
Actually it is bool and modular: It becomes part of the module
configured by the tristate CONFIG_BT_HCIUART option.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Cc: "Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Marcel Holtmann"
<marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
"Greg Kroah-Hartman"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Jiri Slaby" <jslaby-IBi9RG/b67k@public.gmane.org>,
"Ville Tervo" <ville.tervo-X3B1VOXEql0@public.gmane.org>,
"Filip Matijević"
<filip.matijevic.pz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Aaro Koskinen" <aaro.koskinen-X3B1VOXEql0@public.gmane.org>,
"Pavel Machek" <pavel-+ZI9xUNit7I@public.gmane.org>,
"Pali Rohár" <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver
Date: Mon, 15 Aug 2016 03:12:10 +0200 [thread overview]
Message-ID: <20160815011210.vnqwdpapzx2q6gzg@earth> (raw)
In-Reply-To: <CAP=VYLo4ptVzhPjKoiiakbCgBSmpQndNzf0LHWxCZs7LiZ7PYw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi Paul,
On Sun, Aug 14, 2016 at 07:54:28PM -0400, Paul Gortmaker wrote:
> On Fri, Aug 12, 2016 at 11:14 PM, Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > This driver adds support for Nokia H4+ procotol used
> > for example by Nokia's internet tablets (N770 - N950).
> >
> > [...]
> >
> > +config BT_HCIUART_NOKIA
> > + bool "UART Nokia H4+ protocol support"
>
> If the option is a bool, then you don't need module.h or any MODULE
> macros, nor do you need any __exit or unregister related code.
>
> Alternatively, if there is a use case for it to be modular, then maybe you
> want to change the above to a tristate.
Actually it is bool and modular: It becomes part of the module
configured by the tristate CONFIG_BT_HCIUART option.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-15 1:12 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 3:14 [RFC 0/7] Nokia N9xx bluetooth driver Sebastian Reichel
2016-08-13 3:14 ` [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT init Sebastian Reichel
2016-08-14 8:49 ` Pavel Machek
2016-08-16 8:14 ` Sebastian Reichel
2016-08-16 8:14 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 2/7] tty: add support for "tty slave" devices Sebastian Reichel
2016-08-13 10:03 ` Greg Kroah-Hartman
2016-08-13 20:31 ` Sebastian Reichel
2016-08-14 11:36 ` Greg Kroah-Hartman
2016-08-14 8:48 ` Pavel Machek
2016-08-14 11:35 ` Greg Kroah-Hartman
2016-08-14 11:35 ` Greg Kroah-Hartman
2016-08-13 3:14 ` [RFC 3/7] dt: bindings: Add nokia-bluetooth Sebastian Reichel
2016-08-16 13:51 ` Rob Herring
2016-08-16 23:28 ` Sebastian Reichel
2016-08-17 13:11 ` Rob Herring
2016-08-17 13:11 ` Rob Herring
2016-08-17 15:54 ` Pavel Machek
2016-08-17 15:54 ` Pavel Machek
2016-08-13 3:14 ` [RFC 4/7] Bluetooth: hci_uart: Add support for word alignment Sebastian Reichel
2016-08-14 8:51 ` Pavel Machek
2016-08-14 8:51 ` Pavel Machek
2016-08-16 7:05 ` Marcel Holtmann
2016-08-16 7:51 ` Sebastian Reichel
2016-08-16 7:51 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel
2016-08-14 23:54 ` Paul Gortmaker
2016-08-14 23:54 ` Paul Gortmaker
2016-08-15 1:12 ` Sebastian Reichel [this message]
2016-08-15 1:12 ` Sebastian Reichel
2016-08-16 7:02 ` Marcel Holtmann
2016-08-16 7:52 ` Pali Rohár
2016-08-16 9:25 ` Sebastian Reichel
2016-08-16 9:09 ` Sebastian Reichel
2016-08-16 9:09 ` Sebastian Reichel
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 20:05 ` Pavel Machek
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 8:10 ` Marcel Holtmann
2016-08-16 8:10 ` Marcel Holtmann
2016-08-16 9:35 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 6/7] ARM: dts: OMAP3-N900: Add bluetooth Sebastian Reichel
2016-08-14 8:53 ` Pavel Machek
2016-08-13 3:14 ` [RFC 7/7] ARM: dts: OMAP3-N950: " Sebastian Reichel
2016-08-13 3:14 ` Sebastian Reichel
2016-08-14 8:53 ` Pavel Machek
2016-08-16 7:10 ` [RFC 0/7] Nokia N9xx bluetooth driver Marcel Holtmann
2016-08-16 7:10 ` Marcel Holtmann
2016-08-16 20:22 ` Rob Herring
2016-08-16 20:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815011210.vnqwdpapzx2q6gzg@earth \
--to=sre@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=filip.matijevic.pz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=ville.tervo@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.