* [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips
@ 2016-06-14 14:21 Boris Brezillon
2016-06-14 14:21 ` [PATCH 2/2] mtd: nand: timings: Reorder tRR_min def in mode 0 Boris Brezillon
2016-08-15 15:17 ` [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Boris Brezillon @ 2016-06-14 14:21 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, linux-mtd, Boris Brezillon,
Richard Weinberger
Cc: linux-kernel, Ezequiel Garcia, Robert Jarzmik
ONFI 4.0 spec defines different values for the tADL_min timing.
Since we don't want to have different timings depending on the ONFI
version, we just set tADL_min to the maximum value (the one specified
in the ONFI 4.0 spec).
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
drivers/mtd/nand/nand_timings.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
index e81470a..c0941d5 100644
--- a/drivers/mtd/nand/nand_timings.c
+++ b/drivers/mtd/nand/nand_timings.c
@@ -16,7 +16,7 @@
static const struct nand_sdr_timings onfi_sdr_timings[] = {
/* Mode 0 */
{
- .tADL_min = 200000,
+ .tADL_min = 400000,
.tALH_min = 20000,
.tALS_min = 50000,
.tAR_min = 25000,
@@ -53,7 +53,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
},
/* Mode 1 */
{
- .tADL_min = 100000,
+ .tADL_min = 400000,
.tALH_min = 10000,
.tALS_min = 25000,
.tAR_min = 10000,
@@ -90,7 +90,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
},
/* Mode 2 */
{
- .tADL_min = 100000,
+ .tADL_min = 400000,
.tALH_min = 10000,
.tALS_min = 15000,
.tAR_min = 10000,
@@ -127,7 +127,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
},
/* Mode 3 */
{
- .tADL_min = 100000,
+ .tADL_min = 400000,
.tALH_min = 5000,
.tALS_min = 10000,
.tAR_min = 10000,
@@ -164,7 +164,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
},
/* Mode 4 */
{
- .tADL_min = 70000,
+ .tADL_min = 400000,
.tALH_min = 5000,
.tALS_min = 10000,
.tAR_min = 10000,
@@ -201,7 +201,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
},
/* Mode 5 */
{
- .tADL_min = 70000,
+ .tADL_min = 400000,
.tALH_min = 5000,
.tALS_min = 10000,
.tAR_min = 10000,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] mtd: nand: timings: Reorder tRR_min def in mode 0
2016-06-14 14:21 [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips Boris Brezillon
@ 2016-06-14 14:21 ` Boris Brezillon
2016-08-15 15:17 ` [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2016-06-14 14:21 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, linux-mtd, Boris Brezillon,
Richard Weinberger
Cc: linux-kernel, Ezequiel Garcia, Robert Jarzmik
In the ONFI spec, the tRR_min entry is defined before the tRST_max one.
Reoder the definition to make it easier to review.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
drivers/mtd/nand/nand_timings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
index c0941d5..30119c5 100644
--- a/drivers/mtd/nand/nand_timings.c
+++ b/drivers/mtd/nand/nand_timings.c
@@ -42,9 +42,9 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
.tRHZ_max = 200000,
.tRLOH_min = 0,
.tRP_min = 50000,
+ .tRR_min = 40000,
.tRST_max = 250000000000ULL,
.tWB_max = 200000,
- .tRR_min = 40000,
.tWC_min = 100000,
.tWH_min = 30000,
.tWHR_min = 120000,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips
2016-06-14 14:21 [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips Boris Brezillon
2016-06-14 14:21 ` [PATCH 2/2] mtd: nand: timings: Reorder tRR_min def in mode 0 Boris Brezillon
@ 2016-08-15 15:17 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2016-08-15 15:17 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, linux-mtd, Boris Brezillon,
Richard Weinberger
Cc: linux-kernel, Ezequiel Garcia, Robert Jarzmik
On Tue, 14 Jun 2016 16:21:06 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> ONFI 4.0 spec defines different values for the tADL_min timing.
> Since we don't want to have different timings depending on the ONFI
> version, we just set tADL_min to the maximum value (the one specified
> in the ONFI 4.0 spec).
Applied both.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/nand_timings.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
> index e81470a..c0941d5 100644
> --- a/drivers/mtd/nand/nand_timings.c
> +++ b/drivers/mtd/nand/nand_timings.c
> @@ -16,7 +16,7 @@
> static const struct nand_sdr_timings onfi_sdr_timings[] = {
> /* Mode 0 */
> {
> - .tADL_min = 200000,
> + .tADL_min = 400000,
> .tALH_min = 20000,
> .tALS_min = 50000,
> .tAR_min = 25000,
> @@ -53,7 +53,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
> },
> /* Mode 1 */
> {
> - .tADL_min = 100000,
> + .tADL_min = 400000,
> .tALH_min = 10000,
> .tALS_min = 25000,
> .tAR_min = 10000,
> @@ -90,7 +90,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
> },
> /* Mode 2 */
> {
> - .tADL_min = 100000,
> + .tADL_min = 400000,
> .tALH_min = 10000,
> .tALS_min = 15000,
> .tAR_min = 10000,
> @@ -127,7 +127,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
> },
> /* Mode 3 */
> {
> - .tADL_min = 100000,
> + .tADL_min = 400000,
> .tALH_min = 5000,
> .tALS_min = 10000,
> .tAR_min = 10000,
> @@ -164,7 +164,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
> },
> /* Mode 4 */
> {
> - .tADL_min = 70000,
> + .tADL_min = 400000,
> .tALH_min = 5000,
> .tALS_min = 10000,
> .tAR_min = 10000,
> @@ -201,7 +201,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
> },
> /* Mode 5 */
> {
> - .tADL_min = 70000,
> + .tADL_min = 400000,
> .tALH_min = 5000,
> .tALS_min = 10000,
> .tAR_min = 10000,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-15 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-14 14:21 [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips Boris Brezillon
2016-06-14 14:21 ` [PATCH 2/2] mtd: nand: timings: Reorder tRR_min def in mode 0 Boris Brezillon
2016-08-15 15:17 ` [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.