* [PATCH] platform: olpc: make ec explicitly non-modular
@ 2016-08-15 22:25 ` Paul Gortmaker
0 siblings, 0 replies; 5+ messages in thread
From: Paul Gortmaker @ 2016-08-15 22:25 UTC (permalink / raw)
To: linux-kernel
Cc: Paul Gortmaker, Darren Hart, Andres Salomon, platform-driver-x86
The Kconfig entry controlling compilation of this code is:
arch/x86/Kconfig:config OLPC
arch/x86/Kconfig: bool "One Laptop Per Child support"
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.
We delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andres Salomon <dilinger@queued.net>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/platform/olpc/olpc-ec.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c
index f99b183d5296..374a8028fec7 100644
--- a/drivers/platform/olpc/olpc-ec.c
+++ b/drivers/platform/olpc/olpc-ec.c
@@ -1,6 +1,8 @@
/*
* Generic driver for the OLPC Embedded Controller.
*
+ * Author: Andres Salomon <dilinger@queued.net>
+ *
* Copyright (C) 2011-2012 One Laptop per Child Foundation.
*
* Licensed under the GPL v2 or later.
@@ -12,7 +14,7 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/workqueue.h>
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/list.h>
#include <linux/olpc-ec.h>
#include <asm/olpc.h>
@@ -326,8 +328,4 @@ static int __init olpc_ec_init_module(void)
{
return platform_driver_register(&olpc_ec_plat_driver);
}
-
arch_initcall(olpc_ec_init_module);
-
-MODULE_AUTHOR("Andres Salomon <dilinger@queued.net>");
-MODULE_LICENSE("GPL");
--
2.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] platform: olpc: make ec explicitly non-modular
@ 2016-08-15 22:25 ` Paul Gortmaker
0 siblings, 0 replies; 5+ messages in thread
From: Paul Gortmaker @ 2016-08-15 22:25 UTC (permalink / raw)
To: linux-kernel
Cc: Paul Gortmaker, Darren Hart, Andres Salomon, platform-driver-x86
The Kconfig entry controlling compilation of this code is:
arch/x86/Kconfig:config OLPC
arch/x86/Kconfig: bool "One Laptop Per Child support"
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.
We delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andres Salomon <dilinger@queued.net>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/platform/olpc/olpc-ec.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c
index f99b183d5296..374a8028fec7 100644
--- a/drivers/platform/olpc/olpc-ec.c
+++ b/drivers/platform/olpc/olpc-ec.c
@@ -1,6 +1,8 @@
/*
* Generic driver for the OLPC Embedded Controller.
*
+ * Author: Andres Salomon <dilinger@queued.net>
+ *
* Copyright (C) 2011-2012 One Laptop per Child Foundation.
*
* Licensed under the GPL v2 or later.
@@ -12,7 +14,7 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/workqueue.h>
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/list.h>
#include <linux/olpc-ec.h>
#include <asm/olpc.h>
@@ -326,8 +328,4 @@ static int __init olpc_ec_init_module(void)
{
return platform_driver_register(&olpc_ec_plat_driver);
}
-
arch_initcall(olpc_ec_init_module);
-
-MODULE_AUTHOR("Andres Salomon <dilinger@queued.net>");
-MODULE_LICENSE("GPL");
--
2.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] platform: olpc: make ec explicitly non-modular
2016-08-15 22:25 ` Paul Gortmaker
@ 2016-08-16 1:01 ` Andres Salomon
-1 siblings, 0 replies; 5+ messages in thread
From: Andres Salomon @ 2016-08-16 1:01 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel, Darren Hart, platform-driver-x86
Fine by me.
Acked-by: Andres Salomon <dilinger@queued.net>
On Mon, 15
Aug 2016 18:25:17 -0400 Paul Gortmaker <paul.gortmaker@windriver.com>
wrote:
> The Kconfig entry controlling compilation of this code is:
>
> arch/x86/Kconfig:config OLPC
> arch/x86/Kconfig: bool "One Laptop Per Child support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andres Salomon <dilinger@queued.net>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/platform/olpc/olpc-ec.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/olpc/olpc-ec.c
> b/drivers/platform/olpc/olpc-ec.c index f99b183d5296..374a8028fec7
> 100644 --- a/drivers/platform/olpc/olpc-ec.c
> +++ b/drivers/platform/olpc/olpc-ec.c
> @@ -1,6 +1,8 @@
> /*
> * Generic driver for the OLPC Embedded Controller.
> *
> + * Author: Andres Salomon <dilinger@queued.net>
> + *
> * Copyright (C) 2011-2012 One Laptop per Child Foundation.
> *
> * Licensed under the GPL v2 or later.
> @@ -12,7 +14,7 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
> #include <linux/list.h>
> #include <linux/olpc-ec.h>
> #include <asm/olpc.h>
> @@ -326,8 +328,4 @@ static int __init olpc_ec_init_module(void)
> {
> return platform_driver_register(&olpc_ec_plat_driver);
> }
> -
> arch_initcall(olpc_ec_init_module);
> -
> -MODULE_AUTHOR("Andres Salomon <dilinger@queued.net>");
> -MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform: olpc: make ec explicitly non-modular
@ 2016-08-16 1:01 ` Andres Salomon
0 siblings, 0 replies; 5+ messages in thread
From: Andres Salomon @ 2016-08-16 1:01 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel, Darren Hart, platform-driver-x86
Fine by me.
Acked-by: Andres Salomon <dilinger@queued.net>
On Mon, 15
Aug 2016 18:25:17 -0400 Paul Gortmaker <paul.gortmaker@windriver.com>
wrote:
> The Kconfig entry controlling compilation of this code is:
>
> arch/x86/Kconfig:config OLPC
> arch/x86/Kconfig: bool "One Laptop Per Child support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andres Salomon <dilinger@queued.net>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/platform/olpc/olpc-ec.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/olpc/olpc-ec.c
> b/drivers/platform/olpc/olpc-ec.c index f99b183d5296..374a8028fec7
> 100644 --- a/drivers/platform/olpc/olpc-ec.c
> +++ b/drivers/platform/olpc/olpc-ec.c
> @@ -1,6 +1,8 @@
> /*
> * Generic driver for the OLPC Embedded Controller.
> *
> + * Author: Andres Salomon <dilinger@queued.net>
> + *
> * Copyright (C) 2011-2012 One Laptop per Child Foundation.
> *
> * Licensed under the GPL v2 or later.
> @@ -12,7 +14,7 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
> #include <linux/list.h>
> #include <linux/olpc-ec.h>
> #include <asm/olpc.h>
> @@ -326,8 +328,4 @@ static int __init olpc_ec_init_module(void)
> {
> return platform_driver_register(&olpc_ec_plat_driver);
> }
> -
> arch_initcall(olpc_ec_init_module);
> -
> -MODULE_AUTHOR("Andres Salomon <dilinger@queued.net>");
> -MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform: olpc: make ec explicitly non-modular
2016-08-16 1:01 ` Andres Salomon
(?)
@ 2016-08-17 0:08 ` Darren Hart
-1 siblings, 0 replies; 5+ messages in thread
From: Darren Hart @ 2016-08-17 0:08 UTC (permalink / raw)
To: Andres Salomon; +Cc: Paul Gortmaker, linux-kernel, platform-driver-x86
On Mon, Aug 15, 2016 at 06:01:20PM -0700, Andres Salomon wrote:
> Fine by me.
>
> Acked-by: Andres Salomon <dilinger@queued.net>
>
> On Mon, 15
> Aug 2016 18:25:17 -0400 Paul Gortmaker <paul.gortmaker@windriver.com>
> wrote:
>
> > The Kconfig entry controlling compilation of this code is:
> >
> > arch/x86/Kconfig:config OLPC
> > arch/x86/Kconfig: bool "One Laptop Per Child support"
> >
> > ...meaning that it currently is not being built as a module by anyone.
> >
> > Lets remove the couple traces of modular infrastructure use, so that
> > when reading the driver there is no doubt it is builtin-only.
> >
> > We delete the MODULE_LICENSE tag etc. since all that information
> > was (or is now) contained at the top of the file in the comments.
> >
> > Cc: Darren Hart <dvhart@infradead.org>
> > Cc: Andres Salomon <dilinger@queued.net>
> > Cc: platform-driver-x86@vger.kernel.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Queued to fixes for 4.8. Thanks.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-17 0:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-15 22:25 [PATCH] platform: olpc: make ec explicitly non-modular Paul Gortmaker
2016-08-15 22:25 ` Paul Gortmaker
2016-08-16 1:01 ` Andres Salomon
2016-08-16 1:01 ` Andres Salomon
2016-08-17 0:08 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.