From: Daniel Vetter <daniel@ffwll.ch>
To: Mark yao <mark.yao@rock-chips.com>
Cc: Sean Paul <seanpaul@chromium.org>,
tfiga@chromium.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/5] drm/rockchip: sort registers define by chip's number
Date: Thu, 18 Aug 2016 11:11:41 +0200 [thread overview]
Message-ID: <20160818091141.GZ6232@phenom.ffwll.local> (raw)
In-Reply-To: <57B57AFE.2030706@rock-chips.com>
On Thu, Aug 18, 2016 at 05:08:14PM +0800, Mark yao wrote:
> Hi Sean
>
> Thanks for send v3 patch for rk3399 vop support.
>
> But sorry for that, I had changed my mind, those patches are deprecated,
> I have new rk3399 patch on my downstream kernel, I will upstream soon.
Wut? Imo merge Sean's patch here, and then rebase your downstream patches
on top of it. That you have a downstream tree which is out of sync with
upstream shouldn't be a reason to stall upstream development.
-Daniel
>
> Thanks.
>
> On 2016年08月18日 01:20, Sean Paul wrote:
> > From: Mark Yao <mark.yao@rock-chips.com>
> >
> > No functional changes, sort the vop registers to make
> > code more readable.
> >
> > Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> > [seanpaul resolved conflict with name change from _3066 to _3036]
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Fix typo from _3066 _3036 (Tomasz Figa)
> >
> > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 168 ++++++++++++++--------------
> > 1 file changed, 84 insertions(+), 84 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > index 919992c..44caf14 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > @@ -50,6 +50,88 @@ static const uint32_t formats_win_lite[] = {
> > DRM_FORMAT_BGR565,
> > };
> > +static const struct vop_scl_regs rk3036_win_scl = {
> > + .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
> > + .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
> > + .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
> > + .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
> > +};
> > +
> > +static const struct vop_win_phy rk3036_win0_data = {
> > + .scl = &rk3036_win_scl,
> > + .data_formats = formats_win_full,
> > + .nformats = ARRAY_SIZE(formats_win_full),
> > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0),
> > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3),
> > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15),
> > + .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0),
> > + .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0),
> > + .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0),
> > + .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0),
> > + .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0),
> > + .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0),
> > + .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16),
> > +};
> > +
> > +static const struct vop_win_phy rk3036_win1_data = {
> > + .data_formats = formats_win_lite,
> > + .nformats = ARRAY_SIZE(formats_win_lite),
> > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1),
> > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6),
> > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19),
> > + .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0),
> > + .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0),
> > + .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0),
> > + .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0),
> > + .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0),
> > +};
> > +
> > +static const struct vop_win_data rk3036_vop_win_data[] = {
> > + { .base = 0x00, .phy = &rk3036_win0_data,
> > + .type = DRM_PLANE_TYPE_PRIMARY },
> > + { .base = 0x00, .phy = &rk3036_win1_data,
> > + .type = DRM_PLANE_TYPE_CURSOR },
> > +};
> > +
> > +static const int rk3036_vop_intrs[] = {
> > + DSP_HOLD_VALID_INTR,
> > + FS_INTR,
> > + LINE_FLAG_INTR,
> > + BUS_ERROR_INTR,
> > +};
> > +
> > +static const struct vop_intr rk3036_intr = {
> > + .intrs = rk3036_vop_intrs,
> > + .nintrs = ARRAY_SIZE(rk3036_vop_intrs),
> > + .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0),
> > + .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4),
> > + .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8),
> > +};
> > +
> > +static const struct vop_ctrl rk3036_ctrl_data = {
> > + .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30),
> > + .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0),
> > + .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4),
> > + .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
> > + .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0),
> > + .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
> > + .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0),
> > + .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0),
> > +};
> > +
> > +static const struct vop_reg_data rk3036_vop_init_reg_table[] = {
> > + {RK3036_DSP_CTRL1, 0x00000000},
> > +};
> > +
> > +static const struct vop_data rk3036_vop = {
> > + .init_table = rk3036_vop_init_reg_table,
> > + .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table),
> > + .ctrl = &rk3036_ctrl_data,
> > + .intr = &rk3036_intr,
> > + .win = rk3036_vop_win_data,
> > + .win_size = ARRAY_SIZE(rk3036_vop_win_data),
> > +};
> > +
> > static const struct vop_scl_extension rk3288_win_full_scl_ext = {
> > .cbcr_vsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 31),
> > .cbcr_vsu_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 30),
> > @@ -190,93 +272,11 @@ static const struct vop_data rk3288_vop = {
> > .win_size = ARRAY_SIZE(rk3288_vop_win_data),
> > };
> > -static const struct vop_scl_regs rk3036_win_scl = {
> > - .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
> > - .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
> > - .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
> > - .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
> > -};
> > -
> > -static const struct vop_win_phy rk3036_win0_data = {
> > - .scl = &rk3036_win_scl,
> > - .data_formats = formats_win_full,
> > - .nformats = ARRAY_SIZE(formats_win_full),
> > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0),
> > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3),
> > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15),
> > - .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0),
> > - .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0),
> > - .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0),
> > - .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0),
> > - .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0),
> > - .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0),
> > - .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16),
> > -};
> > -
> > -static const struct vop_win_phy rk3036_win1_data = {
> > - .data_formats = formats_win_lite,
> > - .nformats = ARRAY_SIZE(formats_win_lite),
> > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1),
> > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6),
> > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19),
> > - .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0),
> > - .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0),
> > - .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0),
> > - .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0),
> > - .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0),
> > -};
> > -
> > -static const struct vop_win_data rk3036_vop_win_data[] = {
> > - { .base = 0x00, .phy = &rk3036_win0_data,
> > - .type = DRM_PLANE_TYPE_PRIMARY },
> > - { .base = 0x00, .phy = &rk3036_win1_data,
> > - .type = DRM_PLANE_TYPE_CURSOR },
> > -};
> > -
> > -static const int rk3036_vop_intrs[] = {
> > - DSP_HOLD_VALID_INTR,
> > - FS_INTR,
> > - LINE_FLAG_INTR,
> > - BUS_ERROR_INTR,
> > -};
> > -
> > -static const struct vop_intr rk3036_intr = {
> > - .intrs = rk3036_vop_intrs,
> > - .nintrs = ARRAY_SIZE(rk3036_vop_intrs),
> > - .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0),
> > - .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4),
> > - .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8),
> > -};
> > -
> > -static const struct vop_ctrl rk3036_ctrl_data = {
> > - .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30),
> > - .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0),
> > - .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4),
> > - .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
> > - .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0),
> > - .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
> > - .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0),
> > - .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0),
> > -};
> > -
> > -static const struct vop_reg_data rk3036_vop_init_reg_table[] = {
> > - {RK3036_DSP_CTRL1, 0x00000000},
> > -};
> > -
> > -static const struct vop_data rk3036_vop = {
> > - .init_table = rk3036_vop_init_reg_table,
> > - .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table),
> > - .ctrl = &rk3036_ctrl_data,
> > - .intr = &rk3036_intr,
> > - .win = rk3036_vop_win_data,
> > - .win_size = ARRAY_SIZE(rk3036_vop_win_data),
> > -};
> > -
> > static const struct of_device_id vop_driver_dt_match[] = {
> > - { .compatible = "rockchip,rk3288-vop",
> > - .data = &rk3288_vop },
> > { .compatible = "rockchip,rk3036-vop",
> > .data = &rk3036_vop },
> > + { .compatible = "rockchip,rk3288-vop",
> > + .data = &rk3288_vop },
> > {},
> > };
> > MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
>
>
> --
> Ｍark Yao
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Mark yao <mark.yao@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tfiga@chromium.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/5] drm/rockchip: sort registers define by chip's number
Date: Thu, 18 Aug 2016 11:11:41 +0200 [thread overview]
Message-ID: <20160818091141.GZ6232@phenom.ffwll.local> (raw)
In-Reply-To: <57B57AFE.2030706@rock-chips.com>
On Thu, Aug 18, 2016 at 05:08:14PM +0800, Mark yao wrote:
> Hi Sean
>
> Thanks for send v3 patch for rk3399 vop support.
>
> But sorry for that, I had changed my mind, those patches are deprecated,
> I have new rk3399 patch on my downstream kernel, I will upstream soon.
Wut? Imo merge Sean's patch here, and then rebase your downstream patches
on top of it. That you have a downstream tree which is out of sync with
upstream shouldn't be a reason to stall upstream development.
-Daniel
>
> Thanks.
>
> On 2016年08月18日 01:20, Sean Paul wrote:
> > From: Mark Yao <mark.yao@rock-chips.com>
> >
> > No functional changes, sort the vop registers to make
> > code more readable.
> >
> > Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> > [seanpaul resolved conflict with name change from _3066 to _3036]
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Fix typo from _3066 _3036 (Tomasz Figa)
> >
> > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 168 ++++++++++++++--------------
> > 1 file changed, 84 insertions(+), 84 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > index 919992c..44caf14 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > @@ -50,6 +50,88 @@ static const uint32_t formats_win_lite[] = {
> > DRM_FORMAT_BGR565,
> > };
> > +static const struct vop_scl_regs rk3036_win_scl = {
> > + .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
> > + .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
> > + .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
> > + .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
> > +};
> > +
> > +static const struct vop_win_phy rk3036_win0_data = {
> > + .scl = &rk3036_win_scl,
> > + .data_formats = formats_win_full,
> > + .nformats = ARRAY_SIZE(formats_win_full),
> > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0),
> > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3),
> > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15),
> > + .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0),
> > + .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0),
> > + .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0),
> > + .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0),
> > + .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0),
> > + .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0),
> > + .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16),
> > +};
> > +
> > +static const struct vop_win_phy rk3036_win1_data = {
> > + .data_formats = formats_win_lite,
> > + .nformats = ARRAY_SIZE(formats_win_lite),
> > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1),
> > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6),
> > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19),
> > + .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0),
> > + .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0),
> > + .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0),
> > + .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0),
> > + .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0),
> > +};
> > +
> > +static const struct vop_win_data rk3036_vop_win_data[] = {
> > + { .base = 0x00, .phy = &rk3036_win0_data,
> > + .type = DRM_PLANE_TYPE_PRIMARY },
> > + { .base = 0x00, .phy = &rk3036_win1_data,
> > + .type = DRM_PLANE_TYPE_CURSOR },
> > +};
> > +
> > +static const int rk3036_vop_intrs[] = {
> > + DSP_HOLD_VALID_INTR,
> > + FS_INTR,
> > + LINE_FLAG_INTR,
> > + BUS_ERROR_INTR,
> > +};
> > +
> > +static const struct vop_intr rk3036_intr = {
> > + .intrs = rk3036_vop_intrs,
> > + .nintrs = ARRAY_SIZE(rk3036_vop_intrs),
> > + .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0),
> > + .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4),
> > + .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8),
> > +};
> > +
> > +static const struct vop_ctrl rk3036_ctrl_data = {
> > + .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30),
> > + .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0),
> > + .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4),
> > + .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
> > + .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0),
> > + .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
> > + .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0),
> > + .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0),
> > +};
> > +
> > +static const struct vop_reg_data rk3036_vop_init_reg_table[] = {
> > + {RK3036_DSP_CTRL1, 0x00000000},
> > +};
> > +
> > +static const struct vop_data rk3036_vop = {
> > + .init_table = rk3036_vop_init_reg_table,
> > + .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table),
> > + .ctrl = &rk3036_ctrl_data,
> > + .intr = &rk3036_intr,
> > + .win = rk3036_vop_win_data,
> > + .win_size = ARRAY_SIZE(rk3036_vop_win_data),
> > +};
> > +
> > static const struct vop_scl_extension rk3288_win_full_scl_ext = {
> > .cbcr_vsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 31),
> > .cbcr_vsu_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 30),
> > @@ -190,93 +272,11 @@ static const struct vop_data rk3288_vop = {
> > .win_size = ARRAY_SIZE(rk3288_vop_win_data),
> > };
> > -static const struct vop_scl_regs rk3036_win_scl = {
> > - .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
> > - .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
> > - .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
> > - .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
> > -};
> > -
> > -static const struct vop_win_phy rk3036_win0_data = {
> > - .scl = &rk3036_win_scl,
> > - .data_formats = formats_win_full,
> > - .nformats = ARRAY_SIZE(formats_win_full),
> > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0),
> > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3),
> > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15),
> > - .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0),
> > - .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0),
> > - .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0),
> > - .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0),
> > - .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0),
> > - .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0),
> > - .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16),
> > -};
> > -
> > -static const struct vop_win_phy rk3036_win1_data = {
> > - .data_formats = formats_win_lite,
> > - .nformats = ARRAY_SIZE(formats_win_lite),
> > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1),
> > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6),
> > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19),
> > - .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0),
> > - .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0),
> > - .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0),
> > - .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0),
> > - .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0),
> > -};
> > -
> > -static const struct vop_win_data rk3036_vop_win_data[] = {
> > - { .base = 0x00, .phy = &rk3036_win0_data,
> > - .type = DRM_PLANE_TYPE_PRIMARY },
> > - { .base = 0x00, .phy = &rk3036_win1_data,
> > - .type = DRM_PLANE_TYPE_CURSOR },
> > -};
> > -
> > -static const int rk3036_vop_intrs[] = {
> > - DSP_HOLD_VALID_INTR,
> > - FS_INTR,
> > - LINE_FLAG_INTR,
> > - BUS_ERROR_INTR,
> > -};
> > -
> > -static const struct vop_intr rk3036_intr = {
> > - .intrs = rk3036_vop_intrs,
> > - .nintrs = ARRAY_SIZE(rk3036_vop_intrs),
> > - .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0),
> > - .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4),
> > - .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8),
> > -};
> > -
> > -static const struct vop_ctrl rk3036_ctrl_data = {
> > - .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30),
> > - .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0),
> > - .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4),
> > - .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
> > - .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0),
> > - .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
> > - .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0),
> > - .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0),
> > -};
> > -
> > -static const struct vop_reg_data rk3036_vop_init_reg_table[] = {
> > - {RK3036_DSP_CTRL1, 0x00000000},
> > -};
> > -
> > -static const struct vop_data rk3036_vop = {
> > - .init_table = rk3036_vop_init_reg_table,
> > - .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table),
> > - .ctrl = &rk3036_ctrl_data,
> > - .intr = &rk3036_intr,
> > - .win = rk3036_vop_win_data,
> > - .win_size = ARRAY_SIZE(rk3036_vop_win_data),
> > -};
> > -
> > static const struct of_device_id vop_driver_dt_match[] = {
> > - { .compatible = "rockchip,rk3288-vop",
> > - .data = &rk3288_vop },
> > { .compatible = "rockchip,rk3036-vop",
> > .data = &rk3036_vop },
> > + { .compatible = "rockchip,rk3288-vop",
> > + .data = &rk3288_vop },
> > {},
> > };
> > MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
>
>
> --
> Ｍark Yao
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: daniel@ffwll.ch (Daniel Vetter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/5] drm/rockchip: sort registers define by chip's number
Date: Thu, 18 Aug 2016 11:11:41 +0200 [thread overview]
Message-ID: <20160818091141.GZ6232@phenom.ffwll.local> (raw)
In-Reply-To: <57B57AFE.2030706@rock-chips.com>
On Thu, Aug 18, 2016 at 05:08:14PM +0800, Mark yao wrote:
> Hi Sean
>
> Thanks for send v3 patch for rk3399 vop support.
>
> But sorry for that, I had changed my mind, those patches are deprecated,
> I have new rk3399 patch on my downstream kernel, I will upstream soon.
Wut? Imo merge Sean's patch here, and then rebase your downstream patches
on top of it. That you have a downstream tree which is out of sync with
upstream shouldn't be a reason to stall upstream development.
-Daniel
>
> Thanks.
>
> On 2016?08?18? 01:20, Sean Paul wrote:
> > From: Mark Yao <mark.yao@rock-chips.com>
> >
> > No functional changes, sort the vop registers to make
> > code more readable.
> >
> > Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> > [seanpaul resolved conflict with name change from _3066 to _3036]
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Fix typo from _3066 _3036 (Tomasz Figa)
> >
> > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 168 ++++++++++++++--------------
> > 1 file changed, 84 insertions(+), 84 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > index 919992c..44caf14 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> > @@ -50,6 +50,88 @@ static const uint32_t formats_win_lite[] = {
> > DRM_FORMAT_BGR565,
> > };
> > +static const struct vop_scl_regs rk3036_win_scl = {
> > + .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
> > + .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
> > + .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
> > + .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
> > +};
> > +
> > +static const struct vop_win_phy rk3036_win0_data = {
> > + .scl = &rk3036_win_scl,
> > + .data_formats = formats_win_full,
> > + .nformats = ARRAY_SIZE(formats_win_full),
> > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0),
> > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3),
> > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15),
> > + .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0),
> > + .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0),
> > + .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0),
> > + .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0),
> > + .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0),
> > + .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0),
> > + .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16),
> > +};
> > +
> > +static const struct vop_win_phy rk3036_win1_data = {
> > + .data_formats = formats_win_lite,
> > + .nformats = ARRAY_SIZE(formats_win_lite),
> > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1),
> > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6),
> > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19),
> > + .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0),
> > + .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0),
> > + .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0),
> > + .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0),
> > + .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0),
> > +};
> > +
> > +static const struct vop_win_data rk3036_vop_win_data[] = {
> > + { .base = 0x00, .phy = &rk3036_win0_data,
> > + .type = DRM_PLANE_TYPE_PRIMARY },
> > + { .base = 0x00, .phy = &rk3036_win1_data,
> > + .type = DRM_PLANE_TYPE_CURSOR },
> > +};
> > +
> > +static const int rk3036_vop_intrs[] = {
> > + DSP_HOLD_VALID_INTR,
> > + FS_INTR,
> > + LINE_FLAG_INTR,
> > + BUS_ERROR_INTR,
> > +};
> > +
> > +static const struct vop_intr rk3036_intr = {
> > + .intrs = rk3036_vop_intrs,
> > + .nintrs = ARRAY_SIZE(rk3036_vop_intrs),
> > + .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0),
> > + .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4),
> > + .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8),
> > +};
> > +
> > +static const struct vop_ctrl rk3036_ctrl_data = {
> > + .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30),
> > + .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0),
> > + .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4),
> > + .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
> > + .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0),
> > + .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
> > + .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0),
> > + .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0),
> > +};
> > +
> > +static const struct vop_reg_data rk3036_vop_init_reg_table[] = {
> > + {RK3036_DSP_CTRL1, 0x00000000},
> > +};
> > +
> > +static const struct vop_data rk3036_vop = {
> > + .init_table = rk3036_vop_init_reg_table,
> > + .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table),
> > + .ctrl = &rk3036_ctrl_data,
> > + .intr = &rk3036_intr,
> > + .win = rk3036_vop_win_data,
> > + .win_size = ARRAY_SIZE(rk3036_vop_win_data),
> > +};
> > +
> > static const struct vop_scl_extension rk3288_win_full_scl_ext = {
> > .cbcr_vsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 31),
> > .cbcr_vsu_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 30),
> > @@ -190,93 +272,11 @@ static const struct vop_data rk3288_vop = {
> > .win_size = ARRAY_SIZE(rk3288_vop_win_data),
> > };
> > -static const struct vop_scl_regs rk3036_win_scl = {
> > - .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0),
> > - .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16),
> > - .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0),
> > - .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16),
> > -};
> > -
> > -static const struct vop_win_phy rk3036_win0_data = {
> > - .scl = &rk3036_win_scl,
> > - .data_formats = formats_win_full,
> > - .nformats = ARRAY_SIZE(formats_win_full),
> > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0),
> > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3),
> > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15),
> > - .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0),
> > - .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0),
> > - .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0),
> > - .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0),
> > - .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0),
> > - .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0),
> > - .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16),
> > -};
> > -
> > -static const struct vop_win_phy rk3036_win1_data = {
> > - .data_formats = formats_win_lite,
> > - .nformats = ARRAY_SIZE(formats_win_lite),
> > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1),
> > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6),
> > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19),
> > - .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0),
> > - .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0),
> > - .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0),
> > - .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0),
> > - .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0),
> > -};
> > -
> > -static const struct vop_win_data rk3036_vop_win_data[] = {
> > - { .base = 0x00, .phy = &rk3036_win0_data,
> > - .type = DRM_PLANE_TYPE_PRIMARY },
> > - { .base = 0x00, .phy = &rk3036_win1_data,
> > - .type = DRM_PLANE_TYPE_CURSOR },
> > -};
> > -
> > -static const int rk3036_vop_intrs[] = {
> > - DSP_HOLD_VALID_INTR,
> > - FS_INTR,
> > - LINE_FLAG_INTR,
> > - BUS_ERROR_INTR,
> > -};
> > -
> > -static const struct vop_intr rk3036_intr = {
> > - .intrs = rk3036_vop_intrs,
> > - .nintrs = ARRAY_SIZE(rk3036_vop_intrs),
> > - .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0),
> > - .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4),
> > - .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8),
> > -};
> > -
> > -static const struct vop_ctrl rk3036_ctrl_data = {
> > - .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30),
> > - .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0),
> > - .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4),
> > - .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0),
> > - .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0),
> > - .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0),
> > - .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0),
> > - .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0),
> > -};
> > -
> > -static const struct vop_reg_data rk3036_vop_init_reg_table[] = {
> > - {RK3036_DSP_CTRL1, 0x00000000},
> > -};
> > -
> > -static const struct vop_data rk3036_vop = {
> > - .init_table = rk3036_vop_init_reg_table,
> > - .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table),
> > - .ctrl = &rk3036_ctrl_data,
> > - .intr = &rk3036_intr,
> > - .win = rk3036_vop_win_data,
> > - .win_size = ARRAY_SIZE(rk3036_vop_win_data),
> > -};
> > -
> > static const struct of_device_id vop_driver_dt_match[] = {
> > - { .compatible = "rockchip,rk3288-vop",
> > - .data = &rk3288_vop },
> > { .compatible = "rockchip,rk3036-vop",
> > .data = &rk3036_vop },
> > + { .compatible = "rockchip,rk3288-vop",
> > + .data = &rk3288_vop },
> > {},
> > };
> > MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
>
>
> --
> ?ark Yao
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2016-08-18 9:11 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 6:18 [PATCH v2 0/5] drm/rockchip: add rk3399 display controller support Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-04-20 6:18 ` [PATCH v2 1/5] drm/rockchip: sort registers define by chip's number Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-06-02 6:51 ` Tomasz Figa
2016-06-02 7:05 ` Mark yao
2016-08-17 17:20 ` [PATCH v3 " Sean Paul
2016-08-17 17:20 ` Sean Paul
2016-08-17 17:20 ` Sean Paul
2016-08-18 9:08 ` Mark yao
2016-08-18 9:08 ` Mark yao
2016-08-18 9:08 ` Mark yao
2016-08-18 9:11 ` Daniel Vetter [this message]
2016-08-18 9:11 ` Daniel Vetter
2016-08-18 9:11 ` Daniel Vetter
2016-08-18 10:02 ` Mark yao
2016-08-18 10:02 ` Mark yao
2016-08-18 10:02 ` Mark yao
2016-08-22 20:30 ` Sean Paul
2016-08-22 20:30 ` Sean Paul
2016-08-22 20:30 ` Sean Paul
2016-08-23 0:40 ` Mark yao
2016-08-23 0:40 ` Mark yao
2016-08-23 13:13 ` Sean Paul
2016-08-23 13:13 ` Sean Paul
2016-08-23 13:13 ` Sean Paul
2016-08-25 2:25 ` Mark yao
2016-08-25 2:25 ` Mark yao
2016-08-25 2:25 ` Mark yao
2016-08-25 17:15 ` Sean Paul
2016-08-25 17:17 ` Sean Paul
2016-08-25 17:17 ` Sean Paul
2016-08-25 17:17 ` Sean Paul
2016-04-20 6:18 ` [PATCH v2 2/5] dt-bindings: sort Rockchip vop compatible " Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-06-02 6:56 ` Tomasz Figa
2016-08-17 17:11 ` [PATCH v3 " Sean Paul
2016-08-17 17:11 ` Sean Paul
2016-08-17 17:11 ` Sean Paul
2016-08-18 21:15 ` Sean Paul
2016-08-18 21:15 ` Sean Paul
2016-08-18 21:15 ` Sean Paul
2016-08-19 13:51 ` Rob Herring
2016-08-19 13:51 ` Rob Herring
2016-08-19 13:51 ` Rob Herring
2016-04-20 6:18 ` [PATCH v2 3/5] drm/rockchip: vop: introduce VOP_REG_MASK Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-06-02 7:19 ` Tomasz Figa
2016-08-17 17:23 ` [PATCH v3 " Sean Paul
2016-08-17 17:23 ` Sean Paul
2016-08-17 17:23 ` Sean Paul
2016-04-20 6:18 ` [PATCH v2 4/5] drm/rockchip: vop: add rk3399 vop support Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-04-20 6:18 ` Mark Yao
2016-06-02 7:27 ` Tomasz Figa
2016-04-20 6:20 ` [PATCH v2 5/5] dt-bindings: add documentation for Rockchip rk3399 display controllers Mark Yao
2016-04-20 6:20 ` Mark Yao
2016-04-20 6:20 ` Mark Yao
2016-06-02 7:33 ` Tomasz Figa
2016-08-17 17:16 ` [PATCH v3 5/5] dt-bindings: add compatible strings for big/little rockchip vops Sean Paul
2016-08-17 17:16 ` Sean Paul
2016-08-17 17:16 ` Sean Paul
[not found] <0001-<1471454202-1631-1-git-send-email-seanpaul@chromium.org>
2016-08-18 21:12 ` Sean Paul
2016-08-18 21:12 ` Sean Paul
2016-08-18 21:12 ` Sean Paul
2016-08-19 13:50 ` Rob Herring
2016-08-19 13:50 ` Rob Herring
2016-08-19 13:50 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818091141.GZ6232@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.