All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: linux-kernel@vger.kernel.org, mcgrof@kernel.org, teg@jklm.no,
	kay@vrfy.org, rusty@rustcorp.com.au, akpm@linux-foundation.org,
	Fengguang Wu <fengguang.wu@intel.com>,
	backports@vger.kernel.org,
	"vegard.nossum@gmail.com" <vegard.nossum@gmail.com>
Subject: Re: [RFC PATCH 3/5] Trigger Module.ksymb generation in Makefile
Date: Thu, 18 Aug 2016 20:30:28 +0200	[thread overview]
Message-ID: <20160818183028.GQ3296@wotan.suse.de> (raw)
In-Reply-To: <1471462023-119645-4-git-send-email-cristina.moraru09@gmail.com>

On Wed, Aug 17, 2016 at 09:27:01PM +0200, Cristina Moraru wrote:
> Trigger the generation of file scripts/Module.ksymb in
> Makefile by calling updated scripts/streamline_config.pl
> with corresponding parameter (--genmodulesymb). The file
> is generated at each compilation considering that
> associations may change after tree updates.

I really like this approach as you make the resolver
configurable, this lets others experiment and consider
alternatives.

make KSYMB_GENERATOR=/path/research/my-config-generator-is-better

The fact that you can do this should be documented as part of
the patch commit log.

You'll want to wrap this generation under a CONFIG option so only
kernels that want generate this file.

> This patch is part of a research project within
> Google Summer of Code of porting 'make localmodconfig'
> for backported drivers. The goal is to enable each
> module to expose in /sys its corresponding CONFIG_* option.
> The value of this attribute will be dynamically pegged by
> modpost without requiring extra work from the driver developers.
> Further, this information will be used by a hardware interogation
> tool to extract build information about the existing devices.

You can leave this out.

> 
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> ---
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 393b615..286b949 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -219,6 +219,10 @@ VPATH		:= $(srctree)$(if $(KBUILD_EXTMOD),:$(KBUILD_EXTMOD))
>  
>  export srctree objtree VPATH
>  
> +KSYMB_GENERATOR := $(objtree)/scripts/kconfig/streamline_config.pl
> +ksymb_gen_command = perl $(KSYMB_GENERATOR) --genmoduleksymb $(objtree) $(Kconfig)

$(PERL)

> +ksymb_update := $(shell objtree=$(objtree) srctree=$(srctree) $(ksymb_gen_command))
> +
>  # SUBARCH tells the usermode build what the underlying arch is.  That is set
>  # first, and if a usermode build is happening, the "ARCH=um" on the command
>  # line overrides the setting of ARCH below.  If a native build is happening,
> -- 
> 2.7.4

  Luis
--
To unsubscribe from this list: send the line "unsubscribe backports" in

WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: linux-kernel@vger.kernel.org, mcgrof@kernel.org, teg@jklm.no,
	kay@vrfy.org, rusty@rustcorp.com.au, akpm@linux-foundation.org,
	Fengguang Wu <fengguang.wu@intel.com>,
	backports@vger.kernel.org,
	"vegard.nossum@gmail.com" <vegard.nossum@gmail.com>
Subject: Re: [RFC PATCH 3/5] Trigger Module.ksymb generation in Makefile
Date: Thu, 18 Aug 2016 20:30:28 +0200	[thread overview]
Message-ID: <20160818183028.GQ3296@wotan.suse.de> (raw)
In-Reply-To: <1471462023-119645-4-git-send-email-cristina.moraru09@gmail.com>

On Wed, Aug 17, 2016 at 09:27:01PM +0200, Cristina Moraru wrote:
> Trigger the generation of file scripts/Module.ksymb in
> Makefile by calling updated scripts/streamline_config.pl
> with corresponding parameter (--genmodulesymb). The file
> is generated at each compilation considering that
> associations may change after tree updates.

I really like this approach as you make the resolver
configurable, this lets others experiment and consider
alternatives.

make KSYMB_GENERATOR=/path/research/my-config-generator-is-better

The fact that you can do this should be documented as part of
the patch commit log.

You'll want to wrap this generation under a CONFIG option so only
kernels that want generate this file.

> This patch is part of a research project within
> Google Summer of Code of porting 'make localmodconfig'
> for backported drivers. The goal is to enable each
> module to expose in /sys its corresponding CONFIG_* option.
> The value of this attribute will be dynamically pegged by
> modpost without requiring extra work from the driver developers.
> Further, this information will be used by a hardware interogation
> tool to extract build information about the existing devices.

You can leave this out.

> 
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> ---
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 393b615..286b949 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -219,6 +219,10 @@ VPATH		:= $(srctree)$(if $(KBUILD_EXTMOD),:$(KBUILD_EXTMOD))
>  
>  export srctree objtree VPATH
>  
> +KSYMB_GENERATOR := $(objtree)/scripts/kconfig/streamline_config.pl
> +ksymb_gen_command = perl $(KSYMB_GENERATOR) --genmoduleksymb $(objtree) $(Kconfig)

$(PERL)

> +ksymb_update := $(shell objtree=$(objtree) srctree=$(srctree) $(ksymb_gen_command))
> +
>  # SUBARCH tells the usermode build what the underlying arch is.  That is set
>  # first, and if a usermode build is happening, the "ARCH=um" on the command
>  # line overrides the setting of ARCH below.  If a native build is happening,
> -- 
> 2.7.4

  Luis

  reply	other threads:[~2016-08-18 19:43 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17 19:26 [RFC PATCH 0/5] Add CONFIG symbol as module attribute Cristina Moraru
2016-08-17 19:26 ` [RFC PATCH 1/5] Add generation of Module.symb in streamline_config Cristina Moraru
2016-08-18 18:22   ` Luis R. Rodriguez
2016-08-18 18:22     ` Luis R. Rodriguez
2016-08-18 18:32     ` Luis R. Rodriguez
2016-08-18 18:32       ` Luis R. Rodriguez
     [not found]     ` <CAGZ2q2xi9Uy-ye387=mWhy_fOEJBC593Nos7fH027m-_ZdoOXA@mail.gmail.com>
2016-08-20 14:49       ` Cristina-Gabriela Moraru
2016-08-20 14:49         ` Cristina-Gabriela Moraru
2016-08-23 19:00       ` Luis R. Rodriguez
2016-08-23 19:00         ` Luis R. Rodriguez
2016-08-17 19:27 ` [RFC PATCH 2/5] Add CONFIG symbol to module as compilation parameter Cristina Moraru
2016-08-18 18:10   ` Luis R. Rodriguez
2016-08-18 18:10     ` Luis R. Rodriguez
2016-08-18 18:55     ` Luis R. Rodriguez
2016-08-18 18:55       ` Luis R. Rodriguez
2016-08-20 15:11     ` Cristina-Gabriela Moraru
2016-08-20 15:11       ` Cristina-Gabriela Moraru
2016-08-23 19:07       ` Luis R. Rodriguez
2016-08-23 19:07         ` Luis R. Rodriguez
2016-08-17 19:27 ` [RFC PATCH 3/5] Trigger Module.ksymb generation in Makefile Cristina Moraru
2016-08-18 18:30   ` Luis R. Rodriguez [this message]
2016-08-18 18:30     ` Luis R. Rodriguez
2016-08-17 19:27 ` [RFC PATCH 4/5] Set KCONFIG_KSYMB as value for kconfig_ksymb module attribute Cristina Moraru
2016-08-18 18:59   ` Luis R. Rodriguez
2016-08-18 18:59     ` Luis R. Rodriguez
2016-08-20 15:16     ` Cristina-Gabriela Moraru
2016-08-20 15:16       ` Cristina-Gabriela Moraru
2016-08-23 19:10       ` Luis R. Rodriguez
2016-08-23 19:10         ` Luis R. Rodriguez
2016-08-17 19:27 ` [RFC PATCH 5/5] Add kconf_symb as kernel " Cristina Moraru
2016-08-18 19:02   ` Luis R. Rodriguez
2016-08-18 19:02     ` Luis R. Rodriguez
2016-08-18 17:55 ` [RFC PATCH 0/5] Add CONFIG symbol as " Luis R. Rodriguez
2016-08-18 17:55   ` Luis R. Rodriguez
2016-08-19  9:07   ` Michal Marek
2016-08-19  9:07     ` Michal Marek
2016-08-22 19:48     ` Cristina-Gabriela Moraru
2016-08-22 19:48       ` Cristina-Gabriela Moraru
2016-08-23 21:32     ` Luis R. Rodriguez
2016-08-23 21:32       ` Luis R. Rodriguez
2016-08-24 11:05       ` Michal Marek
2016-08-24 11:05         ` Michal Marek
2016-08-24 16:33         ` Luis R. Rodriguez
2016-08-24 16:33           ` Luis R. Rodriguez
2016-08-24 17:31           ` Naveen Kumar
2016-08-24 17:31             ` Naveen Kumar
2016-08-22 19:35   ` Cristina-Gabriela Moraru
2016-08-22 19:35     ` Cristina-Gabriela Moraru
2016-08-23 19:17     ` Luis R. Rodriguez
2016-08-23 19:17       ` Luis R. Rodriguez
2016-08-25  7:43   ` Christoph Hellwig
2016-08-25  7:43     ` Christoph Hellwig
2016-08-25  8:00     ` Johannes Berg
2016-08-25  8:00       ` Johannes Berg
2016-08-25 19:51       ` Luis R. Rodriguez
2016-08-25 19:51         ` Luis R. Rodriguez
2016-08-25  8:41     ` Michal Marek
2016-08-25  8:41       ` Michal Marek
2016-08-25 20:19     ` Luis R. Rodriguez
2016-08-25 20:19       ` Luis R. Rodriguez
2019-02-05 22:07       ` Luis Chamberlain
2019-02-05 22:07         ` Luis Chamberlain
2019-06-26 22:21         ` Luis Chamberlain
2019-06-26 22:21           ` Luis Chamberlain
2019-06-27  4:50           ` Christoph Hellwig
2019-06-27  4:50             ` Christoph Hellwig
2019-06-28 18:40             ` Luis Chamberlain
2019-06-28 18:40               ` Luis Chamberlain
2019-06-29  8:42               ` Greg Kroah-Hartman
2019-06-29  8:42                 ` Greg Kroah-Hartman
2019-07-02 20:51                 ` Luis Chamberlain
2019-07-02 20:51                   ` Luis Chamberlain
2019-07-03  7:40                   ` Greg Kroah-Hartman
2019-07-03  7:40                     ` Greg Kroah-Hartman
2019-07-03 16:50                     ` Luis Chamberlain
2019-07-03 16:50                       ` Luis Chamberlain
2019-07-03 18:57                       ` Greg Kroah-Hartman
2019-07-03 18:57                         ` Greg Kroah-Hartman
2019-07-03 22:25                         ` Luis Chamberlain
2019-07-03 22:25                           ` Luis Chamberlain
2019-07-11 23:07                           ` Brendan Higgins
2019-07-11 23:07                             ` Brendan Higgins
2019-07-11 23:22                             ` Luis Chamberlain
2019-07-11 23:22                               ` Luis Chamberlain
2019-07-03 12:16               ` Enrico Weigelt, metux IT consult
2019-07-03 12:16                 ` Enrico Weigelt, metux IT consult
2019-07-03 17:35                 ` Luis Chamberlain
2019-07-03 17:35                   ` Luis Chamberlain
2019-07-03 19:31                   ` Enrico Weigelt, metux IT consult
2019-07-03 19:31                     ` Enrico Weigelt, metux IT consult
2019-07-03 22:42                     ` Luis Chamberlain
2019-07-03 22:42                       ` Luis Chamberlain
2019-07-11 23:27                       ` Brendan Higgins
2019-07-11 23:27                         ` Brendan Higgins
2019-07-13 14:44                         ` Enrico Weigelt, metux IT consult
2019-07-13 14:44                           ` Enrico Weigelt, metux IT consult

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160818183028.GQ3296@wotan.suse.de \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=backports@vger.kernel.org \
    --cc=cristina.moraru09@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=teg@jklm.no \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.