[PATCH RESEND] leds: centralize definition of "default-state" property

[PATCH RESEND] leds: centralize definition of "default-state" property

[Linus Walleij]

Four different drivers define the "default-state" property.
Move this into the common.txt common LEDs properties.

Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Resending trying to get attention from the devicetree
maintainers.
---
 Documentation/devicetree/bindings/leds/common.txt           | 7 +++++++
 Documentation/devicetree/bindings/leds/leds-bcm6328.txt     | 2 +-
 Documentation/devicetree/bindings/leds/leds-bcm6358.txt     | 2 +-
 Documentation/devicetree/bindings/leds/leds-gpio.txt        | 9 ++-------
 Documentation/devicetree/bindings/leds/register-bit-led.txt | 9 ++-------
 5 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index 93ef6e6e43b5..696be5792625 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -19,6 +19,13 @@ Optional properties for child nodes:
 	  a device, i.e. no other LED class device can be assigned the same
 	  label.
 
+- default-state : The initial state of the LED. Valid values are "on", "off",
+  and "keep". If the LED is already on or off and the default-state property is
+  set the to same value, then no glitch should be produced where the LED
+  momentarily turns off (or on). The "keep" setting will keep the LED at
+  whatever its current state is, without producing a glitch.  The default is
+  off if this property is not present.
+
 - linux,default-trigger :  This parameter, if present, is a
     string defining the trigger assigned to the LED.  Current triggers are:
      "backlight" - LED will act as a back-light, controlled by the framebuffer
diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6328.txt b/Documentation/devicetree/bindings/leds/leds-bcm6328.txt
index 3f48c1eaf085..ccebce597f37 100644
--- a/Documentation/devicetree/bindings/leds/leds-bcm6328.txt
+++ b/Documentation/devicetree/bindings/leds/leds-bcm6328.txt
@@ -49,7 +49,7 @@ LED sub-node optional properties:
     - active-low : Boolean, makes LED active low.
       Default : false
     - default-state : see
-      Documentation/devicetree/bindings/leds/leds-gpio.txt
+      Documentation/devicetree/bindings/leds/common.txt
     - linux,default-trigger : see
       Documentation/devicetree/bindings/leds/common.txt
 
diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt
index b22a55bcc65d..da5708e7b43b 100644
--- a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt
+++ b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt
@@ -28,7 +28,7 @@ LED sub-node optional properties:
   - active-low : Boolean, makes LED active low.
     Default : false
   - default-state : see
-    Documentation/devicetree/bindings/leds/leds-gpio.txt
+    Documentation/devicetree/bindings/leds/common.txt
   - linux,default-trigger : see
     Documentation/devicetree/bindings/leds/common.txt
 
diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt
index 5b1b43a64265..76535ca37120 100644
--- a/Documentation/devicetree/bindings/leds/leds-gpio.txt
+++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt
@@ -14,13 +14,8 @@ LED sub-node properties:
   see Documentation/devicetree/bindings/leds/common.txt
 - linux,default-trigger :  (optional)
   see Documentation/devicetree/bindings/leds/common.txt
-- default-state:  (optional) The initial state of the LED.  Valid
-  values are "on", "off", and "keep".  If the LED is already on or off
-  and the default-state property is set the to same value, then no
-  glitch should be produced where the LED momentarily turns off (or
-  on).  The "keep" setting will keep the LED at whatever its current
-  state is, without producing a glitch.  The default is off if this
-  property is not present.
+- default-state:  (optional) The initial state of the LED.
+  see Documentation/devicetree/bindings/leds/common.txt
 - retain-state-suspended: (optional) The suspend state can be retained.Such
   as charge-led gpio.
 - panic-indicator : (optional)
diff --git a/Documentation/devicetree/bindings/leds/register-bit-led.txt b/Documentation/devicetree/bindings/leds/register-bit-led.txt
index 379cefdc0bda..59b56365f648 100644
--- a/Documentation/devicetree/bindings/leds/register-bit-led.txt
+++ b/Documentation/devicetree/bindings/leds/register-bit-led.txt
@@ -23,13 +23,8 @@ Optional properties:
   see Documentation/devicetree/bindings/leds/common.txt
 - linux,default-trigger : (optional)
   see Documentation/devicetree/bindings/leds/common.txt
-- default-state: (optional) The initial state of the LED. Valid
-  values are "on", "off", and "keep". If the LED is already on or off
-  and the default-state property is set the to same value, then no
-  glitch should be produced where the LED momentarily turns off (or
-  on). The "keep" setting will keep the LED at whatever its current
-  state is, without producing a glitch.  The default is off if this
-  property is not present.
+- default-state: (optional) The initial state of the LED
+  see Documentation/devicetree/bindings/leds/common.txt
 
 Example:
 
-- 
2.7.4

Re: [PATCH RESEND] leds: centralize definition of "default-state" property

[Rob Herring]

On Tue, Aug 16, 2016 at 09:41:36PM +0200, Linus Walleij wrote:
> Four different drivers define the "default-state" property.
> Move this into the common.txt common LEDs properties.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Resending trying to get attention from the devicetree
> maintainers.
> ---
>  Documentation/devicetree/bindings/leds/common.txt           | 7 +++++++
>  Documentation/devicetree/bindings/leds/leds-bcm6328.txt     | 2 +-
>  Documentation/devicetree/bindings/leds/leds-bcm6358.txt     | 2 +-
>  Documentation/devicetree/bindings/leds/leds-gpio.txt        | 9 ++-------
>  Documentation/devicetree/bindings/leds/register-bit-led.txt | 9 ++-------
>  5 files changed, 13 insertions(+), 16 deletions(-)

I'm assuming Jacek will take this. If not, let me know.

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH RESEND] leds: centralize definition of "default-state" property

[Jacek Anaszewski]

On 08/18/2016 09:25 PM, Rob Herring wrote:
> On Tue, Aug 16, 2016 at 09:41:36PM +0200, Linus Walleij wrote:
>> Four different drivers define the "default-state" property.
>> Move this into the common.txt common LEDs properties.
>>
>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>> Resending trying to get attention from the devicetree
>> maintainers.
>> ---
>>   Documentation/devicetree/bindings/leds/common.txt           | 7 +++++++
>>   Documentation/devicetree/bindings/leds/leds-bcm6328.txt     | 2 +-
>>   Documentation/devicetree/bindings/leds/leds-bcm6358.txt     | 2 +-
>>   Documentation/devicetree/bindings/leds/leds-gpio.txt        | 9 ++-------
>>   Documentation/devicetree/bindings/leds/register-bit-led.txt | 9 ++-------
>>   5 files changed, 13 insertions(+), 16 deletions(-)
>
> I'm assuming Jacek will take this. If not, let me know.
>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Applied, thanks.

-- 
Best regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html