All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	David Airlie <airlied@linux.ie>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Julia Lawall <julia.lawall@lip6.fr>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] virtio-gpu: Use memdup_user() rather than duplicating its implementation
Date: Fri, 19 Aug 2016 09:50:49 +0200	[thread overview]
Message-ID: <20160819075049.GV6232@phenom.ffwll.local> (raw)
In-Reply-To: <401e68fc-5515-7a7a-be2e-503dee676b34@users.sourceforge.net>

On Thu, Aug 18, 2016 at 10:42:06PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 18 Aug 2016 22:35:14 +0200
> 
> Reuse existing functionality from memdup_user() instead of keeping
> duplicate source code.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied to drm-misc.
-Daniel

> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index c046903..512e7cd 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -152,15 +152,10 @@ static int virtio_gpu_execbuffer(struct drm_device *dev,
>  	if (ret)
>  		goto out_free;
>  
> -	buf = kmalloc(exbuf->size, GFP_KERNEL);
> -	if (!buf) {
> -		ret = -ENOMEM;
> -		goto out_unresv;
> -	}
> -	if (copy_from_user(buf, (void __user *)(uintptr_t)exbuf->command,
> -			   exbuf->size)) {
> -		kfree(buf);
> -		ret = -EFAULT;
> +	buf = memdup_user((void __user *)(uintptr_t)exbuf->command,
> +			  exbuf->size);
> +	if (IS_ERR(buf)) {
> +		ret = PTR_ERR(buf);
>  		goto out_unresv;
>  	}
>  	virtio_gpu_cmd_submit(vgdev, buf, exbuf->size,
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	Julia Lawall <julia.lawall@lip6.fr>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] virtio-gpu: Use memdup_user() rather than duplicating its implementation
Date: Fri, 19 Aug 2016 07:50:49 +0000	[thread overview]
Message-ID: <20160819075049.GV6232@phenom.ffwll.local> (raw)
In-Reply-To: <401e68fc-5515-7a7a-be2e-503dee676b34@users.sourceforge.net>

On Thu, Aug 18, 2016 at 10:42:06PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 18 Aug 2016 22:35:14 +0200
> 
> Reuse existing functionality from memdup_user() instead of keeping
> duplicate source code.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied to drm-misc.
-Daniel

> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index c046903..512e7cd 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -152,15 +152,10 @@ static int virtio_gpu_execbuffer(struct drm_device *dev,
>  	if (ret)
>  		goto out_free;
>  
> -	buf = kmalloc(exbuf->size, GFP_KERNEL);
> -	if (!buf) {
> -		ret = -ENOMEM;
> -		goto out_unresv;
> -	}
> -	if (copy_from_user(buf, (void __user *)(uintptr_t)exbuf->command,
> -			   exbuf->size)) {
> -		kfree(buf);
> -		ret = -EFAULT;
> +	buf = memdup_user((void __user *)(uintptr_t)exbuf->command,
> +			  exbuf->size);
> +	if (IS_ERR(buf)) {
> +		ret = PTR_ERR(buf);
>  		goto out_unresv;
>  	}
>  	virtio_gpu_cmd_submit(vgdev, buf, exbuf->size,
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	Julia Lawall <julia.lawall@lip6.fr>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] virtio-gpu: Use memdup_user() rather than duplicating its implementation
Date: Fri, 19 Aug 2016 09:50:49 +0200	[thread overview]
Message-ID: <20160819075049.GV6232@phenom.ffwll.local> (raw)
In-Reply-To: <401e68fc-5515-7a7a-be2e-503dee676b34@users.sourceforge.net>

On Thu, Aug 18, 2016 at 10:42:06PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 18 Aug 2016 22:35:14 +0200
> 
> Reuse existing functionality from memdup_user() instead of keeping
> duplicate source code.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied to drm-misc.
-Daniel

> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index c046903..512e7cd 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -152,15 +152,10 @@ static int virtio_gpu_execbuffer(struct drm_device *dev,
>  	if (ret)
>  		goto out_free;
>  
> -	buf = kmalloc(exbuf->size, GFP_KERNEL);
> -	if (!buf) {
> -		ret = -ENOMEM;
> -		goto out_unresv;
> -	}
> -	if (copy_from_user(buf, (void __user *)(uintptr_t)exbuf->command,
> -			   exbuf->size)) {
> -		kfree(buf);
> -		ret = -EFAULT;
> +	buf = memdup_user((void __user *)(uintptr_t)exbuf->command,
> +			  exbuf->size);
> +	if (IS_ERR(buf)) {
> +		ret = PTR_ERR(buf);
>  		goto out_unresv;
>  	}
>  	virtio_gpu_cmd_submit(vgdev, buf, exbuf->size,
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-08-19  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 20:42 [PATCH] virtio-gpu: Use memdup_user() rather than duplicating its implementation SF Markus Elfring
2016-08-18 20:42 ` SF Markus Elfring
2016-08-18 20:42 ` SF Markus Elfring
2016-08-19  7:50 ` Daniel Vetter [this message]
2016-08-19  7:50   ` Daniel Vetter
2016-08-19  7:50   ` Daniel Vetter
2016-08-19  7:50 ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2016-08-18 20:42 SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819075049.GV6232@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=elfring@users.sourceforge.net \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.