* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2016-07-11 21:08 ` Stephen Boyd
0 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2016-07-11 21:08 UTC (permalink / raw)
To: Russell King
Cc: linux-kernel, linux-arm-kernel, linux-clk, Michael Turquette,
Jorge Ramirez Ortiz
Add the call to of_clk_set_defaults() into the amba probe path so
that devices on the amba bus can use the assigned rates and
parents feature of the common clock framework.
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/amba/bus.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index a5b5c87e2114..a56fa2a1e9aa 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -19,6 +19,7 @@
#include <linux/amba/bus.h>
#include <linux/sizes.h>
#include <linux/limits.h>
+#include <linux/clk/clk-conf.h>
#include <asm/irq.h>
@@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
int ret;
do {
+ ret = of_clk_set_defaults(dev->of_node, false);
+ if (ret < 0)
+ break;
+
ret = dev_pm_domain_attach(dev, true);
if (ret == -EPROBE_DEFER)
break;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2016-07-11 21:08 ` Stephen Boyd
0 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2016-07-11 21:08 UTC (permalink / raw)
To: linux-arm-kernel
Add the call to of_clk_set_defaults() into the amba probe path so
that devices on the amba bus can use the assigned rates and
parents feature of the common clock framework.
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/amba/bus.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index a5b5c87e2114..a56fa2a1e9aa 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -19,6 +19,7 @@
#include <linux/amba/bus.h>
#include <linux/sizes.h>
#include <linux/limits.h>
+#include <linux/clk/clk-conf.h>
#include <asm/irq.h>
@@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
int ret;
do {
+ ret = of_clk_set_defaults(dev->of_node, false);
+ if (ret < 0)
+ break;
+
ret = dev_pm_domain_attach(dev, true);
if (ret == -EPROBE_DEFER)
break;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] amba: Support clk parents and rates assigned in DT
2016-07-11 21:08 ` Stephen Boyd
@ 2016-07-12 0:39 ` Jorge Ramirez
-1 siblings, 0 replies; 18+ messages in thread
From: Jorge Ramirez @ 2016-07-12 0:39 UTC (permalink / raw)
To: Stephen Boyd, Russell King
Cc: linux-kernel, linux-arm-kernel, linux-clk, Michael Turquette
On 07/11/2016 11:08 PM, Stephen Boyd wrote:
> Add the call to of_clk_set_defaults() into the amba probe path so
> that devices on the amba bus can use the assigned rates and
> parents feature of the common clock framework.
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Tested-by: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> drivers/amba/bus.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index a5b5c87e2114..a56fa2a1e9aa 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -19,6 +19,7 @@
> #include <linux/amba/bus.h>
> #include <linux/sizes.h>
> #include <linux/limits.h>
> +#include <linux/clk/clk-conf.h>
>
> #include <asm/irq.h>
>
> @@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
> int ret;
>
> do {
> + ret = of_clk_set_defaults(dev->of_node, false);
> + if (ret < 0)
> + break;
> +
> ret = dev_pm_domain_attach(dev, true);
> if (ret == -EPROBE_DEFER)
> break;
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2016-07-12 0:39 ` Jorge Ramirez
0 siblings, 0 replies; 18+ messages in thread
From: Jorge Ramirez @ 2016-07-12 0:39 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2016 11:08 PM, Stephen Boyd wrote:
> Add the call to of_clk_set_defaults() into the amba probe path so
> that devices on the amba bus can use the assigned rates and
> parents feature of the common clock framework.
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Tested-by: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> drivers/amba/bus.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index a5b5c87e2114..a56fa2a1e9aa 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -19,6 +19,7 @@
> #include <linux/amba/bus.h>
> #include <linux/sizes.h>
> #include <linux/limits.h>
> +#include <linux/clk/clk-conf.h>
>
> #include <asm/irq.h>
>
> @@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
> int ret;
>
> do {
> + ret = of_clk_set_defaults(dev->of_node, false);
> + if (ret < 0)
> + break;
> +
> ret = dev_pm_domain_attach(dev, true);
> if (ret == -EPROBE_DEFER)
> break;
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] amba: Support clk parents and rates assigned in DT
2016-07-11 21:08 ` Stephen Boyd
@ 2016-08-19 6:52 ` Jorge Ramirez
-1 siblings, 0 replies; 18+ messages in thread
From: Jorge Ramirez @ 2016-08-19 6:52 UTC (permalink / raw)
To: Stephen Boyd, Russell King
Cc: linux-kernel, linux-arm-kernel, linux-clk, Michael Turquette
On 07/11/2016 11:08 PM, Stephen Boyd wrote:
> Add the call to of_clk_set_defaults() into the amba probe path so
> that devices on the amba bus can use the assigned rates and
> parents feature of the common clock framework.
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/amba/bus.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index a5b5c87e2114..a56fa2a1e9aa 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -19,6 +19,7 @@
> #include <linux/amba/bus.h>
> #include <linux/sizes.h>
> #include <linux/limits.h>
> +#include <linux/clk/clk-conf.h>
>
> #include <asm/irq.h>
>
> @@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
> int ret;
>
> do {
> + ret = of_clk_set_defaults(dev->of_node, false);
> + if (ret < 0)
> + break;
> +
> ret = dev_pm_domain_attach(dev, true);
> if (ret == -EPROBE_DEFER)
> break;
Stephen/Russell,
what is the status of this patch? has it been merged?
thanks
Jorge
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2016-08-19 6:52 ` Jorge Ramirez
0 siblings, 0 replies; 18+ messages in thread
From: Jorge Ramirez @ 2016-08-19 6:52 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2016 11:08 PM, Stephen Boyd wrote:
> Add the call to of_clk_set_defaults() into the amba probe path so
> that devices on the amba bus can use the assigned rates and
> parents feature of the common clock framework.
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/amba/bus.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index a5b5c87e2114..a56fa2a1e9aa 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -19,6 +19,7 @@
> #include <linux/amba/bus.h>
> #include <linux/sizes.h>
> #include <linux/limits.h>
> +#include <linux/clk/clk-conf.h>
>
> #include <asm/irq.h>
>
> @@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
> int ret;
>
> do {
> + ret = of_clk_set_defaults(dev->of_node, false);
> + if (ret < 0)
> + break;
> +
> ret = dev_pm_domain_attach(dev, true);
> if (ret == -EPROBE_DEFER)
> break;
Stephen/Russell,
what is the status of this patch? has it been merged?
thanks
Jorge
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] amba: Support clk parents and rates assigned in DT
2016-08-19 6:52 ` Jorge Ramirez
@ 2016-08-19 7:53 ` Russell King - ARM Linux
-1 siblings, 0 replies; 18+ messages in thread
From: Russell King - ARM Linux @ 2016-08-19 7:53 UTC (permalink / raw)
To: Jorge Ramirez
Cc: Stephen Boyd, linux-kernel, linux-arm-kernel, linux-clk,
Michael Turquette
On Fri, Aug 19, 2016 at 08:52:35AM +0200, Jorge Ramirez wrote:
> On 07/11/2016 11:08 PM, Stephen Boyd wrote:
> >Add the call to of_clk_set_defaults() into the amba probe path so
> >that devices on the amba bus can use the assigned rates and
> >parents feature of the common clock framework.
> >
> >Cc: Michael Turquette <mturquette@baylibre.com>
> >Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> >Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> >---
> > drivers/amba/bus.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> >diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> >index a5b5c87e2114..a56fa2a1e9aa 100644
> >--- a/drivers/amba/bus.c
> >+++ b/drivers/amba/bus.c
> >@@ -19,6 +19,7 @@
> > #include <linux/amba/bus.h>
> > #include <linux/sizes.h>
> > #include <linux/limits.h>
> >+#include <linux/clk/clk-conf.h>
> > #include <asm/irq.h>
> >@@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
> > int ret;
> > do {
> >+ ret = of_clk_set_defaults(dev->of_node, false);
> >+ if (ret < 0)
> >+ break;
> >+
> > ret = dev_pm_domain_attach(dev, true);
> > if (ret == -EPROBE_DEFER)
> > break;
>
> Stephen/Russell,
>
> what is the status of this patch? has it been merged?
I assume by that comment that you don't follow linux-next. Please
follow and test linux-next, so you can check for any regressions
that may occur for your platforms in the next merge window, thanks.
You'll find the above patch in linux-next already.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2016-08-19 7:53 ` Russell King - ARM Linux
0 siblings, 0 replies; 18+ messages in thread
From: Russell King - ARM Linux @ 2016-08-19 7:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 19, 2016 at 08:52:35AM +0200, Jorge Ramirez wrote:
> On 07/11/2016 11:08 PM, Stephen Boyd wrote:
> >Add the call to of_clk_set_defaults() into the amba probe path so
> >that devices on the amba bus can use the assigned rates and
> >parents feature of the common clock framework.
> >
> >Cc: Michael Turquette <mturquette@baylibre.com>
> >Cc: Jorge Ramirez Ortiz <jorge.ramirez-ortiz@linaro.org>
> >Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> >---
> > drivers/amba/bus.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> >diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> >index a5b5c87e2114..a56fa2a1e9aa 100644
> >--- a/drivers/amba/bus.c
> >+++ b/drivers/amba/bus.c
> >@@ -19,6 +19,7 @@
> > #include <linux/amba/bus.h>
> > #include <linux/sizes.h>
> > #include <linux/limits.h>
> >+#include <linux/clk/clk-conf.h>
> > #include <asm/irq.h>
> >@@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
> > int ret;
> > do {
> >+ ret = of_clk_set_defaults(dev->of_node, false);
> >+ if (ret < 0)
> >+ break;
> >+
> > ret = dev_pm_domain_attach(dev, true);
> > if (ret == -EPROBE_DEFER)
> > break;
>
> Stephen/Russell,
>
> what is the status of this patch? has it been merged?
I assume by that comment that you don't follow linux-next. Please
follow and test linux-next, so you can check for any regressions
that may occur for your platforms in the next merge window, thanks.
You'll find the above patch in linux-next already.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] amba: Support clk parents and rates assigned in DT
2015-07-07 9:33 ` Russell King - ARM Linux
@ 2015-07-07 10:07 ` Bintian
-1 siblings, 0 replies; 18+ messages in thread
From: Bintian @ 2015-07-07 10:07 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Stephen Boyd, Mike Turquette, linux-kernel, linux-arm-kernel, linux-clk
On 2015/7/7 17:33, Russell King - ARM Linux wrote:
> On Tue, Jul 07, 2015 at 04:47:33PM +0800, Bintian wrote:
>> Hi Russell,
>>
>> Could you spend several minutes to review Stephen's patch?
>
> Sorry, I'm busy this week, I need to sort out my git tree, get some fixes
> out which should've been pushed during the merge window, and other stuff.
> I'm not going to have much time to read email, let alone do reviews.
> Please be patient.
>
No problem, just keep your own pace.
Thanks,
Bintian
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2015-07-07 10:07 ` Bintian
0 siblings, 0 replies; 18+ messages in thread
From: Bintian @ 2015-07-07 10:07 UTC (permalink / raw)
To: linux-arm-kernel
On 2015/7/7 17:33, Russell King - ARM Linux wrote:
> On Tue, Jul 07, 2015 at 04:47:33PM +0800, Bintian wrote:
>> Hi Russell,
>>
>> Could you spend several minutes to review Stephen's patch?
>
> Sorry, I'm busy this week, I need to sort out my git tree, get some fixes
> out which should've been pushed during the merge window, and other stuff.
> I'm not going to have much time to read email, let alone do reviews.
> Please be patient.
>
No problem, just keep your own pace.
Thanks,
Bintian
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] amba: Support clk parents and rates assigned in DT
2015-07-07 8:47 ` Bintian
@ 2015-07-07 9:33 ` Russell King - ARM Linux
-1 siblings, 0 replies; 18+ messages in thread
From: Russell King - ARM Linux @ 2015-07-07 9:33 UTC (permalink / raw)
To: Bintian
Cc: Stephen Boyd, Mike Turquette, linux-kernel, linux-arm-kernel, linux-clk
On Tue, Jul 07, 2015 at 04:47:33PM +0800, Bintian wrote:
> Hi Russell,
>
> Could you spend several minutes to review Stephen's patch?
Sorry, I'm busy this week, I need to sort out my git tree, get some fixes
out which should've been pushed during the merge window, and other stuff.
I'm not going to have much time to read email, let alone do reviews.
Please be patient.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2015-07-07 9:33 ` Russell King - ARM Linux
0 siblings, 0 replies; 18+ messages in thread
From: Russell King - ARM Linux @ 2015-07-07 9:33 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 07, 2015 at 04:47:33PM +0800, Bintian wrote:
> Hi Russell,
>
> Could you spend several minutes to review Stephen's patch?
Sorry, I'm busy this week, I need to sort out my git tree, get some fixes
out which should've been pushed during the merge window, and other stuff.
I'm not going to have much time to read email, let alone do reviews.
Please be patient.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] amba: Support clk parents and rates assigned in DT
2015-07-06 23:57 ` Stephen Boyd
@ 2015-07-07 8:47 ` Bintian
-1 siblings, 0 replies; 18+ messages in thread
From: Bintian @ 2015-07-07 8:47 UTC (permalink / raw)
To: Stephen Boyd, Russell King
Cc: Mike Turquette, linux-kernel, linux-arm-kernel, linux-clk
Hi Russell,
Could you spend several minutes to review Stephen's patch?
Thanks,
Bintian
On 2015/7/7 7:57, Stephen Boyd wrote:
> On 05/28/2015 01:52 PM, Stephen Boyd wrote:
>> Add the call to of_clk_set_defaults() into the amba probe path so
>> that devices on the amba bus can use the assigned rates and
>> parents feature of the common clock framework.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>
> Shall I put this into the patch tracker? Turns out it wasn't needed for
> the hisi stuff immediately.
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2015-07-07 8:47 ` Bintian
0 siblings, 0 replies; 18+ messages in thread
From: Bintian @ 2015-07-07 8:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi Russell,
Could you spend several minutes to review Stephen's patch?
Thanks,
Bintian
On 2015/7/7 7:57, Stephen Boyd wrote:
> On 05/28/2015 01:52 PM, Stephen Boyd wrote:
>> Add the call to of_clk_set_defaults() into the amba probe path so
>> that devices on the amba bus can use the assigned rates and
>> parents feature of the common clock framework.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>
> Shall I put this into the patch tracker? Turns out it wasn't needed for
> the hisi stuff immediately.
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] amba: Support clk parents and rates assigned in DT
2015-05-28 20:52 ` Stephen Boyd
@ 2015-07-06 23:57 ` Stephen Boyd
-1 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2015-07-06 23:57 UTC (permalink / raw)
To: Russell King
Cc: Bintian Wang, Mike Turquette, linux-kernel, linux-arm-kernel, linux-clk
On 05/28/2015 01:52 PM, Stephen Boyd wrote:
> Add the call to of_clk_set_defaults() into the amba probe path so
> that devices on the amba bus can use the assigned rates and
> parents feature of the common clock framework.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Shall I put this into the patch tracker? Turns out it wasn't needed for
the hisi stuff immediately.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2015-07-06 23:57 ` Stephen Boyd
0 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2015-07-06 23:57 UTC (permalink / raw)
To: linux-arm-kernel
On 05/28/2015 01:52 PM, Stephen Boyd wrote:
> Add the call to of_clk_set_defaults() into the amba probe path so
> that devices on the amba bus can use the assigned rates and
> parents feature of the common clock framework.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Shall I put this into the patch tracker? Turns out it wasn't needed for
the hisi stuff immediately.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2015-05-28 20:52 ` Stephen Boyd
0 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2015-05-28 20:52 UTC (permalink / raw)
To: Russell King
Cc: linux-kernel, linux-arm-kernel, Mike Turquette, linux-clk, Bintian Wang
Add the call to of_clk_set_defaults() into the amba probe path so
that devices on the amba bus can use the assigned rates and
parents feature of the common clock framework.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
Russell,
Can you please ack this change? We're going to send it through the clk tree
because hisi clock requires it.
Thanks,
Stephen
drivers/amba/bus.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index f0099360039e..350ed93d4281 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -19,6 +19,7 @@
#include <linux/amba/bus.h>
#include <linux/sizes.h>
#include <linux/limits.h>
+#include <linux/clk/clk-conf.h>
#include <asm/irq.h>
@@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
int ret;
do {
+ ret = of_clk_set_defaults(dev->of_node, false);
+ if (ret < 0)
+ break;
+
ret = dev_pm_domain_attach(dev, true);
if (ret == -EPROBE_DEFER)
break;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] amba: Support clk parents and rates assigned in DT
@ 2015-05-28 20:52 ` Stephen Boyd
0 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2015-05-28 20:52 UTC (permalink / raw)
To: linux-arm-kernel
Add the call to of_clk_set_defaults() into the amba probe path so
that devices on the amba bus can use the assigned rates and
parents feature of the common clock framework.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
Russell,
Can you please ack this change? We're going to send it through the clk tree
because hisi clock requires it.
Thanks,
Stephen
drivers/amba/bus.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index f0099360039e..350ed93d4281 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -19,6 +19,7 @@
#include <linux/amba/bus.h>
#include <linux/sizes.h>
#include <linux/limits.h>
+#include <linux/clk/clk-conf.h>
#include <asm/irq.h>
@@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
int ret;
do {
+ ret = of_clk_set_defaults(dev->of_node, false);
+ if (ret < 0)
+ break;
+
ret = dev_pm_domain_attach(dev, true);
if (ret == -EPROBE_DEFER)
break;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-08-19 7:55 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 21:08 [PATCH] amba: Support clk parents and rates assigned in DT Stephen Boyd
2016-07-11 21:08 ` Stephen Boyd
2016-07-12 0:39 ` Jorge Ramirez
2016-07-12 0:39 ` Jorge Ramirez
2016-08-19 6:52 ` Jorge Ramirez
2016-08-19 6:52 ` Jorge Ramirez
2016-08-19 7:53 ` Russell King - ARM Linux
2016-08-19 7:53 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2015-05-28 20:52 Stephen Boyd
2015-05-28 20:52 ` Stephen Boyd
2015-07-06 23:57 ` Stephen Boyd
2015-07-06 23:57 ` Stephen Boyd
2015-07-07 8:47 ` Bintian
2015-07-07 8:47 ` Bintian
2015-07-07 9:33 ` Russell King - ARM Linux
2015-07-07 9:33 ` Russell King - ARM Linux
2015-07-07 10:07 ` Bintian
2015-07-07 10:07 ` Bintian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.