All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] hplip: needs dynamic library
@ 2016-08-18 20:33 Thomas Petazzoni
  2016-08-19  9:42 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2016-08-18 20:33 UTC (permalink / raw)
  To: buildroot

hplip needs libdl functionality, so it should depend on
!BR2_STATIC_LIBS.

Fixes:

  http://autobuild.buildroot.net/results/afc01af153b42d13845e2f2828f642e8ccea7e06/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/hplip/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/hplip/Config.in b/package/hplip/Config.in
index 7565671..176dc6a 100644
--- a/package/hplip/Config.in
+++ b/package/hplip/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_HPLIP
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_CUPS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+	depends on !BR2_STATIC_LIBS # libdl
 	select BR2_PACKAGE_LIBUSB
 	select BR2_PACKAGE_JPEG
 	help
@@ -15,6 +16,7 @@ config BR2_PACKAGE_HPLIP
 
 	  http://hplipopensource.com/
 
-comment "hplip needs a toolchain w/ C++, threads"
+comment "hplip needs a toolchain w/ C++, threads, dynamic library"
 	depends on BR2_PACKAGE_CUPS
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] hplip: needs dynamic library
  2016-08-18 20:33 [Buildroot] [PATCH] hplip: needs dynamic library Thomas Petazzoni
@ 2016-08-19  9:42 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-08-19  9:42 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 18 Aug 2016 22:33:35 +0200, Thomas Petazzoni wrote:
> hplip needs libdl functionality, so it should depend on
> !BR2_STATIC_LIBS.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/afc01af153b42d13845e2f2828f642e8ccea7e06/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/hplip/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-19  9:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 20:33 [Buildroot] [PATCH] hplip: needs dynamic library Thomas Petazzoni
2016-08-19  9:42 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.