All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [v2 PATCH 3/3] netlink: Use rhashtable walk interface in diag dump
Date: Fri, 19 Aug 2016 18:32:37 +0200	[thread overview]
Message-ID: <20160819163237.GC29430@pox.localdomain> (raw)
In-Reply-To: <20160819082137.GA21510@gondor.apana.org.au>

On 08/19/16 at 04:21pm, Herbert Xu wrote:
> This patch converts the diag dumping code to use the rhashtable
> walk code instead of going through rhashtable by hand.  The lock
> nl_table_lock is now only taken while we process the multicast
> list as it's not needed for the rhashtable walk.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

LGTM. Curious, what did you use to test this? I've been struggling
to find a good test case.

  reply	other threads:[~2016-08-19 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  8:48 [PATCH 0/3] rhashtable: Get rid of raw table walkers part 1 Herbert Xu
2016-08-18  8:50 ` [PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init Herbert Xu
2016-08-19 16:25   ` Thomas Graf
2016-08-19 16:38     ` Herbert Xu
2016-08-18  8:50 ` [PATCH 2/3] MAINTAINERS: Add extra rhashtable maintainer Herbert Xu
2016-08-19 16:25   ` Thomas Graf
2016-08-18  8:50 ` [PATCH 3/3] netlink: Use rhashtable walk interface in diag dump Herbert Xu
2016-08-19  8:09   ` Herbert Xu
2016-08-19  8:21     ` [v2 PATCH " Herbert Xu
2016-08-19 16:32       ` Thomas Graf [this message]
2016-08-19 16:39         ` Herbert Xu
2016-08-19 16:34 ` [PATCH 0/3] rhashtable: Get rid of raw table walkers part 1 Thomas Graf
2016-08-19 21:40 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819163237.GC29430@pox.localdomain \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.