From: Herbert Xu <herbert@gondor.apana.org.au>
To: Thomas Graf <tgraf@suug.ch>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init
Date: Sat, 20 Aug 2016 00:38:35 +0800 [thread overview]
Message-ID: <20160819163835.GA24067@gondor.apana.org.au> (raw)
In-Reply-To: <20160819162504.GA29430@pox.localdomain>
On Fri, Aug 19, 2016 at 06:25:04PM +0200, Thomas Graf wrote:
> On 08/18/16 at 04:50pm, Herbert Xu wrote:
> > +/* Obsolete function, do not use in new code. */
> > +static inline int rhashtable_walk_init(struct rhashtable *ht,
> > + struct rhashtable_iter *iter, gfp_t gfp)
> > +{
> > + rhashtable_walk_enter(ht, iter);
> > + return 0;
> > +}
>
> Converting the 5 users of rhashtable_walk_init() looks very straight
> forward, any reason to keep this around?
It is easy but it's needless churn, especially since we've just
converted all of them the other way.
Feel free to do a patch on top of this to get rid of them.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-08-19 16:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 8:48 [PATCH 0/3] rhashtable: Get rid of raw table walkers part 1 Herbert Xu
2016-08-18 8:50 ` [PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init Herbert Xu
2016-08-19 16:25 ` Thomas Graf
2016-08-19 16:38 ` Herbert Xu [this message]
2016-08-18 8:50 ` [PATCH 2/3] MAINTAINERS: Add extra rhashtable maintainer Herbert Xu
2016-08-19 16:25 ` Thomas Graf
2016-08-18 8:50 ` [PATCH 3/3] netlink: Use rhashtable walk interface in diag dump Herbert Xu
2016-08-19 8:09 ` Herbert Xu
2016-08-19 8:21 ` [v2 PATCH " Herbert Xu
2016-08-19 16:32 ` Thomas Graf
2016-08-19 16:39 ` Herbert Xu
2016-08-19 16:34 ` [PATCH 0/3] rhashtable: Get rid of raw table walkers part 1 Thomas Graf
2016-08-19 21:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819163835.GA24067@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.