Re: [PATCH v2] staging: esp8089: add new driver

Re: [PATCH v2] staging: esp8089: add new driver

[Greg KH]

On Sun, Jun 19, 2016 at 08:33:48PM +0800, Icenowy Zheng wrote:
> This commit adds Espressif ESP8089 driver, the SDIO version.
> 
> ESP8089 is a 802.11b/g/n card with SDIO/SPI interface. It is usually used in
> low-price tablets with Allwiner or RockChip SoCs.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Why is this driver being sent for the staging tree?  What is wrong with
it that it can't go into the "proper" place in the kernel right now?

And you need a TODO file in your driver's directory before I can take
this as well.

thanks,

greg k-h

Re: [PATCH v2] staging: esp8089: add new driver

[Greg KH]

On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote:
> The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source.
> I cannot promise the code style (although I did indent -kr -i8).
> I cannot also promise the effect.

I don't understand this at all, sorry.

Why should we accept this driver?  Who is going to maintain it?  What
needs to be done to it?

And why are you top-posting?  :)

thanks,

greg k-h

Re: [PATCH v2] staging: esp8089: add new driver

[Greg KH]

On Tue, Jun 21, 2016 at 08:17:14AM -0700, Greg KH wrote:
> On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote:
> > The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source.
> > I cannot promise the code style (although I did indent -kr -i8).
> > I cannot also promise the effect.
> 
> I don't understand this at all, sorry.
> 
> Why should we accept this driver?  Who is going to maintain it?  What
> needs to be done to it?
> 
> And why are you top-posting?  :)

Dropping from my queue due to lack of a response.

If you fix it up, please resend it, but we need the answers to the above
questions if you do so.

thanks,

greg k-h