* [PATCH 1/2] ARM: shmobile: r8a7790: only use smp_init when SMP is selected
@ 2016-08-12 16:45 Wolfram Sang
2016-08-12 16:45 ` [PATCH 2/2] ARM: shmobile: r8a7791: " Wolfram Sang
2016-08-17 7:20 ` [PATCH 1/2] ARM: shmobile: r8a7790: " Simon Horman
0 siblings, 2 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-08-12 16:45 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: Geert Uytterhoeven, Wolfram Sang
We use the helper function which populates the smp_init pointer only in
case of SMP.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/mach-shmobile/setup-r8a7790.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c
index 3506327e0bed24..78d3e859bd64ad 100644
--- a/arch/arm/mach-shmobile/setup-r8a7790.c
+++ b/arch/arm/mach-shmobile/setup-r8a7790.c
@@ -28,7 +28,7 @@ static const char * const r8a7790_boards_compat_dt[] __initconst = {
};
DT_MACHINE_START(R8A7790_DT, "Generic R8A7790 (Flattened Device Tree)")
- .smp_init = shmobile_smp_init_fallback_ops,
+ .smp_init = smp_init_ops(shmobile_smp_init_fallback_ops),
.smp = smp_ops(r8a7790_smp_ops),
.init_early = shmobile_init_delay,
.init_time = rcar_gen2_timer_init,
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7791: only use smp_init when SMP is selected
2016-08-12 16:45 [PATCH 1/2] ARM: shmobile: r8a7790: only use smp_init when SMP is selected Wolfram Sang
@ 2016-08-12 16:45 ` Wolfram Sang
2016-08-17 7:20 ` [PATCH 1/2] ARM: shmobile: r8a7790: " Simon Horman
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-08-12 16:45 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: Geert Uytterhoeven, Wolfram Sang
We use the helper function which populates the smp_init pointer only in
case of SMP.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/mach-shmobile/setup-r8a7791.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/setup-r8a7791.c b/arch/arm/mach-shmobile/setup-r8a7791.c
index 110e8b588e563f..26e2d181a1904d 100644
--- a/arch/arm/mach-shmobile/setup-r8a7791.c
+++ b/arch/arm/mach-shmobile/setup-r8a7791.c
@@ -29,7 +29,7 @@ static const char *const r8a7791_boards_compat_dt[] __initconst = {
};
DT_MACHINE_START(R8A7791_DT, "Generic R8A7791 (Flattened Device Tree)")
- .smp_init = shmobile_smp_init_fallback_ops,
+ .smp_init = smp_init_ops(shmobile_smp_init_fallback_ops),
.smp = smp_ops(r8a7791_smp_ops),
.init_early = shmobile_init_delay,
.init_time = rcar_gen2_timer_init,
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: shmobile: r8a7790: only use smp_init when SMP is selected
2016-08-12 16:45 [PATCH 1/2] ARM: shmobile: r8a7790: only use smp_init when SMP is selected Wolfram Sang
2016-08-12 16:45 ` [PATCH 2/2] ARM: shmobile: r8a7791: " Wolfram Sang
@ 2016-08-17 7:20 ` Simon Horman
2016-08-21 21:10 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2016-08-17 7:20 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-renesas-soc, Geert Uytterhoeven
On Fri, Aug 12, 2016 at 06:45:09PM +0200, Wolfram Sang wrote:
> We use the helper function which populates the smp_init pointer only in
> case of SMP.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Hi Wolfram,
could you describe the motivation for this change in the changelog?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: shmobile: r8a7790: only use smp_init when SMP is selected
2016-08-17 7:20 ` [PATCH 1/2] ARM: shmobile: r8a7790: " Simon Horman
@ 2016-08-21 21:10 ` Wolfram Sang
2016-08-24 7:09 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2016-08-21 21:10 UTC (permalink / raw)
To: Simon Horman; +Cc: Wolfram Sang, linux-renesas-soc, Geert Uytterhoeven
Hi Simon,
> > We use the helper function which populates the smp_init pointer only in
> > case of SMP.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> could you describe the motivation for this change in the changelog?
I am not sure what that could be. For me, it is pretty obvious that we
should not call smp_init() in case of !SMP ?
Regards,
Wolfram
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: shmobile: r8a7790: only use smp_init when SMP is selected
2016-08-21 21:10 ` Wolfram Sang
@ 2016-08-24 7:09 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2016-08-24 7:09 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Wolfram Sang, linux-renesas-soc, Geert Uytterhoeven
On Sun, Aug 21, 2016 at 11:10:26PM +0200, Wolfram Sang wrote:
> Hi Simon,
>
> > > We use the helper function which populates the smp_init pointer only in
> > > case of SMP.
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > could you describe the motivation for this change in the changelog?
>
> I am not sure what that could be. For me, it is pretty obvious that we
> should not call smp_init() in case of !SMP ?
Point taken. I have queued these up.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-24 7:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-12 16:45 [PATCH 1/2] ARM: shmobile: r8a7790: only use smp_init when SMP is selected Wolfram Sang
2016-08-12 16:45 ` [PATCH 2/2] ARM: shmobile: r8a7791: " Wolfram Sang
2016-08-17 7:20 ` [PATCH 1/2] ARM: shmobile: r8a7790: " Simon Horman
2016-08-21 21:10 ` Wolfram Sang
2016-08-24 7:09 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.