* [PATCH net] qed: FLR of active VFs might lead to FW assert
@ 2016-08-22 9:03 Yuval Mintz
2016-08-23 1:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yuval Mintz @ 2016-08-22 9:03 UTC (permalink / raw)
To: davem, netdev; +Cc: Yuval Mintz
Driver never bothered marking the VF's vport with the VF's sw_fid.
As a result, FLR flows are not going to clean those vports.
If the vport was active when FLRed, re-activating it would lead
to a FW assertion.
Fixes: dacd88d6f6851 ("qed: IOV l2 functionality")
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
---
Hi Dave,
Please consider applying this to 'net'.
Thanks,
Yuval
---
drivers/net/ethernet/qlogic/qed/qed.h | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed.h b/drivers/net/ethernet/qlogic/qed/qed.h
index 35e5377..45ab746 100644
--- a/drivers/net/ethernet/qlogic/qed/qed.h
+++ b/drivers/net/ethernet/qlogic/qed/qed.h
@@ -561,9 +561,18 @@ struct qed_dev {
static inline u8 qed_concrete_to_sw_fid(struct qed_dev *cdev,
u32 concrete_fid)
{
+ u8 vfid = GET_FIELD(concrete_fid, PXP_CONCRETE_FID_VFID);
u8 pfid = GET_FIELD(concrete_fid, PXP_CONCRETE_FID_PFID);
+ u8 vf_valid = GET_FIELD(concrete_fid,
+ PXP_CONCRETE_FID_VFVALID);
+ u8 sw_fid;
- return pfid;
+ if (vf_valid)
+ sw_fid = vfid + MAX_NUM_PFS;
+ else
+ sw_fid = pfid;
+
+ return sw_fid;
}
#define PURE_LB_TC 8
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] qed: FLR of active VFs might lead to FW assert
2016-08-22 9:03 [PATCH net] qed: FLR of active VFs might lead to FW assert Yuval Mintz
@ 2016-08-23 1:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-23 1:18 UTC (permalink / raw)
To: Yuval.Mintz; +Cc: netdev
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Mon, 22 Aug 2016 12:03:29 +0300
> Driver never bothered marking the VF's vport with the VF's sw_fid.
> As a result, FLR flows are not going to clean those vports.
>
> If the vport was active when FLRed, re-activating it would lead
> to a FW assertion.
>
> Fixes: dacd88d6f6851 ("qed: IOV l2 functionality")
> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-23 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-22 9:03 [PATCH net] qed: FLR of active VFs might lead to FW assert Yuval Mintz
2016-08-23 1:18 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.