All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS
@ 2016-08-17 21:39 Eric Dumazet
  2016-08-18 21:52 ` Stephen Hemminger
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2016-08-17 21:39 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

From: Eric Dumazet <edumazet@google.com>

kernel support for these attributes was added in linux-4.6

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 ip/ipaddress.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index ab4b1b1..76bd7b3 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -901,6 +901,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
 			fprintf(fp, "numrxqueues %u ",
 				rta_getattr_u32(tb[IFLA_NUM_RX_QUEUES]));
 
+		if (tb[IFLA_GSO_MAX_SIZE])
+			fprintf(fp, "gso_max_size %u ",
+				rta_getattr_u32(tb[IFLA_GSO_MAX_SIZE]));
+
+		if (tb[IFLA_GSO_MAX_SEGS])
+			fprintf(fp, "gso_max_segs %u ",
+				rta_getattr_u32(tb[IFLA_GSO_MAX_SEGS]));
+
 		if (tb[IFLA_PHYS_PORT_NAME])
 			fprintf(fp, "portname %s ",
 				rta_getattr_str(tb[IFLA_PHYS_PORT_NAME]));

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS
  2016-08-17 21:39 [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS Eric Dumazet
@ 2016-08-18 21:52 ` Stephen Hemminger
  2016-08-18 22:14   ` Eric Dumazet
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2016-08-18 21:52 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: netdev

On Wed, 17 Aug 2016 14:39:21 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> From: Eric Dumazet <edumazet@google.com>
> 
> kernel support for these attributes was added in linux-4.6
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>


What about setting them?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS
  2016-08-18 21:52 ` Stephen Hemminger
@ 2016-08-18 22:14   ` Eric Dumazet
  2016-08-22 17:04     ` Stephen Hemminger
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2016-08-18 22:14 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote:
> On Wed, 17 Aug 2016 14:39:21 -0700
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> 
> > From: Eric Dumazet <edumazet@google.com>
> > 
> > kernel support for these attributes was added in linux-4.6
> > 
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> 
> 
> What about setting them?

This is not something the kernel does at this moment.

Drivers usually set a value, depending on hardware or software
constraints.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS
  2016-08-18 22:14   ` Eric Dumazet
@ 2016-08-22 17:04     ` Stephen Hemminger
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2016-08-22 17:04 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: netdev

On Thu, 18 Aug 2016 15:14:38 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote:
> > On Wed, 17 Aug 2016 14:39:21 -0700
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >   
> > > From: Eric Dumazet <edumazet@google.com>
> > > 
> > > kernel support for these attributes was added in linux-4.6
> > > 
> > > Signed-off-by: Eric Dumazet <edumazet@google.com>  
> > 
> > 
> > What about setting them?  
> 
> This is not something the kernel does at this moment.
> 
> Drivers usually set a value, depending on hardware or software
> constraints.
> 
> 
> 

Ok, applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-22 17:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-17 21:39 [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS Eric Dumazet
2016-08-18 21:52 ` Stephen Hemminger
2016-08-18 22:14   ` Eric Dumazet
2016-08-22 17:04     ` Stephen Hemminger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.