* [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings
@ 2016-08-23 15:02 Wei Yongjun
2016-08-23 17:00 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-23 15:02 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman
Cc: Wei Yongjun, devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warnings:
drivers/staging/comedi/drivers/dt2811.c:99:20: warning:
symbol 'dt2811_clk_dividers' was not declared. Should it be static?
drivers/staging/comedi/drivers/dt2811.c:103:20: warning:
symbol 'dt2811_clk_multipliers' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/staging/comedi/drivers/dt2811.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
index 8bbd938..fcd8547 100644
--- a/drivers/staging/comedi/drivers/dt2811.c
+++ b/drivers/staging/comedi/drivers/dt2811.c
@@ -96,11 +96,11 @@
* 6 6 100 kHz 6 1000000
* 7 12 50 kHz 7 10000000
*/
-const unsigned int dt2811_clk_dividers[] = {
+static const unsigned int dt2811_clk_dividers[] = {
1, 10, 2, 3, 4, 5, 6, 12
};
-const unsigned int dt2811_clk_multipliers[] = {
+static const unsigned int dt2811_clk_multipliers[] = {
1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings
2016-08-23 15:02 [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings Wei Yongjun
@ 2016-08-23 17:00 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2016-08-23 17:00 UTC (permalink / raw)
To: Wei Yongjun
Cc: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, devel,
Wei Yongjun, linux-kernel
On Tue, Aug 23, 2016 at 03:02:21PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
<snip>
> drivers/staging/comedi/drivers/dt2811.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
> index 8bbd938..fcd8547 100644
> --- a/drivers/staging/comedi/drivers/dt2811.c
> +++ b/drivers/staging/comedi/drivers/dt2811.c
> @@ -96,11 +96,11 @@
> * 6 6 100 kHz 6 1000000
> * 7 12 50 kHz 7 10000000
> */
> -const unsigned int dt2811_clk_dividers[] = {
> +static const unsigned int dt2811_clk_dividers[] = {
> 1, 10, 2, 3, 4, 5, 6, 12
> };
>
> -const unsigned int dt2811_clk_multipliers[] = {
> +static const unsigned int dt2811_clk_multipliers[] = {
> 1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
> };
This has already been done by:
49c9d6ad68ae ("staging: comedi/drivers: Fixed sparse warnings")
regards
sudip
>
>
>
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-23 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-23 15:02 [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings Wei Yongjun
2016-08-23 17:00 ` Sudip Mukherjee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.