All of lore.kernel.org
 help / color / mirror / Atom feed
* [drm-intel:for-linux-next 1/1] include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine'
@ 2016-08-23 18:22 kbuild test robot
  2016-08-23 19:16 ` Chris Wilson
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-08-23 18:22 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Daniel Vetter, intel-gfx, kbuild-all, dri-devel

[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]

tree:   git://anongit.freedesktop.org/drm-intel for-linux-next
head:   ac96b5566926af83463ddcf4655856033c092f26
commit: ac96b5566926af83463ddcf4655856033c092f26 [1/1] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
config: microblaze-nommu_defconfig (attached as .config)
compiler: microblaze-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ac96b5566926af83463ddcf4655856033c092f26
        # save the attached .config to linux build tree
        make.cross ARCH=microblaze 

All errors (new ones prefixed by >>):

   In file included from drivers/gpio/gpiolib-of.c:19:0:
   include/linux/io-mapping.h: In function 'io_mapping_init_wc':
>> include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine' [-Werror=implicit-function-declaration]
     iomap->prot = pgprot_writecombine(PAGE_KERNEL);
     ^
>> include/linux/io-mapping.h:126:14: error: incompatible types when assigning to type 'pgprot_t' from type 'int'
     iomap->prot = pgprot_writecombine(PAGE_KERNEL);
                 ^
   cc1: some warnings being treated as errors

vim +/pgprot_writecombine +126 include/linux/io-mapping.h

   120			   resource_size_t base,
   121			   unsigned long size)
   122	{
   123		iomap->base = base;
   124		iomap->size = size;
   125		iomap->iomem = ioremap_wc(base, size);
 > 126		iomap->prot = pgprot_writecombine(PAGE_KERNEL);
   127	
   128		return iomap;
   129	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 12151 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [drm-intel:for-linux-next 1/1] include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine'
  2016-08-23 18:22 [drm-intel:for-linux-next 1/1] include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine' kbuild test robot
@ 2016-08-23 19:16 ` Chris Wilson
  2016-08-23 19:26   ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2016-08-23 19:16 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Daniel Vetter, intel-gfx, kbuild-all, dri-devel

On Wed, Aug 24, 2016 at 02:22:29AM +0800, kbuild test robot wrote:
> tree:   git://anongit.freedesktop.org/drm-intel for-linux-next
> head:   ac96b5566926af83463ddcf4655856033c092f26
> commit: ac96b5566926af83463ddcf4655856033c092f26 [1/1] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
> config: microblaze-nommu_defconfig (attached as .config)
> compiler: microblaze-linux-gcc (GCC) 4.9.0
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout ac96b5566926af83463ddcf4655856033c092f26
>         # save the attached .config to linux build tree
>         make.cross ARCH=microblaze 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/gpio/gpiolib-of.c:19:0:
>    include/linux/io-mapping.h: In function 'io_mapping_init_wc':
> >> include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine' [-Werror=implicit-function-declaration]
>      iomap->prot = pgprot_writecombine(PAGE_KERNEL);
>      ^
> >> include/linux/io-mapping.h:126:14: error: incompatible types when assigning to type 'pgprot_t' from type 'int'
>      iomap->prot = pgprot_writecombine(PAGE_KERNEL);
>                  ^
>    cc1: some warnings being treated as errors
> 
> vim +/pgprot_writecombine +126 include/linux/io-mapping.h

Grrr.

diff --git a/include/linux/io-mapping.h b/include/linux/io-mapping.h
index a87dd7fffc0a..babd4c53a5aa 100644
--- a/include/linux/io-mapping.h
+++ b/include/linux/io-mapping.h
@@ -114,6 +114,10 @@ io_mapping_unmap(void __iomem *vaddr)
 #include <linux/uaccess.h>
 #include <asm/pgtable.h>
 
+#ifdef pgprot_noncached_wc
+#define pgprot_writecombine pgprot_noncached_wc
+#endif
+
 /* Create the io_mapping object*/
 static inline struct io_mapping *
 io_mapping_init_wc(struct io_mapping *iomap,

is what I have in mind. Looks like a divide between x86 and ppc (and
their followers).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [drm-intel:for-linux-next 1/1] include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine'
  2016-08-23 19:16 ` Chris Wilson
@ 2016-08-23 19:26   ` Daniel Vetter
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-08-23 19:26 UTC (permalink / raw)
  To: Chris Wilson, kbuild test robot, kbuild-all, intel-gfx,
	dri-devel, Daniel Vetter

On Tue, Aug 23, 2016 at 9:16 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Aug 24, 2016 at 02:22:29AM +0800, kbuild test robot wrote:
>> tree:   git://anongit.freedesktop.org/drm-intel for-linux-next
>> head:   ac96b5566926af83463ddcf4655856033c092f26
>> commit: ac96b5566926af83463ddcf4655856033c092f26 [1/1] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
>> config: microblaze-nommu_defconfig (attached as .config)
>> compiler: microblaze-linux-gcc (GCC) 4.9.0
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         git checkout ac96b5566926af83463ddcf4655856033c092f26
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=microblaze
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from drivers/gpio/gpiolib-of.c:19:0:
>>    include/linux/io-mapping.h: In function 'io_mapping_init_wc':
>> >> include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine' [-Werror=implicit-function-declaration]
>>      iomap->prot = pgprot_writecombine(PAGE_KERNEL);
>>      ^
>> >> include/linux/io-mapping.h:126:14: error: incompatible types when assigning to type 'pgprot_t' from type 'int'
>>      iomap->prot = pgprot_writecombine(PAGE_KERNEL);
>>                  ^
>>    cc1: some warnings being treated as errors
>>
>> vim +/pgprot_writecombine +126 include/linux/io-mapping.h
>
> Grrr.
>
> diff --git a/include/linux/io-mapping.h b/include/linux/io-mapping.h
> index a87dd7fffc0a..babd4c53a5aa 100644
> --- a/include/linux/io-mapping.h
> +++ b/include/linux/io-mapping.h
> @@ -114,6 +114,10 @@ io_mapping_unmap(void __iomem *vaddr)
>  #include <linux/uaccess.h>
>  #include <asm/pgtable.h>
>
> +#ifdef pgprot_noncached_wc
> +#define pgprot_writecombine pgprot_noncached_wc
> +#endif
> +
>  /* Create the io_mapping object*/
>  static inline struct io_mapping *
>  io_mapping_init_wc(struct io_mapping *iomap,
>
> is what I have in mind. Looks like a divide between x86 and ppc (and
> their followers).

tbh I'm leaning towards reverting, since this is getting a bit
embarrassing ;-) Also the io-mapping.h change wasn't reviewed or acked
by arch maintainers (which is probably should have been in hindsight).
And i915_mm.c probably should be somewhere in arch/core code, too.
I'll discuss this a bit more tomorrow with you &Joonas, but since it's
holding up the drm-intel-next pull revert it likely is.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-23 19:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-23 18:22 [drm-intel:for-linux-next 1/1] include/linux/io-mapping.h:126:2: error: implicit declaration of function 'pgprot_writecombine' kbuild test robot
2016-08-23 19:16 ` Chris Wilson
2016-08-23 19:26   ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.