[PATCH] drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell

[PATCH] drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell

[Chris Wilson]

The D_COMP (render decompression) register write is followed by a status
check and another error (either that the decompression shutdown or the
lpll is enabled). Since we are followed by another, more pertinent,
error we can reduce the pcode timeout to a debug and squelch a sporadic
error message during suspend.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97465
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b3ea141c0ce8..eb4c989e98a3 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9973,7 +9973,7 @@ static void hsw_write_dcomp(struct drm_i915_private *dev_priv, uint32_t val)
 		mutex_lock(&dev_priv->rps.hw_lock);
 		if (sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_D_COMP,
 					    val))
-			DRM_ERROR("Failed to write to D_COMP\n");
+			DRM_DEBUG_KMS("Failed to write to D_COMP\n");
 		mutex_unlock(&dev_priv->rps.hw_lock);
 	} else {
 		I915_WRITE(D_COMP_BDW, val);
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell

[Matthew Auld]

On 24 August 2016 at 11:16, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The D_COMP (render decompression) register write is followed by a status
> check and another error (either that the decompression shutdown or the
> lpll is enabled). Since we are followed by another, more pertinent,
> error we can reduce the pcode timeout to a debug and squelch a sporadic
> error message during suspend.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97465
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell

[Patchwork]

== Series Details ==

Series: drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell
URL   : https://patchwork.freedesktop.org/series/11516/
State : failure

== Summary ==

Series 11516v1 drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell
http://patchwork.freedesktop.org/api/1.0/series/11516/revisions/1/mbox/

Test gem_exec_gttfill:
        Subgroup basic:
                pass       -> SKIP       (fi-snb-2600)
Test gem_exec_suspend:
        Subgroup basic-s3:
                dmesg-warn -> PASS       (fi-hsw-4770k)
Test kms_cursor_legacy:
        Subgroup basic-flip-vs-cursor-legacy:
                pass       -> FAIL       (fi-skl-6700k)
                fail       -> PASS       (fi-hsw-4770k)
                pass       -> FAIL       (fi-bdw-5557u)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-b:
                skip       -> PASS       (fi-hsw-4770r)
        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-hsw-4770k)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-hsw-4770k)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> PASS       (fi-hsw-4770k)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                dmesg-warn -> PASS       (fi-hsw-4770k)
        Subgroup basic-rte:
                dmesg-warn -> PASS       (fi-hsw-4770k)
Test prime_vgem:
        Subgroup basic-fence-flip:
                dmesg-fail -> FAIL       (fi-hsw-4770k)

fi-bdw-5557u     total:252  pass:234  dwarn:0   dfail:0   fail:3   skip:15 
fi-bsw-n3050     total:252  pass:203  dwarn:0   dfail:0   fail:3   skip:46 
fi-byt-n2820     total:252  pass:205  dwarn:0   dfail:0   fail:5   skip:42 
fi-hsw-4770k     total:252  pass:228  dwarn:0   dfail:0   fail:2   skip:22 
fi-hsw-4770r     total:252  pass:224  dwarn:0   dfail:0   fail:2   skip:26 
fi-ivb-3520m     total:252  pass:220  dwarn:0   dfail:0   fail:1   skip:31 
fi-skl-6260u     total:252  pass:236  dwarn:0   dfail:0   fail:2   skip:14 
fi-skl-6700k     total:252  pass:216  dwarn:4   dfail:0   fail:4   skip:28 
fi-snb-2520m     total:252  pass:203  dwarn:4   dfail:0   fail:2   skip:43 
fi-snb-2600      total:252  pass:202  dwarn:4   dfail:0   fail:2   skip:44 

Results at /archive/results/CI_IGT_test/Patchwork_2421/

03cfce0f8cf8f0664667f5f9b50560eeab16de37 drm-intel-nightly: 2016y-08m-24d-12h-19m-49s UTC integration manifest
cd93864 drm/i915: Suppress DRM_ERROR for D_COMP write on Haswell

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx