* [PATCH] [media] m2m-deinterlace: Fix error print during probe
@ 2016-08-23 13:39 Peter Ujfalusi
2016-08-24 10:21 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2016-08-23 13:39 UTC (permalink / raw)
To: mchehab
Cc: hans.verkuil, nenggun.kim, jh1009.sung, sw0312.kim, linux-media,
linux-kernel
v4l2_err() can not be used for printing error for missing interleaved
support in DMA as this point the pcdev->v4l2_dev is not valid.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/media/platform/m2m-deinterlace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c
index 0fcb5c78031d..5a5dec348f4d 100644
--- a/drivers/media/platform/m2m-deinterlace.c
+++ b/drivers/media/platform/m2m-deinterlace.c
@@ -1016,7 +1016,7 @@ static int deinterlace_probe(struct platform_device *pdev)
return -ENODEV;
if (!dma_has_cap(DMA_INTERLEAVE, pcdev->dma_chan->device->cap_mask)) {
- v4l2_err(&pcdev->v4l2_dev, "DMA does not support INTERLEAVE\n");
+ dev_err(&pdev->dev, "DMA does not support INTERLEAVE\n");
goto rel_dma;
}
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] m2m-deinterlace: Fix error print during probe
2016-08-23 13:39 [PATCH] [media] m2m-deinterlace: Fix error print during probe Peter Ujfalusi
@ 2016-08-24 10:21 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2016-08-24 10:21 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: mchehab, hans.verkuil, nenggun.kim, jh1009.sung, sw0312.kim,
linux-media, linux-kernel
Hi, Peter!
On Tue, Aug 23, 2016 at 04:39:39PM +0300, Peter Ujfalusi wrote:
> v4l2_err() can not be used for printing error for missing interleaved
> support in DMA as this point the pcdev->v4l2_dev is not valid.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/media/platform/m2m-deinterlace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c
> index 0fcb5c78031d..5a5dec348f4d 100644
> --- a/drivers/media/platform/m2m-deinterlace.c
> +++ b/drivers/media/platform/m2m-deinterlace.c
> @@ -1016,7 +1016,7 @@ static int deinterlace_probe(struct platform_device *pdev)
> return -ENODEV;
>
> if (!dma_has_cap(DMA_INTERLEAVE, pcdev->dma_chan->device->cap_mask)) {
> - v4l2_err(&pcdev->v4l2_dev, "DMA does not support INTERLEAVE\n");
> + dev_err(&pdev->dev, "DMA does not support INTERLEAVE\n");
> goto rel_dma;
> }
>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-24 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-23 13:39 [PATCH] [media] m2m-deinterlace: Fix error print during probe Peter Ujfalusi
2016-08-24 10:21 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.