All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] f2fs: invalidate inode and data pages if inode is no longer used
Date: Wed, 24 Aug 2016 19:34:19 -0700	[thread overview]
Message-ID: <20160825023419.82566-1-jaegeuk@kernel.org> (raw)

When a file is closed, let's deactivate inode page to mitigate further memory
pressure. We can do data pages as well in the corner case of f2fs_drop_inode.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/file.c  | 4 ++++
 fs/f2fs/super.c | 1 +
 2 files changed, 5 insertions(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index e460211..5f9a6dc 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1465,6 +1465,10 @@ static int f2fs_release_file(struct inode *inode, struct file *filp)
 		filemap_fdatawrite(inode->i_mapping);
 		clear_inode_flag(inode, FI_DROP_CACHE);
 	}
+
+	/* deactivate written inode page */
+	invalidate_mapping_pages(NODE_MAPPING(F2FS_I_SB(inode)),
+					inode->i_ino, inode->i_ino);
 	return 0;
 }
 
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 7f863a6..f84696d 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -618,6 +618,7 @@ static int f2fs_drop_inode(struct inode *inode)
 			sb_end_intwrite(inode->i_sb);
 
 			fscrypt_put_encryption_info(inode, NULL);
+			invalidate_mapping_pages(inode->i_mapping, 0, -1);
 			spin_lock(&inode->i_lock);
 			atomic_dec(&inode->i_count);
 		}
-- 
2.8.3

WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] f2fs: invalidate inode and data pages if inode is no longer used
Date: Wed, 24 Aug 2016 19:34:19 -0700	[thread overview]
Message-ID: <20160825023419.82566-1-jaegeuk@kernel.org> (raw)

When a file is closed, let's deactivate inode page to mitigate further memory
pressure. We can do data pages as well in the corner case of f2fs_drop_inode.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/file.c  | 4 ++++
 fs/f2fs/super.c | 1 +
 2 files changed, 5 insertions(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index e460211..5f9a6dc 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1465,6 +1465,10 @@ static int f2fs_release_file(struct inode *inode, struct file *filp)
 		filemap_fdatawrite(inode->i_mapping);
 		clear_inode_flag(inode, FI_DROP_CACHE);
 	}
+
+	/* deactivate written inode page */
+	invalidate_mapping_pages(NODE_MAPPING(F2FS_I_SB(inode)),
+					inode->i_ino, inode->i_ino);
 	return 0;
 }
 
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 7f863a6..f84696d 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -618,6 +618,7 @@ static int f2fs_drop_inode(struct inode *inode)
 			sb_end_intwrite(inode->i_sb);
 
 			fscrypt_put_encryption_info(inode, NULL);
+			invalidate_mapping_pages(inode->i_mapping, 0, -1);
 			spin_lock(&inode->i_lock);
 			atomic_dec(&inode->i_count);
 		}
-- 
2.8.3


------------------------------------------------------------------------------

             reply	other threads:[~2016-08-25  6:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  2:34 Jaegeuk Kim [this message]
2016-08-25  2:34 ` [PATCH] f2fs: invalidate inode and data pages if inode is no longer used Jaegeuk Kim
2016-08-25 11:59 ` Chao Yu
2016-08-25 17:00   ` Jaegeuk Kim
2016-08-25 17:04     ` Jaegeuk Kim
2016-08-26  1:14       ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160825023419.82566-1-jaegeuk@kernel.org \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.