All of lore.kernel.org
 help / color / mirror / Atom feed
* [REPOST PATCH] ia64: salinfo: drop the CPU_DEAD event
@ 2016-08-25  8:35 Sebastian Andrzej Siewior
  0 siblings, 0 replies; only message in thread
From: Sebastian Andrzej Siewior @ 2016-08-25  8:35 UTC (permalink / raw)
  To: linux-ia64

The CPU_DEAD event drops all events for the CPU that goes offline which
were recorded earlier. I don't think that this makes sense because the
"problem" that was recorded is not resovled just because the CPU went
offline.
I *think* it makes sense to keep that event for later once userland is
able to fetch it.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 arch/ia64/kernel/salinfo.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/arch/ia64/kernel/salinfo.c b/arch/ia64/kernel/salinfo.c
index 5313007d5423..d4f5168bdc6c 100644
--- a/arch/ia64/kernel/salinfo.c
+++ b/arch/ia64/kernel/salinfo.c
@@ -568,25 +568,6 @@ salinfo_cpu_callback(struct notifier_block *nb, unsigned long action, void *hcpu
 		}
 		spin_unlock_irqrestore(&data_saved_lock, flags);
 		break;
-	case CPU_DEAD:
-	case CPU_DEAD_FROZEN:
-		spin_lock_irqsave(&data_saved_lock, flags);
-		for (i = 0, data = salinfo_data;
-		     i < ARRAY_SIZE(salinfo_data);
-		     ++i, ++data) {
-			struct salinfo_data_saved *data_saved;
-			int j;
-			for (j = ARRAY_SIZE(data->data_saved) - 1, data_saved = data->data_saved + j;
-			     j >= 0;
-			     --j, --data_saved) {
-				if (data_saved->buffer && data_saved->cpu = cpu) {
-					shift1_data_saved(data, j);
-				}
-			}
-			cpumask_clear_cpu(cpu, &data->cpu_event);
-		}
-		spin_unlock_irqrestore(&data_saved_lock, flags);
-		break;
 	}
 	return NOTIFY_OK;
 }
-- 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-25  8:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25  8:35 [REPOST PATCH] ia64: salinfo: drop the CPU_DEAD event Sebastian Andrzej Siewior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.