* [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init.
@ 2016-08-25 21:22 Steven J. Hill
[not found] ` <422712ab-4b0d-2b6d-4600-b917c2d327a9-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Steven J. Hill @ 2016-08-25 21:22 UTC (permalink / raw)
To: linux-mips, ralf; +Cc: David Daney, Rob Herring, devicetree
We clear the OF_POPULATED flag for the GPIO controller node, otherwise
the GPIO lines used by the MMC driver are never probed.
Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com>
---
arch/mips/cavium-octeon/octeon-irq.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
index 5a9b87b..41d12d4 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -1619,6 +1619,13 @@ static int __init octeon_irq_init_gpio(
return -ENOMEM;
}
+ /*
+ * Clear the OF_POPULATED flag that was set above for the
+ * GPIO controller so that the lines used by the MMC driver
+ * will not be skipped.
+ */
+ of_node_clear_flag(gpio_node, OF_POPULATED);
+
return 0;
}
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <422712ab-4b0d-2b6d-4600-b917c2d327a9-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init. 2016-08-25 21:22 [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init Steven J. Hill [not found] ` <422712ab-4b0d-2b6d-4600-b917c2d327a9-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> @ 2016-08-25 22:20 ` David Daney 0 siblings, 0 replies; 6+ messages in thread From: David Daney @ 2016-08-25 22:20 UTC (permalink / raw) To: Steven J. Hill, Rob Herring, Jon Hunter Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, ralf-6z/3iImG2C8G8FEW9MqTrA, David Daney, devicetree-u79uwXL29TY76Z2rM5mHXA On 08/25/2016 02:22 PM, Steven J. Hill wrote: > We clear the OF_POPULATED flag for the GPIO controller node, otherwise > the GPIO lines used by the MMC driver are never probed. > > Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated") > Signed-off-by: Steven J. Hill <Steven.Hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > --- > arch/mips/cavium-octeon/octeon-irq.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c > index 5a9b87b..41d12d4 100644 > --- a/arch/mips/cavium-octeon/octeon-irq.c > +++ b/arch/mips/cavium-octeon/octeon-irq.c > @@ -1619,6 +1619,13 @@ static int __init octeon_irq_init_gpio( > return -ENOMEM; > } > > + /* > + * Clear the OF_POPULATED flag that was set above for the Can we s/above/in of_irq_init()/ to be less ambiguous? > + * GPIO controller so that the lines used by the MMC driver I suspect that it is not just MMC that was broken by commit 15cc2ed6dcf9. Can we get a real description of exactly which kernel facilities are impacted? Is it all GPIO, or what? > + * will not be skipped. > + */ > + of_node_clear_flag(gpio_node, OF_POPULATED); > + > return 0; > } > /* > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init. @ 2016-08-25 22:20 ` David Daney 0 siblings, 0 replies; 6+ messages in thread From: David Daney @ 2016-08-25 22:20 UTC (permalink / raw) To: Steven J. Hill, Rob Herring, Jon Hunter Cc: linux-mips, ralf, David Daney, devicetree On 08/25/2016 02:22 PM, Steven J. Hill wrote: > We clear the OF_POPULATED flag for the GPIO controller node, otherwise > the GPIO lines used by the MMC driver are never probed. > > Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated") > Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com> > --- > arch/mips/cavium-octeon/octeon-irq.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c > index 5a9b87b..41d12d4 100644 > --- a/arch/mips/cavium-octeon/octeon-irq.c > +++ b/arch/mips/cavium-octeon/octeon-irq.c > @@ -1619,6 +1619,13 @@ static int __init octeon_irq_init_gpio( > return -ENOMEM; > } > > + /* > + * Clear the OF_POPULATED flag that was set above for the Can we s/above/in of_irq_init()/ to be less ambiguous? > + * GPIO controller so that the lines used by the MMC driver I suspect that it is not just MMC that was broken by commit 15cc2ed6dcf9. Can we get a real description of exactly which kernel facilities are impacted? Is it all GPIO, or what? > + * will not be skipped. > + */ > + of_node_clear_flag(gpio_node, OF_POPULATED); > + > return 0; > } > /* > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init. @ 2016-08-25 22:20 ` David Daney 0 siblings, 0 replies; 6+ messages in thread From: David Daney @ 2016-08-25 22:20 UTC (permalink / raw) To: Steven J. Hill, Rob Herring, Jon Hunter Cc: linux-mips, ralf, David Daney, devicetree On 08/25/2016 02:22 PM, Steven J. Hill wrote: > We clear the OF_POPULATED flag for the GPIO controller node, otherwise > the GPIO lines used by the MMC driver are never probed. > > Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated") > Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com> > --- > arch/mips/cavium-octeon/octeon-irq.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c > index 5a9b87b..41d12d4 100644 > --- a/arch/mips/cavium-octeon/octeon-irq.c > +++ b/arch/mips/cavium-octeon/octeon-irq.c > @@ -1619,6 +1619,13 @@ static int __init octeon_irq_init_gpio( > return -ENOMEM; > } > > + /* > + * Clear the OF_POPULATED flag that was set above for the Can we s/above/in of_irq_init()/ to be less ambiguous? > + * GPIO controller so that the lines used by the MMC driver I suspect that it is not just MMC that was broken by commit 15cc2ed6dcf9. Can we get a real description of exactly which kernel facilities are impacted? Is it all GPIO, or what? > + * will not be skipped. > + */ > + of_node_clear_flag(gpio_node, OF_POPULATED); > + > return 0; > } > /* > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <57BF6F47.4030803-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init. 2016-08-25 22:20 ` David Daney @ 2016-08-25 22:40 ` Aaro Koskinen -1 siblings, 0 replies; 6+ messages in thread From: Aaro Koskinen @ 2016-08-25 22:40 UTC (permalink / raw) To: David Daney Cc: Steven J. Hill, Rob Herring, Jon Hunter, linux-mips-6z/3iImG2C8G8FEW9MqTrA, ralf-6z/3iImG2C8G8FEW9MqTrA, David Daney, devicetree-u79uwXL29TY76Z2rM5mHXA Hi, On Thu, Aug 25, 2016 at 03:20:55PM -0700, David Daney wrote: > On 08/25/2016 02:22 PM, Steven J. Hill wrote: > >We clear the OF_POPULATED flag for the GPIO controller node, otherwise > >the GPIO lines used by the MMC driver are never probed. Please also mention that gpio-leds failed to probe. > >Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated") > >Signed-off-by: Steven J. Hill <Steven.Hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> > >--- > > arch/mips/cavium-octeon/octeon-irq.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > >diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c > >index 5a9b87b..41d12d4 100644 > >--- a/arch/mips/cavium-octeon/octeon-irq.c > >+++ b/arch/mips/cavium-octeon/octeon-irq.c > >@@ -1619,6 +1619,13 @@ static int __init octeon_irq_init_gpio( > > return -ENOMEM; > > } > > > >+ /* > >+ * Clear the OF_POPULATED flag that was set above for the > > Can we s/above/in of_irq_init()/ to be less ambiguous? > > >+ * GPIO controller so that the lines used by the MMC driver > > I suspect that it is not just MMC that was broken by commit 15cc2ed6dcf9. > Can we get a real description of exactly which kernel facilities are > impacted? Is it all GPIO, or what? For me it fixes gpio-leds breakage, so I think it's all GPIO. Referring to MMC driver is not appropriate anyway as the OCTEON MMC is not yet merged. :-) > >+ * will not be skipped. > >+ */ > >+ of_node_clear_flag(gpio_node, OF_POPULATED); > >+ > > return 0; For this actual code change, you can add: Tested-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org> Thanks, A. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init. @ 2016-08-25 22:40 ` Aaro Koskinen 0 siblings, 0 replies; 6+ messages in thread From: Aaro Koskinen @ 2016-08-25 22:40 UTC (permalink / raw) To: David Daney Cc: Steven J. Hill, Rob Herring, Jon Hunter, linux-mips, ralf, David Daney, devicetree Hi, On Thu, Aug 25, 2016 at 03:20:55PM -0700, David Daney wrote: > On 08/25/2016 02:22 PM, Steven J. Hill wrote: > >We clear the OF_POPULATED flag for the GPIO controller node, otherwise > >the GPIO lines used by the MMC driver are never probed. Please also mention that gpio-leds failed to probe. > >Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated") > >Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com> > >--- > > arch/mips/cavium-octeon/octeon-irq.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > >diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c > >index 5a9b87b..41d12d4 100644 > >--- a/arch/mips/cavium-octeon/octeon-irq.c > >+++ b/arch/mips/cavium-octeon/octeon-irq.c > >@@ -1619,6 +1619,13 @@ static int __init octeon_irq_init_gpio( > > return -ENOMEM; > > } > > > >+ /* > >+ * Clear the OF_POPULATED flag that was set above for the > > Can we s/above/in of_irq_init()/ to be less ambiguous? > > >+ * GPIO controller so that the lines used by the MMC driver > > I suspect that it is not just MMC that was broken by commit 15cc2ed6dcf9. > Can we get a real description of exactly which kernel facilities are > impacted? Is it all GPIO, or what? For me it fixes gpio-leds breakage, so I think it's all GPIO. Referring to MMC driver is not appropriate anyway as the OCTEON MMC is not yet merged. :-) > >+ * will not be skipped. > >+ */ > >+ of_node_clear_flag(gpio_node, OF_POPULATED); > >+ > > return 0; For this actual code change, you can add: Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi> Thanks, A. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-25 22:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25 21:22 [PATCH] MIPS: Octeon: mark GPIO controller node not populated IRQ, init Steven J. Hill
[not found] ` <422712ab-4b0d-2b6d-4600-b917c2d327a9-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-08-25 22:20 ` David Daney
2016-08-25 22:20 ` David Daney
2016-08-25 22:20 ` David Daney
[not found] ` <57BF6F47.4030803-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-08-25 22:40 ` Aaro Koskinen
2016-08-25 22:40 ` Aaro Koskinen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.