* [PATCH] drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
@ 2016-08-26 10:59 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2016-08-26 10:59 UTC (permalink / raw)
To: intel-gfx
Cc: Chris Wilson, Lyude, Matt Roper, Maarten Lankhorst,
Daniel Vetter, Ville Syrjälä,
stable
According to the CI test machines, SNB also uses the
GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE value to report a bad
GEN6_PCODE_MIN_FREQ_TABLE request.
[ 157.744641] WARNING: CPU: 5 PID: 9238 at
drivers/gpu/drm/i915/intel_pm.c:7760 sandybridge_pcode_write+0x141/0x200 [i915]
[ 157.744642] Missing switch case (16) in gen6_check_mailbox_status
[ 157.744642] Modules linked in: snd_hda_intel i915 ax88179_178a usbnet mii x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hwdep snd_hda_core mei_me lpc_ich snd_pcm mei broadcom bcm_phy_lib tg3 ptp pps_core [last unloaded: vgem]
[ 157.744658] CPU: 5 PID: 9238 Comm: drv_hangman Tainted: G U W 4.8.0-rc3-CI-CI_DRM_1589+ #1
[ 157.744658] Hardware name: Dell Inc. XPS 8300 /0Y2MRG, BIOS A06 10/17/2011
[ 157.744659] 0000000000000000 ffff88011f093a98 ffffffff81426415 ffff88011f093ae8
[ 157.744662] 0000000000000000 ffff88011f093ad8 ffffffff8107d2a6 00001e50810d3c9f
[ 157.744663] ffff880128680000 0000000000000008 0000000000000000 ffff88012868a650
[ 157.744665] Call Trace:
[ 157.744669] [<ffffffff81426415>] dump_stack+0x67/0x92
[ 157.744672] [<ffffffff8107d2a6>] __warn+0xc6/0xe0
[ 157.744673] [<ffffffff8107d30a>] warn_slowpath_fmt+0x4a/0x50
[ 157.744685] [<ffffffffa0029831>] sandybridge_pcode_write+0x141/0x200 [i915]
[ 157.744697] [<ffffffffa002a88a>] intel_enable_gt_powersave+0x64a/0x1330 [i915]
[ 157.744712] [<ffffffffa006b4cb>] ? i9xx_emit_request+0x1b/0x80 [i915]
[ 157.744725] [<ffffffffa0055ed3>] __i915_add_request+0x1e3/0x370 [i915]
[ 157.744738] [<ffffffffa00428bd>] i915_gem_do_execbuffer.isra.16+0xced/0x1b80 [i915]
[ 157.744740] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
[ 157.744752] [<ffffffffa0043b72>] i915_gem_execbuffer2+0xc2/0x2a0 [i915]
[ 157.744753] [<ffffffff815485b7>] drm_ioctl+0x207/0x4c0
[ 157.744765] [<ffffffffa0043ab0>] ? i915_gem_execbuffer+0x360/0x360 [i915]
[ 157.744767] [<ffffffff810ea4ad>] ? debug_lockdep_rcu_enabled+0x1d/0x20
[ 157.744769] [<ffffffff811fe09e>] do_vfs_ioctl+0x8e/0x680
[ 157.744770] [<ffffffff811a2377>] ? __might_fault+0x87/0x90
[ 157.744771] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
[ 157.744773] [<ffffffff810d3df2>] ? trace_hardirqs_on_caller+0x122/0x1b0
[ 157.744774] [<ffffffff811fe6cc>] SyS_ioctl+0x3c/0x70
[ 157.744776] [<ffffffff8180fe69>] entry_SYSCALL_64_fastpath+0x1c/0xac
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97491
Fixes: 87660502f1a4 ("drm/i915/gen6+: Interpret mailbox error flags")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lyude <cpaul@redhat.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/intel_pm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 729d952174d8..aba6fd036c4e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7753,6 +7753,7 @@ static inline int gen6_check_mailbox_status(struct drm_i915_private *dev_priv)
case GEN6_PCODE_ILLEGAL_CMD:
return -ENXIO;
case GEN6_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
+ case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
return -EOVERFLOW;
case GEN6_PCODE_TIMEOUT:
return -ETIMEDOUT;
--
2.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
@ 2016-08-26 10:59 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2016-08-26 10:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, stable
According to the CI test machines, SNB also uses the
GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE value to report a bad
GEN6_PCODE_MIN_FREQ_TABLE request.
[ 157.744641] WARNING: CPU: 5 PID: 9238 at
drivers/gpu/drm/i915/intel_pm.c:7760 sandybridge_pcode_write+0x141/0x200 [i915]
[ 157.744642] Missing switch case (16) in gen6_check_mailbox_status
[ 157.744642] Modules linked in: snd_hda_intel i915 ax88179_178a usbnet mii x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hwdep snd_hda_core mei_me lpc_ich snd_pcm mei broadcom bcm_phy_lib tg3 ptp pps_core [last unloaded: vgem]
[ 157.744658] CPU: 5 PID: 9238 Comm: drv_hangman Tainted: G U W 4.8.0-rc3-CI-CI_DRM_1589+ #1
[ 157.744658] Hardware name: Dell Inc. XPS 8300 /0Y2MRG, BIOS A06 10/17/2011
[ 157.744659] 0000000000000000 ffff88011f093a98 ffffffff81426415 ffff88011f093ae8
[ 157.744662] 0000000000000000 ffff88011f093ad8 ffffffff8107d2a6 00001e50810d3c9f
[ 157.744663] ffff880128680000 0000000000000008 0000000000000000 ffff88012868a650
[ 157.744665] Call Trace:
[ 157.744669] [<ffffffff81426415>] dump_stack+0x67/0x92
[ 157.744672] [<ffffffff8107d2a6>] __warn+0xc6/0xe0
[ 157.744673] [<ffffffff8107d30a>] warn_slowpath_fmt+0x4a/0x50
[ 157.744685] [<ffffffffa0029831>] sandybridge_pcode_write+0x141/0x200 [i915]
[ 157.744697] [<ffffffffa002a88a>] intel_enable_gt_powersave+0x64a/0x1330 [i915]
[ 157.744712] [<ffffffffa006b4cb>] ? i9xx_emit_request+0x1b/0x80 [i915]
[ 157.744725] [<ffffffffa0055ed3>] __i915_add_request+0x1e3/0x370 [i915]
[ 157.744738] [<ffffffffa00428bd>] i915_gem_do_execbuffer.isra.16+0xced/0x1b80 [i915]
[ 157.744740] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
[ 157.744752] [<ffffffffa0043b72>] i915_gem_execbuffer2+0xc2/0x2a0 [i915]
[ 157.744753] [<ffffffff815485b7>] drm_ioctl+0x207/0x4c0
[ 157.744765] [<ffffffffa0043ab0>] ? i915_gem_execbuffer+0x360/0x360 [i915]
[ 157.744767] [<ffffffff810ea4ad>] ? debug_lockdep_rcu_enabled+0x1d/0x20
[ 157.744769] [<ffffffff811fe09e>] do_vfs_ioctl+0x8e/0x680
[ 157.744770] [<ffffffff811a2377>] ? __might_fault+0x87/0x90
[ 157.744771] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
[ 157.744773] [<ffffffff810d3df2>] ? trace_hardirqs_on_caller+0x122/0x1b0
[ 157.744774] [<ffffffff811fe6cc>] SyS_ioctl+0x3c/0x70
[ 157.744776] [<ffffffff8180fe69>] entry_SYSCALL_64_fastpath+0x1c/0xac
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97491
Fixes: 87660502f1a4 ("drm/i915/gen6+: Interpret mailbox error flags")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lyude <cpaul@redhat.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/intel_pm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 729d952174d8..aba6fd036c4e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7753,6 +7753,7 @@ static inline int gen6_check_mailbox_status(struct drm_i915_private *dev_priv)
case GEN6_PCODE_ILLEGAL_CMD:
return -ENXIO;
case GEN6_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
+ case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
return -EOVERFLOW;
case GEN6_PCODE_TIMEOUT:
return -ETIMEDOUT;
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
2016-08-26 10:59 ` Chris Wilson
(?)
@ 2016-08-26 11:19 ` Patchwork
2016-08-26 17:11 ` Chris Wilson
-1 siblings, 1 reply; 8+ messages in thread
From: Patchwork @ 2016-08-26 11:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
URL : https://patchwork.freedesktop.org/series/11607/
State : success
== Summary ==
Series 11607v1 drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
http://patchwork.freedesktop.org/api/1.0/series/11607/revisions/1/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
Test gem_basic:
Subgroup bad-close:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
Test gem_ringfill:
Subgroup basic-default-hang:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
Test kms_force_connector_basic:
Subgroup force-connector-state:
skip -> PASS (fi-snb-2520m)
Subgroup force-edid:
skip -> PASS (fi-snb-2520m)
Subgroup prune-stale-modes:
skip -> PASS (fi-snb-2520m)
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
Subgroup hang-read-crc-pipe-b:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-snb-2600)
dmesg-warn -> PASS (fi-snb-2520m)
fi-bdw-5557u total:252 pass:235 dwarn:0 dfail:0 fail:2 skip:15
fi-bsw-n3050 total:252 pass:205 dwarn:0 dfail:0 fail:1 skip:46
fi-byt-n2820 total:252 pass:207 dwarn:0 dfail:0 fail:3 skip:42
fi-hsw-4770k total:252 pass:228 dwarn:0 dfail:0 fail:2 skip:22
fi-hsw-4770r total:252 pass:224 dwarn:0 dfail:0 fail:2 skip:26
fi-ivb-3520m total:252 pass:220 dwarn:0 dfail:0 fail:1 skip:31
fi-skl-6260u total:252 pass:236 dwarn:0 dfail:0 fail:2 skip:14
fi-skl-6700k total:252 pass:222 dwarn:0 dfail:0 fail:2 skip:28
fi-snb-2520m total:252 pass:207 dwarn:0 dfail:0 fail:2 skip:43
fi-snb-2600 total:252 pass:207 dwarn:0 dfail:0 fail:2 skip:43
Results at /archive/results/CI_IGT_test/Patchwork_2434/
c9b227d6fdd8714e4fb3ea1d7dd5342ba9c957b1 drm-intel-nightly: 2016y-08m-26d-07h-56m-20s UTC integration manifest
77c8b35 drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
2016-08-26 11:19 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2016-08-26 17:11 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2016-08-26 17:11 UTC (permalink / raw)
To: intel-gfx
On Fri, Aug 26, 2016 at 11:19:56AM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
> URL : https://patchwork.freedesktop.org/series/11607/
> State : success
>
> == Summary ==
>
> Series 11607v1 drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
> http://patchwork.freedesktop.org/api/1.0/series/11607/revisions/1/mbox/
>
> Test drv_module_reload_basic:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
> Test gem_basic:
> Subgroup bad-close:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
> Test gem_exec_suspend:
> Subgroup basic-s3:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
> Test gem_ringfill:
> Subgroup basic-default-hang:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
> Test kms_force_connector_basic:
> Subgroup force-connector-state:
> skip -> PASS (fi-snb-2520m)
> Subgroup force-edid:
> skip -> PASS (fi-snb-2520m)
> Subgroup prune-stale-modes:
> skip -> PASS (fi-snb-2520m)
> Test kms_pipe_crc_basic:
> Subgroup hang-read-crc-pipe-a:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
> Subgroup hang-read-crc-pipe-b:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
> Subgroup suspend-read-crc-pipe-a:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
> Subgroup suspend-read-crc-pipe-b:
> dmesg-warn -> PASS (fi-snb-2600)
> dmesg-warn -> PASS (fi-snb-2520m)
irc acked by Mika. There should be no lasting damage as we mostly ignore
the error code anyway, especially this one...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
2016-08-26 10:59 ` Chris Wilson
@ 2016-08-29 7:33 ` Maarten Lankhorst
-1 siblings, 0 replies; 8+ messages in thread
From: Maarten Lankhorst @ 2016-08-29 7:33 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Cc: Lyude, Matt Roper, Daniel Vetter, Ville Syrjälä, stable
Op 26-08-16 om 12:59 schreef Chris Wilson:
> According to the CI test machines, SNB also uses the
> GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE value to report a bad
> GEN6_PCODE_MIN_FREQ_TABLE request.
>
> [ 157.744641] WARNING: CPU: 5 PID: 9238 at
> drivers/gpu/drm/i915/intel_pm.c:7760 sandybridge_pcode_write+0x141/0x200 [i915]
> [ 157.744642] Missing switch case (16) in gen6_check_mailbox_status
> [ 157.744642] Modules linked in: snd_hda_intel i915 ax88179_178a usbnet mii x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hwdep snd_hda_core mei_me lpc_ich snd_pcm mei broadcom bcm_phy_lib tg3 ptp pps_core [last unloaded: vgem]
> [ 157.744658] CPU: 5 PID: 9238 Comm: drv_hangman Tainted: G U W 4.8.0-rc3-CI-CI_DRM_1589+ #1
> [ 157.744658] Hardware name: Dell Inc. XPS 8300 /0Y2MRG, BIOS A06 10/17/2011
> [ 157.744659] 0000000000000000 ffff88011f093a98 ffffffff81426415 ffff88011f093ae8
> [ 157.744662] 0000000000000000 ffff88011f093ad8 ffffffff8107d2a6 00001e50810d3c9f
> [ 157.744663] ffff880128680000 0000000000000008 0000000000000000 ffff88012868a650
> [ 157.744665] Call Trace:
> [ 157.744669] [<ffffffff81426415>] dump_stack+0x67/0x92
> [ 157.744672] [<ffffffff8107d2a6>] __warn+0xc6/0xe0
> [ 157.744673] [<ffffffff8107d30a>] warn_slowpath_fmt+0x4a/0x50
> [ 157.744685] [<ffffffffa0029831>] sandybridge_pcode_write+0x141/0x200 [i915]
> [ 157.744697] [<ffffffffa002a88a>] intel_enable_gt_powersave+0x64a/0x1330 [i915]
> [ 157.744712] [<ffffffffa006b4cb>] ? i9xx_emit_request+0x1b/0x80 [i915]
> [ 157.744725] [<ffffffffa0055ed3>] __i915_add_request+0x1e3/0x370 [i915]
> [ 157.744738] [<ffffffffa00428bd>] i915_gem_do_execbuffer.isra.16+0xced/0x1b80 [i915]
> [ 157.744740] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> [ 157.744752] [<ffffffffa0043b72>] i915_gem_execbuffer2+0xc2/0x2a0 [i915]
> [ 157.744753] [<ffffffff815485b7>] drm_ioctl+0x207/0x4c0
> [ 157.744765] [<ffffffffa0043ab0>] ? i915_gem_execbuffer+0x360/0x360 [i915]
> [ 157.744767] [<ffffffff810ea4ad>] ? debug_lockdep_rcu_enabled+0x1d/0x20
> [ 157.744769] [<ffffffff811fe09e>] do_vfs_ioctl+0x8e/0x680
> [ 157.744770] [<ffffffff811a2377>] ? __might_fault+0x87/0x90
> [ 157.744771] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> [ 157.744773] [<ffffffff810d3df2>] ? trace_hardirqs_on_caller+0x122/0x1b0
> [ 157.744774] [<ffffffff811fe6cc>] SyS_ioctl+0x3c/0x70
> [ 157.744776] [<ffffffff8180fe69>] entry_SYSCALL_64_fastpath+0x1c/0xac
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97491
> Fixes: 87660502f1a4 ("drm/i915/gen6+: Interpret mailbox error flags")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lyude <cpaul@redhat.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/i915/intel_pm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 729d952174d8..aba6fd036c4e 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -7753,6 +7753,7 @@ static inline int gen6_check_mailbox_status(struct drm_i915_private *dev_priv)
> case GEN6_PCODE_ILLEGAL_CMD:
> return -ENXIO;
> case GEN6_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> + case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> return -EOVERFLOW;
> case GEN6_PCODE_TIMEOUT:
> return -ETIMEDOUT;
Isn't it more likely that 0x10 means something different? I vaguely recall looking
over the table and saw that 10h was something different entirely, but can't find it back now.
~Maarten
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
@ 2016-08-29 7:33 ` Maarten Lankhorst
0 siblings, 0 replies; 8+ messages in thread
From: Maarten Lankhorst @ 2016-08-29 7:33 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Daniel Vetter, stable
Op 26-08-16 om 12:59 schreef Chris Wilson:
> According to the CI test machines, SNB also uses the
> GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE value to report a bad
> GEN6_PCODE_MIN_FREQ_TABLE request.
>
> [ 157.744641] WARNING: CPU: 5 PID: 9238 at
> drivers/gpu/drm/i915/intel_pm.c:7760 sandybridge_pcode_write+0x141/0x200 [i915]
> [ 157.744642] Missing switch case (16) in gen6_check_mailbox_status
> [ 157.744642] Modules linked in: snd_hda_intel i915 ax88179_178a usbnet mii x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hwdep snd_hda_core mei_me lpc_ich snd_pcm mei broadcom bcm_phy_lib tg3 ptp pps_core [last unloaded: vgem]
> [ 157.744658] CPU: 5 PID: 9238 Comm: drv_hangman Tainted: G U W 4.8.0-rc3-CI-CI_DRM_1589+ #1
> [ 157.744658] Hardware name: Dell Inc. XPS 8300 /0Y2MRG, BIOS A06 10/17/2011
> [ 157.744659] 0000000000000000 ffff88011f093a98 ffffffff81426415 ffff88011f093ae8
> [ 157.744662] 0000000000000000 ffff88011f093ad8 ffffffff8107d2a6 00001e50810d3c9f
> [ 157.744663] ffff880128680000 0000000000000008 0000000000000000 ffff88012868a650
> [ 157.744665] Call Trace:
> [ 157.744669] [<ffffffff81426415>] dump_stack+0x67/0x92
> [ 157.744672] [<ffffffff8107d2a6>] __warn+0xc6/0xe0
> [ 157.744673] [<ffffffff8107d30a>] warn_slowpath_fmt+0x4a/0x50
> [ 157.744685] [<ffffffffa0029831>] sandybridge_pcode_write+0x141/0x200 [i915]
> [ 157.744697] [<ffffffffa002a88a>] intel_enable_gt_powersave+0x64a/0x1330 [i915]
> [ 157.744712] [<ffffffffa006b4cb>] ? i9xx_emit_request+0x1b/0x80 [i915]
> [ 157.744725] [<ffffffffa0055ed3>] __i915_add_request+0x1e3/0x370 [i915]
> [ 157.744738] [<ffffffffa00428bd>] i915_gem_do_execbuffer.isra.16+0xced/0x1b80 [i915]
> [ 157.744740] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> [ 157.744752] [<ffffffffa0043b72>] i915_gem_execbuffer2+0xc2/0x2a0 [i915]
> [ 157.744753] [<ffffffff815485b7>] drm_ioctl+0x207/0x4c0
> [ 157.744765] [<ffffffffa0043ab0>] ? i915_gem_execbuffer+0x360/0x360 [i915]
> [ 157.744767] [<ffffffff810ea4ad>] ? debug_lockdep_rcu_enabled+0x1d/0x20
> [ 157.744769] [<ffffffff811fe09e>] do_vfs_ioctl+0x8e/0x680
> [ 157.744770] [<ffffffff811a2377>] ? __might_fault+0x87/0x90
> [ 157.744771] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> [ 157.744773] [<ffffffff810d3df2>] ? trace_hardirqs_on_caller+0x122/0x1b0
> [ 157.744774] [<ffffffff811fe6cc>] SyS_ioctl+0x3c/0x70
> [ 157.744776] [<ffffffff8180fe69>] entry_SYSCALL_64_fastpath+0x1c/0xac
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97491
> Fixes: 87660502f1a4 ("drm/i915/gen6+: Interpret mailbox error flags")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lyude <cpaul@redhat.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/i915/intel_pm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 729d952174d8..aba6fd036c4e 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -7753,6 +7753,7 @@ static inline int gen6_check_mailbox_status(struct drm_i915_private *dev_priv)
> case GEN6_PCODE_ILLEGAL_CMD:
> return -ENXIO;
> case GEN6_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> + case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> return -EOVERFLOW;
> case GEN6_PCODE_TIMEOUT:
> return -ETIMEDOUT;
Isn't it more likely that 0x10 means something different? I vaguely recall looking
over the table and saw that 10h was something different entirely, but can't find it back now.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
2016-08-29 7:33 ` Maarten Lankhorst
@ 2016-08-29 18:59 ` Chris Wilson
-1 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2016-08-29 18:59 UTC (permalink / raw)
To: Maarten Lankhorst
Cc: intel-gfx, Lyude, Matt Roper, Daniel Vetter,
Ville Syrjälä,
stable
On Mon, Aug 29, 2016 at 09:33:18AM +0200, Maarten Lankhorst wrote:
> Op 26-08-16 om 12:59 schreef Chris Wilson:
> > According to the CI test machines, SNB also uses the
> > GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE value to report a bad
> > GEN6_PCODE_MIN_FREQ_TABLE request.
> >
> > [ 157.744641] WARNING: CPU: 5 PID: 9238 at
> > drivers/gpu/drm/i915/intel_pm.c:7760 sandybridge_pcode_write+0x141/0x200 [i915]
> > [ 157.744642] Missing switch case (16) in gen6_check_mailbox_status
> > [ 157.744642] Modules linked in: snd_hda_intel i915 ax88179_178a usbnet mii x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hwdep snd_hda_core mei_me lpc_ich snd_pcm mei broadcom bcm_phy_lib tg3 ptp pps_core [last unloaded: vgem]
> > [ 157.744658] CPU: 5 PID: 9238 Comm: drv_hangman Tainted: G U W 4.8.0-rc3-CI-CI_DRM_1589+ #1
> > [ 157.744658] Hardware name: Dell Inc. XPS 8300 /0Y2MRG, BIOS A06 10/17/2011
> > [ 157.744659] 0000000000000000 ffff88011f093a98 ffffffff81426415 ffff88011f093ae8
> > [ 157.744662] 0000000000000000 ffff88011f093ad8 ffffffff8107d2a6 00001e50810d3c9f
> > [ 157.744663] ffff880128680000 0000000000000008 0000000000000000 ffff88012868a650
> > [ 157.744665] Call Trace:
> > [ 157.744669] [<ffffffff81426415>] dump_stack+0x67/0x92
> > [ 157.744672] [<ffffffff8107d2a6>] __warn+0xc6/0xe0
> > [ 157.744673] [<ffffffff8107d30a>] warn_slowpath_fmt+0x4a/0x50
> > [ 157.744685] [<ffffffffa0029831>] sandybridge_pcode_write+0x141/0x200 [i915]
> > [ 157.744697] [<ffffffffa002a88a>] intel_enable_gt_powersave+0x64a/0x1330 [i915]
> > [ 157.744712] [<ffffffffa006b4cb>] ? i9xx_emit_request+0x1b/0x80 [i915]
> > [ 157.744725] [<ffffffffa0055ed3>] __i915_add_request+0x1e3/0x370 [i915]
> > [ 157.744738] [<ffffffffa00428bd>] i915_gem_do_execbuffer.isra.16+0xced/0x1b80 [i915]
> > [ 157.744740] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> > [ 157.744752] [<ffffffffa0043b72>] i915_gem_execbuffer2+0xc2/0x2a0 [i915]
> > [ 157.744753] [<ffffffff815485b7>] drm_ioctl+0x207/0x4c0
> > [ 157.744765] [<ffffffffa0043ab0>] ? i915_gem_execbuffer+0x360/0x360 [i915]
> > [ 157.744767] [<ffffffff810ea4ad>] ? debug_lockdep_rcu_enabled+0x1d/0x20
> > [ 157.744769] [<ffffffff811fe09e>] do_vfs_ioctl+0x8e/0x680
> > [ 157.744770] [<ffffffff811a2377>] ? __might_fault+0x87/0x90
> > [ 157.744771] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> > [ 157.744773] [<ffffffff810d3df2>] ? trace_hardirqs_on_caller+0x122/0x1b0
> > [ 157.744774] [<ffffffff811fe6cc>] SyS_ioctl+0x3c/0x70
> > [ 157.744776] [<ffffffff8180fe69>] entry_SYSCALL_64_fastpath+0x1c/0xac
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97491
> > Fixes: 87660502f1a4 ("drm/i915/gen6+: Interpret mailbox error flags")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Lyude <cpaul@redhat.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> > Cc: stable@vger.kernel.org
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 729d952174d8..aba6fd036c4e 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -7753,6 +7753,7 @@ static inline int gen6_check_mailbox_status(struct drm_i915_private *dev_priv)
> > case GEN6_PCODE_ILLEGAL_CMD:
> > return -ENXIO;
> > case GEN6_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> > + case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> > return -EOVERFLOW;
> > case GEN6_PCODE_TIMEOUT:
> > return -ETIMEDOUT;
>
> Isn't it more likely that 0x10 means something different?
Could well be just coincidence that it seemed to pop out of the
MIN_FREQ_TABLE write.
> I vaguely recall looking
> over the table and saw that 10h was something different entirely, but can't find it back now.
I was hoping you still had the spec handy. I don't think it's that
urgent, the error value is mostly ignored :) It's adding a common WARN
that tends to get noticed.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB
@ 2016-08-29 18:59 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2016-08-29 18:59 UTC (permalink / raw)
To: Maarten Lankhorst
Cc: intel-gfx, Lyude, Matt Roper, Daniel Vetter,
Ville Syrjälä,
stable
On Mon, Aug 29, 2016 at 09:33:18AM +0200, Maarten Lankhorst wrote:
> Op 26-08-16 om 12:59 schreef Chris Wilson:
> > According to the CI test machines, SNB also uses the
> > GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE value to report a bad
> > GEN6_PCODE_MIN_FREQ_TABLE request.
> >
> > [ 157.744641] WARNING: CPU: 5 PID: 9238 at
> > drivers/gpu/drm/i915/intel_pm.c:7760 sandybridge_pcode_write+0x141/0x200 [i915]
> > [ 157.744642] Missing switch case (16) in gen6_check_mailbox_status
> > [ 157.744642] Modules linked in: snd_hda_intel i915 ax88179_178a usbnet mii x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hwdep snd_hda_core mei_me lpc_ich snd_pcm mei broadcom bcm_phy_lib tg3 ptp pps_core [last unloaded: vgem]
> > [ 157.744658] CPU: 5 PID: 9238 Comm: drv_hangman Tainted: G U W 4.8.0-rc3-CI-CI_DRM_1589+ #1
> > [ 157.744658] Hardware name: Dell Inc. XPS 8300 /0Y2MRG, BIOS A06 10/17/2011
> > [ 157.744659] 0000000000000000 ffff88011f093a98 ffffffff81426415 ffff88011f093ae8
> > [ 157.744662] 0000000000000000 ffff88011f093ad8 ffffffff8107d2a6 00001e50810d3c9f
> > [ 157.744663] ffff880128680000 0000000000000008 0000000000000000 ffff88012868a650
> > [ 157.744665] Call Trace:
> > [ 157.744669] [<ffffffff81426415>] dump_stack+0x67/0x92
> > [ 157.744672] [<ffffffff8107d2a6>] __warn+0xc6/0xe0
> > [ 157.744673] [<ffffffff8107d30a>] warn_slowpath_fmt+0x4a/0x50
> > [ 157.744685] [<ffffffffa0029831>] sandybridge_pcode_write+0x141/0x200 [i915]
> > [ 157.744697] [<ffffffffa002a88a>] intel_enable_gt_powersave+0x64a/0x1330 [i915]
> > [ 157.744712] [<ffffffffa006b4cb>] ? i9xx_emit_request+0x1b/0x80 [i915]
> > [ 157.744725] [<ffffffffa0055ed3>] __i915_add_request+0x1e3/0x370 [i915]
> > [ 157.744738] [<ffffffffa00428bd>] i915_gem_do_execbuffer.isra.16+0xced/0x1b80 [i915]
> > [ 157.744740] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> > [ 157.744752] [<ffffffffa0043b72>] i915_gem_execbuffer2+0xc2/0x2a0 [i915]
> > [ 157.744753] [<ffffffff815485b7>] drm_ioctl+0x207/0x4c0
> > [ 157.744765] [<ffffffffa0043ab0>] ? i915_gem_execbuffer+0x360/0x360 [i915]
> > [ 157.744767] [<ffffffff810ea4ad>] ? debug_lockdep_rcu_enabled+0x1d/0x20
> > [ 157.744769] [<ffffffff811fe09e>] do_vfs_ioctl+0x8e/0x680
> > [ 157.744770] [<ffffffff811a2377>] ? __might_fault+0x87/0x90
> > [ 157.744771] [<ffffffff811a232e>] ? __might_fault+0x3e/0x90
> > [ 157.744773] [<ffffffff810d3df2>] ? trace_hardirqs_on_caller+0x122/0x1b0
> > [ 157.744774] [<ffffffff811fe6cc>] SyS_ioctl+0x3c/0x70
> > [ 157.744776] [<ffffffff8180fe69>] entry_SYSCALL_64_fastpath+0x1c/0xac
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97491
> > Fixes: 87660502f1a4 ("drm/i915/gen6+: Interpret mailbox error flags")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Lyude <cpaul@redhat.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: stable@vger.kernel.org
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 729d952174d8..aba6fd036c4e 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -7753,6 +7753,7 @@ static inline int gen6_check_mailbox_status(struct drm_i915_private *dev_priv)
> > case GEN6_PCODE_ILLEGAL_CMD:
> > return -ENXIO;
> > case GEN6_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> > + case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
> > return -EOVERFLOW;
> > case GEN6_PCODE_TIMEOUT:
> > return -ETIMEDOUT;
>
> Isn't it more likely that 0x10 means something different?
Could well be just coincidence that it seemed to pop out of the
MIN_FREQ_TABLE write.
> I vaguely recall looking
> over the table and saw that 10h was something different entirely, but can't find it back now.
I was hoping you still had the spec handy. I don't think it's that
urgent, the error value is mostly ignored :) It's adding a common WARN
that tends to get noticed.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-08-29 18:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 10:59 [PATCH] drm/i915: Add GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE to SNB Chris Wilson
2016-08-26 10:59 ` Chris Wilson
2016-08-26 11:19 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-08-26 17:11 ` Chris Wilson
2016-08-29 7:33 ` [PATCH] " Maarten Lankhorst
2016-08-29 7:33 ` Maarten Lankhorst
2016-08-29 18:59 ` Chris Wilson
2016-08-29 18:59 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.