* [PATCH] xfs_quota: fix missing break after foreign_allowed option
@ 2016-08-26 8:30 Zorro Lang
2016-08-26 12:31 ` Eric Sandeen
2016-08-26 13:36 ` Bill O'Donnell
0 siblings, 2 replies; 3+ messages in thread
From: Zorro Lang @ 2016-08-26 8:30 UTC (permalink / raw)
To: xfs; +Cc: Zorro Lang
New quota "-f" has been brought in by:
29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
But Coverity Scan find a missing break in quota/init.c: init()
function.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
quota/init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/quota/init.c b/quota/init.c
index 44be322..2c18c8b 100644
--- a/quota/init.c
+++ b/quota/init.c
@@ -153,6 +153,7 @@ init(
break;
case 'f':
foreign_allowed = true;
+ break;
case 't':
mtab_file = optarg;
break;
--
2.7.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option
2016-08-26 8:30 [PATCH] xfs_quota: fix missing break after foreign_allowed option Zorro Lang
@ 2016-08-26 12:31 ` Eric Sandeen
2016-08-26 13:36 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2016-08-26 12:31 UTC (permalink / raw)
To: xfs
On 8/26/16 3:30 AM, Zorro Lang wrote:
> New quota "-f" has been brought in by:
>
> 29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
>
> But Coverity Scan find a missing break in quota/init.c: init()
> function.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> quota/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/quota/init.c b/quota/init.c
> index 44be322..2c18c8b 100644
> --- a/quota/init.c
> +++ b/quota/init.c
> @@ -153,6 +153,7 @@ init(
> break;
> case 'f':
> foreign_allowed = true;
> + break;
> case 't':
> mtab_file = optarg;
> break;
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option
2016-08-26 8:30 [PATCH] xfs_quota: fix missing break after foreign_allowed option Zorro Lang
2016-08-26 12:31 ` Eric Sandeen
@ 2016-08-26 13:36 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Bill O'Donnell @ 2016-08-26 13:36 UTC (permalink / raw)
To: Zorro Lang; +Cc: xfs
On Fri, Aug 26, 2016 at 04:30:06PM +0800, Zorro Lang wrote:
> New quota "-f" has been brought in by:
>
> 29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
>
> But Coverity Scan find a missing break in quota/init.c: init()
> function.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
Sorry about that.
Thanks for the patch, Zorro.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> quota/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/quota/init.c b/quota/init.c
> index 44be322..2c18c8b 100644
> --- a/quota/init.c
> +++ b/quota/init.c
> @@ -153,6 +153,7 @@ init(
> break;
> case 'f':
> foreign_allowed = true;
> + break;
> case 't':
> mtab_file = optarg;
> break;
> --
> 2.7.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-26 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 8:30 [PATCH] xfs_quota: fix missing break after foreign_allowed option Zorro Lang
2016-08-26 12:31 ` Eric Sandeen
2016-08-26 13:36 ` Bill O'Donnell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.