* [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support
@ 2016-08-16 14:27 Vanessa Maegima
2016-08-16 14:27 ` [PATCH 2/2] ARM: dts: imx7s-warp: Add User Button support Vanessa Maegima
2016-08-29 1:35 ` [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Vanessa Maegima @ 2016-08-16 14:27 UTC (permalink / raw)
To: linux-arm-kernel
Add NFC support for NT3H1101W0FHK device.
Tested by verifying Manufacturer ID (04h) at address 0x00, via i2ctools.
Signed-off-by: Vanessa Maegima <vanessa.maegima@nxp.com>
---
arch/arm/boot/dts/imx7s-warp.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
index 92d9c85..71dbece 100644
--- a/arch/arm/boot/dts/imx7s-warp.dts
+++ b/arch/arm/boot/dts/imx7s-warp.dts
@@ -188,6 +188,13 @@
};
};
+&i2c2 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c2>;
+ status = "okay";
+};
+
&i2c4 {
clock-frequency = <100000>;
pinctrl-names = "default";
@@ -278,6 +285,13 @@
>;
};
+ pinctrl_i2c2: i2c2grp {
+ fsl,pins = <
+ MX7D_PAD_I2C2_SDA__I2C2_SDA 0x4000007f
+ MX7D_PAD_I2C2_SCL__I2C2_SCL 0x4000007f
+ >;
+ };
+
pinctrl_i2c4: i2c4grp {
fsl,pins = <
MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: imx7s-warp: Add User Button support
2016-08-16 14:27 [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support Vanessa Maegima
@ 2016-08-16 14:27 ` Vanessa Maegima
2016-08-29 1:46 ` Shawn Guo
2016-08-29 1:35 ` [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Vanessa Maegima @ 2016-08-16 14:27 UTC (permalink / raw)
To: linux-arm-kernel
Add User Button at GPIO7_1.
Tested by evtest.
Signed-off-by: Vanessa Maegima <vanessa.maegima@nxp.com>
---
arch/arm/boot/dts/imx7s-warp.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
index 71dbece..794aa94 100644
--- a/arch/arm/boot/dts/imx7s-warp.dts
+++ b/arch/arm/boot/dts/imx7s-warp.dts
@@ -54,6 +54,19 @@
reg = <0x80000000 0x20000000>;
};
+ gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-0 = <&pinctrl_gpio>;
+ autorepeat;
+ back {
+ label = "Back";
+ gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
+ linux,code = <KEY_BACK>;
+ gpio-key,wakeup;
+ autorepeat;
+ };
+ };
+
reg_brcm: regulator-brcm {
compatible = "regulator-fixed";
enable-active-high;
@@ -278,6 +291,12 @@
>;
};
+ pinctrl_gpio: gpiogrp {
+ fsl,pins = <
+ MX7D_PAD_ENET1_RGMII_RD1__GPIO7_IO1 0x14
+ >;
+ };
+
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support
2016-08-16 14:27 [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support Vanessa Maegima
2016-08-16 14:27 ` [PATCH 2/2] ARM: dts: imx7s-warp: Add User Button support Vanessa Maegima
@ 2016-08-29 1:35 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2016-08-29 1:35 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 16, 2016 at 11:27:28AM -0300, Vanessa Maegima wrote:
> Add NFC support for NT3H1101W0FHK device.
>
> Tested by verifying Manufacturer ID (04h) at address 0x00, via i2ctools.
What the code change tells is all about enabling I2C2 device support.
Please update patch subject and commit log.
Shawn
>
> Signed-off-by: Vanessa Maegima <vanessa.maegima@nxp.com>
> ---
> arch/arm/boot/dts/imx7s-warp.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
> index 92d9c85..71dbece 100644
> --- a/arch/arm/boot/dts/imx7s-warp.dts
> +++ b/arch/arm/boot/dts/imx7s-warp.dts
> @@ -188,6 +188,13 @@
> };
> };
>
> +&i2c2 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + status = "okay";
> +};
> +
> &i2c4 {
> clock-frequency = <100000>;
> pinctrl-names = "default";
> @@ -278,6 +285,13 @@
> >;
> };
>
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX7D_PAD_I2C2_SDA__I2C2_SDA 0x4000007f
> + MX7D_PAD_I2C2_SCL__I2C2_SCL 0x4000007f
> + >;
> + };
> +
> pinctrl_i2c4: i2c4grp {
> fsl,pins = <
> MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: imx7s-warp: Add User Button support
2016-08-16 14:27 ` [PATCH 2/2] ARM: dts: imx7s-warp: Add User Button support Vanessa Maegima
@ 2016-08-29 1:46 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2016-08-29 1:46 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 16, 2016 at 11:27:29AM -0300, Vanessa Maegima wrote:
> Add User Button at GPIO7_1.
>
> Tested by evtest.
>
> Signed-off-by: Vanessa Maegima <vanessa.maegima@nxp.com>
> ---
> arch/arm/boot/dts/imx7s-warp.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
> index 71dbece..794aa94 100644
> --- a/arch/arm/boot/dts/imx7s-warp.dts
> +++ b/arch/arm/boot/dts/imx7s-warp.dts
> @@ -54,6 +54,19 @@
> reg = <0x80000000 0x20000000>;
> };
>
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&pinctrl_gpio>;
> + autorepeat;
Please have a newline between property list and sub-node.
> + back {
> + label = "Back";
> + gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
> + linux,code = <KEY_BACK>;
> + gpio-key,wakeup;
This property is deprecated, and 'wakeup-source' should be used instead.
See Documentation/devicetree/bindings/power/wakeup-source.txt for
details.
> + autorepeat;
Is it really necessary to have this property in both parent and child
node?
Shawn
> + };
> + };
> +
> reg_brcm: regulator-brcm {
> compatible = "regulator-fixed";
> enable-active-high;
> @@ -278,6 +291,12 @@
> >;
> };
>
> + pinctrl_gpio: gpiogrp {
> + fsl,pins = <
> + MX7D_PAD_ENET1_RGMII_RD1__GPIO7_IO1 0x14
> + >;
> + };
> +
> pinctrl_i2c1: i2c1grp {
> fsl,pins = <
> MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-29 1:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16 14:27 [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support Vanessa Maegima
2016-08-16 14:27 ` [PATCH 2/2] ARM: dts: imx7s-warp: Add User Button support Vanessa Maegima
2016-08-29 1:46 ` Shawn Guo
2016-08-29 1:35 ` [PATCH 1/2] ARM: dts: imx7s-warp: Add NFC support Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.