[PATCH] Set errno in is_loopdev on error

[PATCH] Set errno in is_loopdev on error

[Tobias Stoeckmann]

The function is_loopdev does not set errno if the supplied string does
not reference a valid loop device. Fix this to avoid an error message
like this one:

losetup: /: failed to use device: Success

I prefer this one:

losetup: /: failed to use device: No such device

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
---
 lib/loopdev.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lib/loopdev.c b/lib/loopdev.c
index b3941dd..a57e7a7 100644
--- a/lib/loopdev.c
+++ b/lib/loopdev.c
@@ -633,12 +633,13 @@ int is_loopdev(const char *device)
 {
 	struct stat st;
 
-	if (!device)
-		return 0;
-
-	return (stat(device, &st) == 0 &&
+	if (device && stat(device, &st) == 0 &&
 		S_ISBLK(st.st_mode) &&
-		major(st.st_rdev) == LOOPDEV_MAJOR);
+		major(st.st_rdev) == LOOPDEV_MAJOR)
+		return 1;
+
+	errno = ENODEV;
+	return 0;
 }
 
 /*
-- 
2.9.3

Re: [PATCH] Set errno in is_loopdev on error

[Karel Zak]

On Tue, Aug 30, 2016 at 09:00:38PM +0200, Tobias Stoeckmann wrote:
>  lib/loopdev.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

 Good catch. Applied, thanks.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com