All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [PATCH net-next v3 0/2] net: bridge: add per-port unknown multicast flood control
Date: Wed, 31 Aug 2016 08:59:18 -0700	[thread overview]
Message-ID: <20160831085918.686148a6@xeon-e3> (raw)
In-Reply-To: <1472650612-2123-1-git-send-email-nikolay@cumulusnetworks.com>

On Wed, 31 Aug 2016 15:36:50 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:

> Hi,
> The first patch prepares the forwarding path by having the exact packet
> type passed down so we can later filter based on it and the per-port
> unknown mcast flood flag introduced in the second patch. It is similar to
> how the per-port unknown unicast flood flag works.
> Nice side-effects of patch 01 are the slight reduction of tests in the
> fast-path and a few minor checkpatch fixes.
> 
> v3: don't change br_auto_mask as that will change user-visible behaviour
> v2: make pkt_type an enum as per Stephen's comment
> 
> Thanks,
>  Nik
> 
> 
> Nikolay Aleksandrov (2):
>   net: bridge: change unicast boolean to exact pkt_type
>   net: bridge: add per-port multicast flood flag
> 
>  include/linux/if_bridge.h    |  1 +
>  include/uapi/linux/if_link.h |  1 +
>  net/bridge/br_device.c       |  8 ++++----
>  net/bridge/br_forward.c      |  7 +++++--
>  net/bridge/br_if.c           |  2 +-
>  net/bridge/br_input.c        | 40 +++++++++++++++++++++++++---------------
>  net/bridge/br_netlink.c      | 12 +++++++++---
>  net/bridge/br_private.h      |  7 ++++++-
>  net/bridge/br_sysfs_if.c     |  1 +
>  9 files changed, 53 insertions(+), 26 deletions(-)
> 

Looks good thanks, and most importantly shouldn't break existing users.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v3 0/2] net: bridge: add per-port unknown multicast flood control
Date: Wed, 31 Aug 2016 08:59:18 -0700	[thread overview]
Message-ID: <20160831085918.686148a6@xeon-e3> (raw)
In-Reply-To: <1472650612-2123-1-git-send-email-nikolay@cumulusnetworks.com>

On Wed, 31 Aug 2016 15:36:50 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:

> Hi,
> The first patch prepares the forwarding path by having the exact packet
> type passed down so we can later filter based on it and the per-port
> unknown mcast flood flag introduced in the second patch. It is similar to
> how the per-port unknown unicast flood flag works.
> Nice side-effects of patch 01 are the slight reduction of tests in the
> fast-path and a few minor checkpatch fixes.
> 
> v3: don't change br_auto_mask as that will change user-visible behaviour
> v2: make pkt_type an enum as per Stephen's comment
> 
> Thanks,
>  Nik
> 
> 
> Nikolay Aleksandrov (2):
>   net: bridge: change unicast boolean to exact pkt_type
>   net: bridge: add per-port multicast flood flag
> 
>  include/linux/if_bridge.h    |  1 +
>  include/uapi/linux/if_link.h |  1 +
>  net/bridge/br_device.c       |  8 ++++----
>  net/bridge/br_forward.c      |  7 +++++--
>  net/bridge/br_if.c           |  2 +-
>  net/bridge/br_input.c        | 40 +++++++++++++++++++++++++---------------
>  net/bridge/br_netlink.c      | 12 +++++++++---
>  net/bridge/br_private.h      |  7 ++++++-
>  net/bridge/br_sysfs_if.c     |  1 +
>  9 files changed, 53 insertions(+), 26 deletions(-)
> 

Looks good thanks, and most importantly shouldn't break existing users.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

  parent reply	other threads:[~2016-08-31 15:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 13:36 [PATCH net-next v3 0/2] net: bridge: add per-port unknown multicast flood control Nikolay Aleksandrov via Bridge
2016-08-31 13:36 ` [Bridge] " Nikolay Aleksandrov
2016-08-31 13:36 ` [PATCH net-next v3 1/2] net: bridge: change unicast boolean to exact pkt_type Nikolay Aleksandrov
2016-08-31 13:36   ` [Bridge] " Nikolay Aleksandrov
2016-08-31 13:36 ` [PATCH net-next v3 2/2] net: bridge: add per-port multicast flood flag Nikolay Aleksandrov
2016-08-31 13:36   ` [Bridge] " Nikolay Aleksandrov
2016-08-31 15:59 ` Stephen Hemminger [this message]
2016-08-31 15:59   ` [Bridge] [PATCH net-next v3 0/2] net: bridge: add per-port unknown multicast flood control Stephen Hemminger
2016-09-02  5:48 ` David Miller
2016-09-02  5:48   ` [Bridge] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160831085918.686148a6@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.