All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
@ 2016-08-31 13:56 ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2016-08-31 13:56 UTC (permalink / raw)
  To: shawnguo; +Cc: xdrudis, nicoleotsuka, linux-arm-kernel, Fabio Estevam, stable

Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
changed many more clocks than only the SPDIF core clock as stated in
the commit message.

The MLB clock has been added and this causes SPDIF regression as
reported by Xavi Drudis Ferran and also in this forum post:
https://forum.digikey.com/thread/34240

The MX6Q Reference Manual does not mention that MLB is a clock related
to SPDIF, so change it back to a dummy clock to restore SPDIF
functionality.

Thanks to Ambika for providing the fix at:
https://community.nxp.com/thread/387131

Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
Cc: <stable@vger.kernel.org> # 4.4.x
Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index b620ac8..b13b0b2 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -243,7 +243,7 @@
 					clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
 						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
-						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
+						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
 					clock-names = "core",  "rxtx0",
 						      "rxtx1", "rxtx2",
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
@ 2016-08-31 13:56 ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2016-08-31 13:56 UTC (permalink / raw)
  To: linux-arm-kernel

Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
changed many more clocks than only the SPDIF core clock as stated in
the commit message.

The MLB clock has been added and this causes SPDIF regression as
reported by Xavi Drudis Ferran and also in this forum post:
https://forum.digikey.com/thread/34240

The MX6Q Reference Manual does not mention that MLB is a clock related
to SPDIF, so change it back to a dummy clock to restore SPDIF
functionality.

Thanks to Ambika for providing the fix at:
https://community.nxp.com/thread/387131

Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
Cc: <stable@vger.kernel.org> # 4.4.x
Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index b620ac8..b13b0b2 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -243,7 +243,7 @@
 					clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
 						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
-						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
+						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
 					clock-names = "core",  "rxtx0",
 						      "rxtx1", "rxtx2",
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
  2016-08-31 13:56 ` Fabio Estevam
@ 2016-08-31 14:10   ` Xavi Drudis Ferran
  -1 siblings, 0 replies; 6+ messages in thread
From: Xavi Drudis Ferran @ 2016-08-31 14:10 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: shawnguo, xdrudis, nicoleotsuka, linux-arm-kernel, stable

El Wed, Aug 31, 2016 at 10:56:48AM -0300, Fabio Estevam deia:
> Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> changed many more clocks than only the SPDIF core clock as stated in
> the commit message.
> 
> The MLB clock has been added and this causes SPDIF regression as
> reported by Xavi Drudis Ferran and also in this forum post:
> https://forum.digikey.com/thread/34240
> 
> The MX6Q Reference Manual does not mention that MLB is a clock related
> to SPDIF, so change it back to a dummy clock to restore SPDIF
> functionality.
> 
> Thanks to Ambika for providing the fix at:
> https://community.nxp.com/thread/387131
> 
> Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> Cc: <stable@vger.kernel.org> # 4.4.x
> Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index b620ac8..b13b0b2 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -243,7 +243,7 @@
>  					clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
>  						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
>  						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
> -						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
> +						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
>  						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
>  					clock-names = "core",  "rxtx0",
>  						      "rxtx1", "rxtx2",
> -- 
> 1.9.1
> 

Tested-by:  Xavi Drudis Ferran <xdrudis@tinet.cat>

(on linux-libre-4.7, wandboard-quad-rev-b1, imx6q MCIMX6Q5EYM10AC ,according to wandboard manual BOM)
Before the change I didn't hear output on spdif, after the change output sounds ok. 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
@ 2016-08-31 14:10   ` Xavi Drudis Ferran
  0 siblings, 0 replies; 6+ messages in thread
From: Xavi Drudis Ferran @ 2016-08-31 14:10 UTC (permalink / raw)
  To: linux-arm-kernel

El Wed, Aug 31, 2016 at 10:56:48AM -0300, Fabio Estevam deia:
> Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> changed many more clocks than only the SPDIF core clock as stated in
> the commit message.
> 
> The MLB clock has been added and this causes SPDIF regression as
> reported by Xavi Drudis Ferran and also in this forum post:
> https://forum.digikey.com/thread/34240
> 
> The MX6Q Reference Manual does not mention that MLB is a clock related
> to SPDIF, so change it back to a dummy clock to restore SPDIF
> functionality.
> 
> Thanks to Ambika for providing the fix at:
> https://community.nxp.com/thread/387131
> 
> Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> Cc: <stable@vger.kernel.org> # 4.4.x
> Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index b620ac8..b13b0b2 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -243,7 +243,7 @@
>  					clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
>  						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
>  						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
> -						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
> +						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
>  						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
>  					clock-names = "core",  "rxtx0",
>  						      "rxtx1", "rxtx2",
> -- 
> 1.9.1
> 

Tested-by:  Xavi Drudis Ferran <xdrudis@tinet.cat>

(on linux-libre-4.7, wandboard-quad-rev-b1, imx6q MCIMX6Q5EYM10AC ,according to wandboard manual BOM)
Before the change I didn't hear output on spdif, after the change output sounds ok. 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
  2016-08-31 13:56 ` Fabio Estevam
@ 2016-09-05  2:31   ` Shawn Guo
  -1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2016-09-05  2:31 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: nicoleotsuka, xdrudis, stable, linux-arm-kernel

On Wed, Aug 31, 2016 at 10:56:48AM -0300, Fabio Estevam wrote:
> Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> changed many more clocks than only the SPDIF core clock as stated in
> the commit message.
> 
> The MLB clock has been added and this causes SPDIF regression as
> reported by Xavi Drudis Ferran and also in this forum post:
> https://forum.digikey.com/thread/34240
> 
> The MX6Q Reference Manual does not mention that MLB is a clock related
> to SPDIF, so change it back to a dummy clock to restore SPDIF
> functionality.
> 
> Thanks to Ambika for providing the fix at:
> https://community.nxp.com/thread/387131
> 
> Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> Cc: <stable@vger.kernel.org> # 4.4.x
> Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression
@ 2016-09-05  2:31   ` Shawn Guo
  0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2016-09-05  2:31 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Aug 31, 2016 at 10:56:48AM -0300, Fabio Estevam wrote:
> Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> changed many more clocks than only the SPDIF core clock as stated in
> the commit message.
> 
> The MLB clock has been added and this causes SPDIF regression as
> reported by Xavi Drudis Ferran and also in this forum post:
> https://forum.digikey.com/thread/34240
> 
> The MX6Q Reference Manual does not mention that MLB is a clock related
> to SPDIF, so change it back to a dummy clock to restore SPDIF
> functionality.
> 
> Thanks to Ambika for providing the fix at:
> https://community.nxp.com/thread/387131
> 
> Fixes: 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
> Cc: <stable@vger.kernel.org> # 4.4.x
> Reported-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-05  2:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 13:56 [PATCH] ARM: dts: imx6qdl: Fix SPDIF regression Fabio Estevam
2016-08-31 13:56 ` Fabio Estevam
2016-08-31 14:10 ` Xavi Drudis Ferran
2016-08-31 14:10   ` Xavi Drudis Ferran
2016-09-05  2:31 ` Shawn Guo
2016-09-05  2:31   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.