From: Lee Jones <lee.jones@linaro.org> To: Mark Brown <broonie@kernel.org> Cc: Tero Kristo <t-kristo@ti.com>, Dave Gerlach <d-gerlach@ti.com>, Keerthy <j-keerthy@ti.com>, tony@atomide.com, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, russ.dill@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk Subject: Re: Applied "regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs" to the regulator tree Date: Wed, 31 Aug 2016 16:01:15 +0100 [thread overview] Message-ID: <20160831150115.GP9415@dell> (raw) In-Reply-To: <E1bXZja-0000XE-A6@debutante> On Wed, 10 Aug 2016, Mark Brown wrote: > The patch > > regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Looks like I also need this patch. Would you be kind enough to shoot me a pull-request please? > has been applied to the regulator tree at > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > Thanks, > Mark > > From 23a34f9d03a5d40a6234855bc069da370708cc9e Mon Sep 17 00:00:00 2001 > From: Tero Kristo <t-kristo@ti.com> > Date: Wed, 10 Aug 2016 17:53:55 +0530 > Subject: [PATCH] regulator: tps65218: do not disable DCDC3 during poweroff on > broken PMICs > > Some versions of tps65218 do not seem to support poweroff modes properly > if DCDC3 regulator is shut-down. Thus, keep it enabled even during > poweroff if the version info matches the broken silicon revision. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Signed-off-by: Dave Gerlach <d-gerlach@ti.com> > Signed-off-by: Keerthy <j-keerthy@ti.com> > Acked-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > drivers/regulator/tps65218-regulator.c | 8 ++++++++ > include/linux/mfd/tps65218.h | 5 +++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c > index d1e631d64a20..eb0f5b13841a 100644 > --- a/drivers/regulator/tps65218-regulator.c > +++ b/drivers/regulator/tps65218-regulator.c > @@ -180,6 +180,14 @@ static int tps65218_pmic_set_suspend_disable(struct regulator_dev *dev) > if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1) > return -EINVAL; > > + /* > + * Certain revisions of TPS65218 will need to have DCDC3 regulator > + * enabled always, otherwise an immediate system reboot will occur > + * during poweroff. > + */ > + if (rid == TPS65218_DCDC_3 && tps->rev == TPS65218_REV_2_1) > + return 0; > + > if (!tps->info[rid]->strobe) { > if (rid == TPS65218_DCDC_3) > tps->info[rid]->strobe = 3; > diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h > index 85e464e32c43..d1db9527fab5 100644 > --- a/include/linux/mfd/tps65218.h > +++ b/include/linux/mfd/tps65218.h > @@ -63,6 +63,11 @@ > #define TPS65218_CHIPID_CHIP_MASK 0xF8 > #define TPS65218_CHIPID_REV_MASK 0x07 > > +#define TPS65218_REV_1_0 0x0 > +#define TPS65218_REV_1_1 0x1 > +#define TPS65218_REV_2_0 0x2 > +#define TPS65218_REV_2_1 0x3 > + > #define TPS65218_INT1_VPRG BIT(5) > #define TPS65218_INT1_AC BIT(4) > #define TPS65218_INT1_PB BIT(3) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>, Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>, Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, russ.dill-l0cyMroinI0@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org Subject: Re: Applied "regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs" to the regulator tree Date: Wed, 31 Aug 2016 16:01:15 +0100 [thread overview] Message-ID: <20160831150115.GP9415@dell> (raw) In-Reply-To: <E1bXZja-0000XE-A6@debutante> On Wed, 10 Aug 2016, Mark Brown wrote: > The patch > > regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Looks like I also need this patch. Would you be kind enough to shoot me a pull-request please? > has been applied to the regulator tree at > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > Thanks, > Mark > > From 23a34f9d03a5d40a6234855bc069da370708cc9e Mon Sep 17 00:00:00 2001 > From: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org> > Date: Wed, 10 Aug 2016 17:53:55 +0530 > Subject: [PATCH] regulator: tps65218: do not disable DCDC3 during poweroff on > broken PMICs > > Some versions of tps65218 do not seem to support poweroff modes properly > if DCDC3 regulator is shut-down. Thus, keep it enabled even during > poweroff if the version info matches the broken silicon revision. > > Signed-off-by: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org> > Signed-off-by: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org> > Signed-off-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org> > Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > --- > drivers/regulator/tps65218-regulator.c | 8 ++++++++ > include/linux/mfd/tps65218.h | 5 +++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c > index d1e631d64a20..eb0f5b13841a 100644 > --- a/drivers/regulator/tps65218-regulator.c > +++ b/drivers/regulator/tps65218-regulator.c > @@ -180,6 +180,14 @@ static int tps65218_pmic_set_suspend_disable(struct regulator_dev *dev) > if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1) > return -EINVAL; > > + /* > + * Certain revisions of TPS65218 will need to have DCDC3 regulator > + * enabled always, otherwise an immediate system reboot will occur > + * during poweroff. > + */ > + if (rid == TPS65218_DCDC_3 && tps->rev == TPS65218_REV_2_1) > + return 0; > + > if (!tps->info[rid]->strobe) { > if (rid == TPS65218_DCDC_3) > tps->info[rid]->strobe = 3; > diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h > index 85e464e32c43..d1db9527fab5 100644 > --- a/include/linux/mfd/tps65218.h > +++ b/include/linux/mfd/tps65218.h > @@ -63,6 +63,11 @@ > #define TPS65218_CHIPID_CHIP_MASK 0xF8 > #define TPS65218_CHIPID_REV_MASK 0x07 > > +#define TPS65218_REV_1_0 0x0 > +#define TPS65218_REV_1_1 0x1 > +#define TPS65218_REV_2_0 0x2 > +#define TPS65218_REV_2_1 0x3 > + > #define TPS65218_INT1_VPRG BIT(5) > #define TPS65218_INT1_AC BIT(4) > #define TPS65218_INT1_PB BIT(3) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-31 14:59 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-20 8:43 [PATCH 0/9] regulator: Enable suspend configuration Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-20 8:43 ` [PATCH 1/9] regulator: tps65217: " Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-21 19:08 ` Mark Brown 2016-06-22 10:14 ` Keerthy 2016-06-22 10:14 ` Keerthy 2016-06-22 10:16 ` Mark Brown 2016-06-22 10:16 ` Mark Brown 2016-06-22 10:26 ` Keerthy 2016-06-22 10:26 ` Keerthy 2016-06-23 10:26 ` Mark Brown 2016-06-23 10:26 ` Mark Brown 2016-06-23 10:32 ` Keerthy 2016-06-23 10:32 ` Keerthy 2016-06-20 8:43 ` [PATCH 2/9] regulator: of: setup initial suspend state Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-22 15:29 ` Applied "regulator: of: setup initial suspend state" to the regulator tree Mark Brown 2016-06-22 15:29 ` Mark Brown 2016-06-20 8:43 ` [PATCH 3/9] regulator: tps65218: Enable suspend configuration Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-27 17:00 ` Applied "regulator: tps65218: Enable suspend configuration" to the regulator tree Mark Brown 2016-06-27 17:00 ` Mark Brown 2016-06-20 8:43 ` [PATCH 4/9] ARM: dts: AM437X-GP-EVM: AM437X-SK-EVM: Make dcdc3 dcdc5 and dcdc6 enable during suspend Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-21 11:43 ` Tony Lindgren 2016-06-21 11:43 ` Tony Lindgren 2016-06-21 11:46 ` Tony Lindgren 2016-06-20 8:43 ` [PATCH 5/9] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3 Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-27 17:00 ` Applied "regulator: tps65218: force set power-up/down strobe to 3 for dcdc3" to the regulator tree Mark Brown 2016-06-27 17:00 ` Mark Brown 2016-06-20 8:43 ` [PATCH 6/9] ARM: dts: am437x-gp-evm: disable DDR regulator in rtc-only/poweroff mode Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-20 8:43 ` [PATCH 7/9] mfd: tps65218: add version check to the PMIC probe Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-20 8:45 ` Keerthy 2016-06-20 8:45 ` Keerthy 2016-08-10 20:04 ` Applied "mfd: tps65218: add version check to the PMIC probe" to the regulator tree Mark Brown 2016-08-10 20:04 ` Mark Brown 2016-08-31 8:31 ` Lee Jones 2016-08-31 11:41 ` Mark Brown 2016-08-31 11:41 ` Mark Brown 2016-08-31 14:50 ` Lee Jones 2016-08-31 14:50 ` Lee Jones 2016-08-31 16:02 ` Mark Brown 2016-08-31 16:02 ` Mark Brown 2016-09-01 8:23 ` Lee Jones 2016-09-01 8:23 ` Lee Jones 2016-09-01 8:54 ` Mark Brown 2016-09-01 9:34 ` Lee Jones 2016-08-31 17:57 ` Russell King - ARM Linux 2016-08-31 17:57 ` Russell King - ARM Linux 2016-09-01 8:18 ` Lee Jones 2016-09-01 10:17 ` Russell King - ARM Linux 2016-09-01 10:17 ` Russell King - ARM Linux 2016-09-01 11:19 ` Lee Jones 2016-09-01 11:19 ` Lee Jones 2016-09-01 14:23 ` Russell King - ARM Linux 2016-09-01 14:53 ` Lee Jones 2016-06-20 8:43 ` [PATCH 8/9] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Keerthy 2016-06-20 8:43 ` Keerthy 2016-08-10 20:04 ` Applied "regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs" to the regulator tree Mark Brown 2016-08-10 20:04 ` Mark Brown 2016-08-31 15:01 ` Lee Jones [this message] 2016-08-31 15:01 ` Lee Jones 2016-09-01 10:06 ` Mark Brown 2016-06-20 8:43 ` [PATCH 9/9] ARM: dts: am437x-sk-evm: disable DDR regulator in rtc-only/poweroff mode Keerthy 2016-06-20 8:43 ` Keerthy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160831150115.GP9415@dell \ --to=lee.jones@linaro.org \ --cc=broonie@kernel.org \ --cc=d-gerlach@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=j-keerthy@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=russ.dill@ti.com \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.