* [PATCH] video: fbdev: mb862xx: remove unused variable
@ 2016-08-26 15:32 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-08-26 15:32 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Arnd Bergmann, Jean-Christophe Plagniol-Villard, Wolfram Sang,
linux-fbdev, linux-kernel
A cleanup patch that removed some code left behind an unused
variable:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function 'mb862xx_i2c_init':
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: error: unused variable 'ret' [-Werror=unused-variable]
This removes that variable as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails")
---
drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d206857e3e..ba96c44f2761 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
int mb862xx_i2c_init(struct mb862xxfb_par *par)
{
- int ret;
-
mb862xx_i2c_adapter.algo_data = par;
par->adap = &mb862xx_i2c_adapter;
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: mb862xx: remove unused variable
@ 2016-08-26 15:32 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-08-26 15:32 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Arnd Bergmann, Jean-Christophe Plagniol-Villard, Wolfram Sang,
linux-fbdev, linux-kernel
A cleanup patch that removed some code left behind an unused
variable:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function 'mb862xx_i2c_init':
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: error: unused variable 'ret' [-Werror=unused-variable]
This removes that variable as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails")
---
drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d206857e3e..ba96c44f2761 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
int mb862xx_i2c_init(struct mb862xxfb_par *par)
{
- int ret;
-
mb862xx_i2c_adapter.algo_data = par;
par->adap = &mb862xx_i2c_adapter;
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: mb862xx: remove unused variable
2016-08-26 15:32 ` Arnd Bergmann
@ 2016-08-26 15:45 ` Wolfram Sang
-1 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-08-26 15:45 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tomi Valkeinen, Jean-Christophe Plagniol-Villard, Wolfram Sang,
linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Fri, Aug 26, 2016 at 05:32:33PM +0200, Arnd Bergmann wrote:
> A cleanup patch that removed some code left behind an unused
> variable:
>
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function 'mb862xx_i2c_init':
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: error: unused variable 'ret' [-Werror=unused-variable]
>
> This removes that variable as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails")
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Thanks! I already reworked my scripts to detect that better in the
future.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: mb862xx: remove unused variable
@ 2016-08-26 15:45 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-08-26 15:45 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tomi Valkeinen, Jean-Christophe Plagniol-Villard, Wolfram Sang,
linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Fri, Aug 26, 2016 at 05:32:33PM +0200, Arnd Bergmann wrote:
> A cleanup patch that removed some code left behind an unused
> variable:
>
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function 'mb862xx_i2c_init':
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: error: unused variable 'ret' [-Werror=unused-variable]
>
> This removes that variable as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails")
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Thanks! I already reworked my scripts to detect that better in the
future.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: mb862xx: remove unused variable 'ret'
2016-08-26 15:32 ` Arnd Bergmann
@ 2016-09-01 8:52 ` Colin King
-1 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2016-09-01 8:52 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Wolfram Sang,
linux-fbdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
ret is not being used, fixes warning:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning:
unused variable ‘ret’ [-Wunused-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d2068..ba96c44 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
int mb862xx_i2c_init(struct mb862xxfb_par *par)
{
- int ret;
-
mb862xx_i2c_adapter.algo_data = par;
par->adap = &mb862xx_i2c_adapter;
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: mb862xx: remove unused variable 'ret'
@ 2016-09-01 8:52 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2016-09-01 8:52 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Wolfram Sang,
linux-fbdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
ret is not being used, fixes warning:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning:
unused variable ‘ret’ [-Wunused-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d2068..ba96c44 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
int mb862xx_i2c_init(struct mb862xxfb_par *par)
{
- int ret;
-
mb862xx_i2c_adapter.algo_data = par;
par->adap = &mb862xx_i2c_adapter;
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-01 8:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-01 8:52 [PATCH] video: fbdev: mb862xx: remove unused variable 'ret' Colin King
2016-09-01 8:52 ` Colin King
-- strict thread matches above, loose matches on Subject: below --
2016-08-26 15:32 [PATCH] video: fbdev: mb862xx: remove unused variable Arnd Bergmann
2016-08-26 15:32 ` Arnd Bergmann
2016-08-26 15:45 ` Wolfram Sang
2016-08-26 15:45 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.