All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: mm: export set_memory_x and set_meory_nx
@ 2016-09-01  9:45 Jungseung Lee
  2016-09-01  9:56 ` Russell King - ARM Linux
  0 siblings, 1 reply; 2+ messages in thread
From: Jungseung Lee @ 2016-09-01  9:45 UTC (permalink / raw)
  To: linux-arm-kernel

This patch exports set_memory_x and set_memory_nx functions.
It is still allowed for modules to use these functions in other
architectures. In a similar manner to arm, export these functions.

Signed-off-by: Jungseung Lee <js07.lee@samsung.com>
---
 arch/arm/mm/pageattr.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mm/pageattr.c b/arch/arm/mm/pageattr.c
index d19b1ad..abf6695 100644
--- a/arch/arm/mm/pageattr.c
+++ b/arch/arm/mm/pageattr.c
@@ -88,6 +88,7 @@ int set_memory_nx(unsigned long addr, int numpages)
 					__pgprot(L_PTE_XN),
 					__pgprot(0));
 }
+EXPORT_SYMBOL_GPL(set_memory_nx);
 
 int set_memory_x(unsigned long addr, int numpages)
 {
@@ -95,3 +96,4 @@ int set_memory_x(unsigned long addr, int numpages)
 					__pgprot(0),
 					__pgprot(L_PTE_XN));
 }
+EXPORT_SYMBOL_GPL(set_memory_x);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] arm: mm: export set_memory_x and set_meory_nx
  2016-09-01  9:45 [PATCH] arm: mm: export set_memory_x and set_meory_nx Jungseung Lee
@ 2016-09-01  9:56 ` Russell King - ARM Linux
  0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2016-09-01  9:56 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 01, 2016 at 06:45:25PM +0900, Jungseung Lee wrote:
> This patch exports set_memory_x and set_memory_nx functions.
> It is still allowed for modules to use these functions in other
> architectures. In a similar manner to arm, export these functions.

They don't work on general kernel memory, so I'd much prefer that these
weren't exported.

I see no users of set_memory_nx() in modules.  There's one module that
uses set_memory_x(), which is drivers/watchdog/hpwdt.c.  The three users
of that are ifdef'd for x86 cases, and it's used on the result of
ioremapping, which will fail on ARMs implementation (which only allows
modules memory.)

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-01  9:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-01  9:45 [PATCH] arm: mm: export set_memory_x and set_meory_nx Jungseung Lee
2016-09-01  9:56 ` Russell King - ARM Linux

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.