From: Thierry Reding <thierry.reding@gmail.com> To: Lee Jones <lee.jones@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, patrice.chotard@st.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 07/17] pwm: sti: Rename channel => device Date: Mon, 5 Sep 2016 12:33:01 +0200 [thread overview] Message-ID: <20160905103301.GG31424@ulmo.ba.sec> (raw) In-Reply-To: <20160816093508.28307-8-lee.jones@linaro.org> [-- Attachment #1: Type: text/plain, Size: 1099 bytes --] On Tue, Aug 16, 2016 at 10:34:58AM +0100, Lee Jones wrote: > This is to bring the terminology used in the STi PWM driver more > into line with the PWM subsystem. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/pwm/pwm-sti.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) Note that it's fine if drivers use different terminology for internals. Many manuals seem to be using the channel terminology and many drivers use that. But if you prefer devices that's fine with me. I've applied this with a minor change, see below. > diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c [...] > - of_property_read_u32(np, "st,pwm-num-chan", &num_chan); > - if (num_chan) > - cdata->num_chan = num_chan; > + of_property_read_u32(np, "st,pwm-num-chans", &num_devs); > + if (num_devs) > + cdata->num_devs = num_devs; I kept the "st,pwm-num-chan" as property name here to avoid breaking backwards compatiblity. This series changes it back to "st,pwm-num-chan" sometime later in this series anyway. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 07/17] pwm: sti: Rename channel => device Date: Mon, 5 Sep 2016 12:33:01 +0200 [thread overview] Message-ID: <20160905103301.GG31424@ulmo.ba.sec> (raw) In-Reply-To: <20160816093508.28307-8-lee.jones@linaro.org> On Tue, Aug 16, 2016 at 10:34:58AM +0100, Lee Jones wrote: > This is to bring the terminology used in the STi PWM driver more > into line with the PWM subsystem. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/pwm/pwm-sti.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) Note that it's fine if drivers use different terminology for internals. Many manuals seem to be using the channel terminology and many drivers use that. But if you prefer devices that's fine with me. I've applied this with a minor change, see below. > diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c [...] > - of_property_read_u32(np, "st,pwm-num-chan", &num_chan); > - if (num_chan) > - cdata->num_chan = num_chan; > + of_property_read_u32(np, "st,pwm-num-chans", &num_devs); > + if (num_devs) > + cdata->num_devs = num_devs; I kept the "st,pwm-num-chan" as property name here to avoid breaking backwards compatiblity. This series changes it back to "st,pwm-num-chan" sometime later in this series anyway. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160905/ad659acd/attachment.sig>
next prev parent reply other threads:[~2016-09-05 10:33 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-16 9:34 [PATCH v4 00/17] pwm: Add support for PWM Capture Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` [PATCH v4 01/17] ARM: dts: STiH407: Supply PWM Capture IRQ Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` [PATCH v4 02/17] ARM: dts: STiH407: Declare PWM Capture data lines via Pinctrl Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` [PATCH v4 03/17] ARM: dts: STiH416: Supply PWM Capture IRQs Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` [PATCH v4 04/17] ARM: dts: STiH416: Declare PWM Capture data lines via Pinctrl Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` [PATCH v4 05/17] ARM: dts: STiH416: Define PWM Capture clock Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` [PATCH v4 06/17] ARM: dts: STiH416: Define the number of PWM Capture channels Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` [PATCH v4 07/17] pwm: sti: Rename channel => device Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-09-05 10:33 ` Thierry Reding [this message] 2016-09-05 10:33 ` Thierry Reding 2016-08-16 9:34 ` [PATCH v4 08/17] pwm: sti: Reorganise register names in preparation for new functionality Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-08-16 9:34 ` Lee Jones 2016-09-05 10:35 ` Thierry Reding 2016-09-05 10:35 ` Thierry Reding 2016-09-05 10:35 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 09/17] pwm: sti: Only request clock rate when you need to Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 10:36 ` Thierry Reding 2016-09-05 10:36 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 10/17] pwm: sti: Supply PWM Capture register addresses and bit locations Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 10:41 ` Thierry Reding 2016-09-05 10:41 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 11/17] pwm: sti: Supply PWM Capture clock handling Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 10:42 ` Thierry Reding 2016-09-05 10:42 ` Thierry Reding 2016-09-05 10:42 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 12/17] pwm: sti: Initialise PWM Capture device data Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 10:50 ` Thierry Reding 2016-09-05 10:50 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 13/17] pwm: sti: Add support for PWM Capture IRQs Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 10:53 ` Thierry Reding 2016-09-05 10:53 ` Thierry Reding 2016-09-05 10:53 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 14/17] pwm: sti: Add PWM Capture call-back Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 11:10 ` Thierry Reding 2016-09-05 11:10 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 15/17] pwm: sti: It's now valid for number of PWM channels to be zero Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 11:20 ` Thierry Reding 2016-09-05 11:20 ` Thierry Reding 2016-09-05 11:20 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 16/17] pwm: sti: Take the opportunity to conduct a little house keeping Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-09-05 11:37 ` Thierry Reding 2016-09-05 11:37 ` Thierry Reding 2016-08-16 9:35 ` [PATCH v4 17/17] dt-bindings: pwm: sti: Update DT bindings with recent changes Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-08-16 9:35 ` Lee Jones 2016-08-18 19:20 ` Rob Herring 2016-08-18 19:20 ` Rob Herring 2016-08-18 19:20 ` Rob Herring 2016-08-19 8:35 ` Lee Jones 2016-08-19 8:35 ` Lee Jones 2016-08-19 12:45 ` Rob Herring 2016-08-19 12:45 ` Rob Herring 2016-08-19 12:45 ` Rob Herring 2016-09-05 10:29 ` Thierry Reding 2016-09-05 10:29 ` Thierry Reding 2016-08-25 11:51 ` [STLinux Kernel] [PATCH v4 00/17] pwm: Add support for PWM Capture Peter Griffin 2016-08-25 11:51 ` Peter Griffin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160905103301.GG31424@ulmo.ba.sec \ --to=thierry.reding@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=kernel@stlinux.com \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=patrice.chotard@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.