All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Ashish Mittal <ashmit602@gmail.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com,
	armbru@redhat.com, berrange@redhat.com,
	ashish.mittal@veritas.com, stefanha@gmail.com,
	Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com
Subject: Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support
Date: Tue, 6 Sep 2016 18:09:07 +0800	[thread overview]
Message-ID: <20160906100907.GA10962@al.usersys.redhat.com> (raw)
In-Reply-To: <1471935390-126476-1-git-send-email-ashish.mittal@veritas.com>

On Mon, 08/22 23:56, Ashish Mittal wrote:
>  block/Makefile.objs |    2 +
>  block/trace-events  |   41 ++
>  block/vxhs.c        | 1304 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  block/vxhs.h        |  237 ++++++++++
>  configure           |   50 ++

If vxhs code is contained in one file, no need to add vxhs.h and all forward
declarations can go to vxhs.c. Then local functions can be marked as "static",
and all unused functions can be cleaned up.

Fam

      parent reply	other threads:[~2016-09-06 10:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  6:56 [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support Ashish Mittal
2016-08-30 17:35 ` Jeff Cody
2016-09-07 22:32   ` ashish mittal
2016-09-08  8:43     ` Kevin Wolf
2016-09-08  8:49       ` Daniel P. Berrange
2016-09-08  9:29         ` Kevin Wolf
2016-09-08  9:34           ` Daniel P. Berrange
2016-09-08 12:48             ` Jeff Cody
2016-09-08  9:43           ` Daniel P. Berrange
2016-09-08 10:18             ` Kevin Wolf
2016-09-08 10:23               ` Paolo Bonzini
2016-09-08 14:00     ` Jeff Cody
2016-09-08 14:20       ` [Qemu-devel] vxhs caching behaviour (was: [PATCH v4 RFC] block/vxhs: Initial commit to add) " Kevin Wolf
2016-09-08 20:46         ` ashish mittal
2016-09-09 10:38           ` Kevin Wolf
2016-09-08 23:15       ` [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add " ashish mittal
2016-09-21  6:39         ` ashish mittal
2016-09-06 10:09 ` Fam Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160906100907.GA10962@al.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=Abhijit.Dey@veritas.com \
    --cc=Ketan.Nilangekar@veritas.com \
    --cc=armbru@redhat.com \
    --cc=ashish.mittal@veritas.com \
    --cc=ashmit602@gmail.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.