All of lore.kernel.org
 help / color / mirror / Atom feed
* [pwm:for-4.9/drivers 2/9] drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'
@ 2016-09-05 10:37 kbuild test robot
  2016-09-06  5:35 ` Jisheng Zhang
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2016-09-05 10:37 UTC (permalink / raw)
  To: Jisheng Zhang; +Cc: kbuild-all, linux-pwm, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-4.9/drivers
head:   e63ed23775362a6e1a867dc2f75ebbf4e3a8d4d2
commit: fd47f104003c629d0ec6be4c2ead90191c184a23 [2/9] pwm: berlin: Add suspend/resume support
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout fd47f104003c629d0ec6be4c2ead90191c184a23
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

   drivers/pwm/pwm-berlin.c: In function 'berlin_pwm_suspend':
>> drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'
      channel = pwm_get_chip_data(&pwm->chips.pwms[i]);
                                      ^

vim +245 drivers/pwm/pwm-berlin.c

   239		struct berlin_pwm_chip *pwm = dev_get_drvdata(dev);
   240		unsigned int i;
   241	
   242		for (i = 0; i < pwm->chip.npwm; i++) {
   243			struct berlin_pwm_channel *channel;
   244	
 > 245			channel = pwm_get_chip_data(&pwm->chips.pwms[i]);
   246			if (!channel)
   247				continue;
   248	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 51348 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [pwm:for-4.9/drivers 2/9] drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'
  2016-09-05 10:37 [pwm:for-4.9/drivers 2/9] drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips' kbuild test robot
@ 2016-09-06  5:35 ` Jisheng Zhang
  2016-09-06  9:08   ` Thierry Reding
  0 siblings, 1 reply; 4+ messages in thread
From: Jisheng Zhang @ 2016-09-06  5:35 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, linux-pwm, Thierry Reding



On Mon, 5 Sep 2016 18:37:13 +0800 kbuild test robot  wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-4.9/drivers
> head:   e63ed23775362a6e1a867dc2f75ebbf4e3a8d4d2
> commit: fd47f104003c629d0ec6be4c2ead90191c184a23 [2/9] pwm: berlin: Add suspend/resume support
> config: arm64-allyesconfig (attached as .config)
> compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout fd47f104003c629d0ec6be4c2ead90191c184a23
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/pwm/pwm-berlin.c: In function 'berlin_pwm_suspend':
> >> drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'  
>       channel = pwm_get_chip_data(&pwm->chips.pwms[i]);
>                                       ^


Thanks for information. Below patch can fix it.

Hi Thierry,

a separate fix or amend the commit, which do you prefer?

Thanks,
Jisheng


8<----------------
diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c
index 31b2ee3..01339c1 100644
--- a/drivers/pwm/pwm-berlin.c
+++ b/drivers/pwm/pwm-berlin.c
@@ -242,7 +242,7 @@ static int berlin_pwm_suspend(struct device *dev)
 	for (i = 0; i < pwm->chip.npwm; i++) {
 		struct berlin_pwm_channel *channel;
 
-		channel = pwm_get_chip_data(&pwm->chips.pwms[i]);
+		channel = pwm_get_chip_data(&pwm->chip.pwms[i]);
 		if (!channel)
 			continue;
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [pwm:for-4.9/drivers 2/9] drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'
  2016-09-06  5:35 ` Jisheng Zhang
@ 2016-09-06  9:08   ` Thierry Reding
  2016-09-06  9:09     ` Jisheng Zhang
  0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2016-09-06  9:08 UTC (permalink / raw)
  To: Jisheng Zhang; +Cc: kbuild test robot, kbuild-all, linux-pwm

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]

On Tue, Sep 06, 2016 at 01:35:31PM +0800, Jisheng Zhang wrote:
> 
> 
> On Mon, 5 Sep 2016 18:37:13 +0800 kbuild test robot  wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-4.9/drivers
> > head:   e63ed23775362a6e1a867dc2f75ebbf4e3a8d4d2
> > commit: fd47f104003c629d0ec6be4c2ead90191c184a23 [2/9] pwm: berlin: Add suspend/resume support
> > config: arm64-allyesconfig (attached as .config)
> > compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout fd47f104003c629d0ec6be4c2ead90191c184a23
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=arm64 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/pwm/pwm-berlin.c: In function 'berlin_pwm_suspend':
> > >> drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'  
> >       channel = pwm_get_chip_data(&pwm->chips.pwms[i]);
> >                                       ^
> 
> 
> Thanks for information. Below patch can fix it.
> 
> Hi Thierry,
> 
> a separate fix or amend the commit, which do you prefer?

I've squashed the below change into the original patch.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [pwm:for-4.9/drivers 2/9] drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'
  2016-09-06  9:08   ` Thierry Reding
@ 2016-09-06  9:09     ` Jisheng Zhang
  0 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2016-09-06  9:09 UTC (permalink / raw)
  To: Thierry Reding; +Cc: kbuild test robot, kbuild-all, linux-pwm

On Tue, 6 Sep 2016 11:08:42 +0200 Thierry Reding wrote:

> On Tue, Sep 06, 2016 at 01:35:31PM +0800, Jisheng Zhang wrote:
> > 
> > 
> > On Mon, 5 Sep 2016 18:37:13 +0800 kbuild test robot  wrote:
> >   
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-4.9/drivers
> > > head:   e63ed23775362a6e1a867dc2f75ebbf4e3a8d4d2
> > > commit: fd47f104003c629d0ec6be4c2ead90191c184a23 [2/9] pwm: berlin: Add suspend/resume support
> > > config: arm64-allyesconfig (attached as .config)
> > > compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
> > > reproduce:
> > >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         git checkout fd47f104003c629d0ec6be4c2ead90191c184a23
> > >         # save the attached .config to linux build tree
> > >         make.cross ARCH=arm64 
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    drivers/pwm/pwm-berlin.c: In function 'berlin_pwm_suspend':  
> > > >> drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips'    
> > >       channel = pwm_get_chip_data(&pwm->chips.pwms[i]);
> > >                                       ^  
> > 
> > 
> > Thanks for information. Below patch can fix it.
> > 
> > Hi Thierry,
> > 
> > a separate fix or amend the commit, which do you prefer?  
> 
> I've squashed the below change into the original patch.
> 
> Thanks,
> Thierry

Thank you so much!

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-06  9:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05 10:37 [pwm:for-4.9/drivers 2/9] drivers/pwm/pwm-berlin.c:245:35: error: 'struct berlin_pwm_chip' has no member named 'chips' kbuild test robot
2016-09-06  5:35 ` Jisheng Zhang
2016-09-06  9:08   ` Thierry Reding
2016-09-06  9:09     ` Jisheng Zhang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.