Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

From: Fengguang Wu <lkp@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: chengang@emindsoft.com.cn, kbuild-all@01.org, minchan@kernel.org,
	vbabka@suse.cz, gi-oh.kim@profitbricks.com,
	iamjoonsoo.kim@lge.com, hillf.zj@alibaba-inc.com,
	mgorman@techsingularity.net, mhocko@suse.com,
	rientjes@google.com, linux-kernel@vger.kernel.org,
	rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
	vgupta@synopsys.com, linux@armlinux.org.uk,
	catalin.marinas@arm.com, will.deacon@arm.com,
	hskinnemoen@gmail.com, egtvedt@samfundet.no, realmz6@gmail.com,
	ysato@users.sourceforge.jp, rkuo@codeaurora.org,
	tony.luck@intel.com, fenghua.yu@intel.com, geert@linux-m68k.org,
	james.hogan@imgtec.com, ralf@linux-mips.org, dhowells@redhat.com,
	deller@gmx.de, benh@kernel.crashing.org, paulus@samba.org,
	mpe@ellerman.id.au, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com, dalias@libc.org, davem@davemloft.net,
	cmetcalf@mellanox.com, chris@zankel.net, jcmvbkbc@gmail.com,
	arnd@arndb.de, noamc@ezchip.com, brueckner@linux.vnet.ibm.com,
	mingo@kernel.org, peterz@infradead.org,
	linux-arch@vger.kernel.org, Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Date: Wed, 7 Sep 2016 09:52:19 +0800	[thread overview]
Message-ID: <20160907015219.4bk5ptcfyrosowwi@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <20160906122732.2086f1bcb1c3daa378e21d3b@linux-foundation.org>

Hi Andrew,

On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote:
>On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@intel.com> wrote:
>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.8-rc4 next-20160825]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
>> [Check https://git-scm.com/docs/git-format-patch for more information]
>>
>> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
>> config: s390-default_defconfig (attached as .config)
>> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=s390
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from include/linux/bitops.h:36:0,
>>                     from fs/btrfs/extent_io.c:1:
>> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>>     static inline bool
>>                   ^
>>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>>     static inline bool
>
>My s390 cross compiler doesn't like that config.  Can someone test this?

Tested-by: Fengguang Wu <fengguang.wu@intel.com>

It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc:

https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz

>--- a/arch/s390/include/asm/bitops.h~a
>+++ a/arch/s390/include/asm/bitops.h
>@@ -40,6 +40,7 @@
> #error only <linux/bitops.h> can be included directly
> #endif
>
>+#include <linux/types.h>
> #include <linux/typecheck.h>
> #include <linux/compiler.h>
> #include <asm/barrier.h>

Regards,
Fengguang