[sashal-linux-stable-security:linux-3.10.y-security 1083/1389] ipc/util.h:165:2: error: implicit declaration of function 'ipc_lock_object'

[sashal-linux-stable-security:linux-3.10.y-security 1083/1389] ipc/util.h:165:2: error: implicit declaration of function 'ipc_lock_object'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 5314 bytes --]

Hi Davidlohr,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable-security.git linux-3.10.y-security
head:   69c2f7bfd1c3f78cff79345a7d013684c2014325
commit: fd31c7f4ed3be2982187d1a43dfd557b75268503 [1083/1389] ipc: close open coded spin lock calls
config: i386-randconfig-s1-201636 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3
reproduce:
        git checkout fd31c7f4ed3be2982187d1a43dfd557b75268503
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from ipc/util.c:42:0:
   ipc/util.h: In function 'ipc_lock_by_ptr':
>> ipc/util.h:165:2: error: implicit declaration of function 'ipc_lock_object' [-Werror=implicit-function-declaration]
     ipc_lock_object(perm);
     ^
   ipc/util.h: In function 'ipc_unlock':
>> ipc/util.h:170:2: error: implicit declaration of function 'ipc_unlock_object' [-Werror=implicit-function-declaration]
     ipc_unlock_object(perm);
     ^
   ipc/util.h: At top level:
   ipc/util.h:174:20: warning: conflicting types for 'ipc_lock_object'
    static inline void ipc_lock_object(struct kern_ipc_perm *perm)
                       ^
>> ipc/util.h:174:20: error: static declaration of 'ipc_lock_object' follows non-static declaration
   ipc/util.h:165:2: note: previous implicit declaration of 'ipc_lock_object' was here
     ipc_lock_object(perm);
     ^
   cc1: some warnings being treated as errors
--
   In file included from ipc/sem.c:91:0:
   ipc/util.h: In function 'ipc_lock_by_ptr':
>> ipc/util.h:165:2: error: implicit declaration of function 'ipc_lock_object' [-Werror=implicit-function-declaration]
     ipc_lock_object(perm);
     ^
   ipc/util.h: In function 'ipc_unlock':
>> ipc/util.h:170:2: error: implicit declaration of function 'ipc_unlock_object' [-Werror=implicit-function-declaration]
     ipc_unlock_object(perm);
     ^
   ipc/util.h: At top level:
   ipc/util.h:174:20: warning: conflicting types for 'ipc_lock_object'
    static inline void ipc_lock_object(struct kern_ipc_perm *perm)
                       ^
>> ipc/util.h:174:20: error: static declaration of 'ipc_lock_object' follows non-static declaration
   ipc/util.h:165:2: note: previous implicit declaration of 'ipc_lock_object' was here
     ipc_lock_object(perm);
     ^
   ipc/sem.c: In function 'freeary':
>> ipc/sem.c:875:2: error: implicit declaration of function 'ipc_assert_locked_object' [-Werror=implicit-function-declaration]
     ipc_assert_locked_object(&sma->sem_perm);
     ^
   cc1: some warnings being treated as errors
--
   In file included from ipc/shm.c:48:0:
   ipc/util.h: In function 'ipc_lock_by_ptr':
>> ipc/util.h:165:2: error: implicit declaration of function 'ipc_lock_object' [-Werror=implicit-function-declaration]
     ipc_lock_object(perm);
     ^
   ipc/util.h: In function 'ipc_unlock':
>> ipc/util.h:170:2: error: implicit declaration of function 'ipc_unlock_object' [-Werror=implicit-function-declaration]
     ipc_unlock_object(perm);
     ^
   ipc/util.h: At top level:
   ipc/util.h:174:20: warning: conflicting types for 'ipc_lock_object'
    static inline void ipc_lock_object(struct kern_ipc_perm *perm)
                       ^
>> ipc/util.h:174:20: error: static declaration of 'ipc_lock_object' follows non-static declaration
   ipc/util.h:165:2: note: previous implicit declaration of 'ipc_lock_object' was here
     ipc_lock_object(perm);
     ^
   ipc/shm.c: In function 'shm_destroy':
   ipc/shm.c:206:22: error: 'shm_rcu_free' undeclared (first use in this function)
     ipc_rcu_putref(shp, shm_rcu_free);
                         ^
   ipc/shm.c:206:22: note: each undeclared identifier is reported only once for each function it appears in
   ipc/shm.c:206:2: error: too many arguments to function 'ipc_rcu_putref'
     ipc_rcu_putref(shp, shm_rcu_free);
     ^
   In file included from ipc/shm.c:48:0:
   ipc/util.h:123:6: note: declared here
    void ipc_rcu_putref(void *ptr);
         ^
   ipc/shm.c: In function 'SYSC_shmctl':
   ipc/shm.c:932:3: error: implicit declaration of function 'shm_obtain_object_check' [-Werror=implicit-function-declaration]
      shp = shm_obtain_object_check(ns, shmid);
      ^
   ipc/shm.c:932:7: warning: assignment makes pointer from integer without a cast
      shp = shm_obtain_object_check(ns, shmid);
          ^
   ipc/shm.c: In function 'do_shmat':
   ipc/shm.c:1065:6: warning: assignment makes pointer from integer without a cast
     shp = shm_obtain_object_check(ns, shmid);
         ^
   cc1: some warnings being treated as errors

vim +/ipc_lock_object +165 ipc/util.h

   159		return uid / SEQ_MULTIPLIER != ipcp->seq;
   160	}
   161	
   162	static inline void ipc_lock_by_ptr(struct kern_ipc_perm *perm)
   163	{
   164		rcu_read_lock();
 > 165		ipc_lock_object(perm);
   166	}
   167	
   168	static inline void ipc_unlock(struct kern_ipc_perm *perm)
   169	{
 > 170		ipc_unlock_object(perm);
   171		rcu_read_unlock();
   172	}
   173	
 > 174	static inline void ipc_lock_object(struct kern_ipc_perm *perm)
   175	{
   176		spin_lock(&perm->lock);
   177	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 21566 bytes --]