* [PATCH] thermal: cpu_cooling: Fix wrong comment call function name
@ 2016-09-07 0:35 Inhyuk Kang
2016-09-07 5:04 ` Viresh Kumar
2016-09-08 8:26 ` Javi Merino
0 siblings, 2 replies; 4+ messages in thread
From: Inhyuk Kang @ 2016-09-07 0:35 UTC (permalink / raw)
To: Viresh Kumar, Javi Merino; +Cc: amit.kachhap, hugh.kang, linux-kernel, linux-pm
The last_load is updated not cpufreq_get_actual_power() function call
but cpufreq_get_requested_power() function call.
Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index a32b417..9ce0e9e 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -74,7 +74,7 @@ struct power_table {
* cpufreq frequencies.
* @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
* @node: list_head to link all cpufreq_cooling_device together.
- * @last_load: load measured by the latest call to cpufreq_get_actual_power()
+ * @last_load: load measured by the latest call to cpufreq_get_requested_power()
* @time_in_idle: previous reading of the absolute time that this cpu was idle
* @time_in_idle_timestamp: wall time of the last invocation of
* get_cpu_idle_time_us()
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name
2016-09-07 0:35 [PATCH] thermal: cpu_cooling: Fix wrong comment call function name Inhyuk Kang
@ 2016-09-07 5:04 ` Viresh Kumar
2016-09-08 8:26 ` Javi Merino
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2016-09-07 5:04 UTC (permalink / raw)
To: Inhyuk Kang; +Cc: Javi Merino, amit.kachhap, linux-kernel, linux-pm
On 07-09-16, 09:35, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.
>
> Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
> * cpufreq frequencies.
> * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
> * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to cpufreq_get_requested_power()
> * @time_in_idle: previous reading of the absolute time that this cpu was idle
> * @time_in_idle_timestamp: wall time of the last invocation of
> * get_cpu_idle_time_us()
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name
2016-09-07 0:35 [PATCH] thermal: cpu_cooling: Fix wrong comment call function name Inhyuk Kang
2016-09-07 5:04 ` Viresh Kumar
@ 2016-09-08 8:26 ` Javi Merino
2016-09-19 0:12 ` 강인혁/책임연구원/SW Platform(연)AOT팀(hugh.kang@lge.com)
1 sibling, 1 reply; 4+ messages in thread
From: Javi Merino @ 2016-09-08 8:26 UTC (permalink / raw)
To: Inhyuk Kang
Cc: Viresh Kumar, amit.kachhap, linux-kernel, linux-pm,
Eduardo Valentin, Rui Zhang
On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.
Yep, my bad. Thanks for fixing it!
> Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
Acked-by: Javi Merino <javi.merino@arm.com>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
> * cpufreq frequencies.
> * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
> * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to cpufreq_get_requested_power()
> * @time_in_idle: previous reading of the absolute time that this cpu was idle
> * @time_in_idle_timestamp: wall time of the last invocation of
> * get_cpu_idle_time_us()
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name
2016-09-08 8:26 ` Javi Merino
@ 2016-09-19 0:12 ` 강인혁/책임연구원/SW Platform(연)AOT팀(hugh.kang@lge.com)
0 siblings, 0 replies; 4+ messages in thread
From: 강인혁/책임연구원/SW Platform(연)AOT팀(hugh.kang@lge.com) @ 2016-09-19 0:12 UTC (permalink / raw)
To: Javi Merino,
강인혁/책임연구원/SW
Platform(연)AOT팀(hugh.kang@lge.com)
Cc: Viresh Kumar, amit.kachhap, linux-kernel, linux-pm,
Eduardo Valentin, Rui Zhang,
정찬균/수석연구원/SW
Platform(연)AOT팀(chan.jeong@lge.com)
(chan.jeong@lge.com)
You're welcome. Will be merged this patch?
Thank you
Hugh Kang
No One ever is defeated until defeat has been accepted as a reality.
강인혁 (Hugh Kang) Chief Engineer
SW Platform(연) Advanced OS Technology TEAM (AOT)
Mobile: +82-10-5513-7957
-----Original Message-----
From: Javi Merino [mailto:javi.merino@arm.com]
Sent: Thursday, September 08, 2016 5:26 PM
To: Inhyuk Kang
Cc: Viresh Kumar; amit.kachhap@gmail.com; linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; Eduardo Valentin; Rui Zhang
Subject: Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name
On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.
Yep, my bad. Thanks for fixing it!
> Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
Acked-by: Javi Merino <javi.merino@arm.com>
> diff --git a/drivers/thermal/cpu_cooling.c
> b/drivers/thermal/cpu_cooling.c index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
> * cpufreq frequencies.
> * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
> * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to
> cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to
> + cpufreq_get_requested_power()
> * @time_in_idle: previous reading of the absolute time that this cpu was idle
> * @time_in_idle_timestamp: wall time of the last invocation of
> * get_cpu_idle_time_us()
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-19 0:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-07 0:35 [PATCH] thermal: cpu_cooling: Fix wrong comment call function name Inhyuk Kang
2016-09-07 5:04 ` Viresh Kumar
2016-09-08 8:26 ` Javi Merino
2016-09-19 0:12 ` 강인혁/책임연구원/SW Platform(연)AOT팀(hugh.kang@lge.com)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.