All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Fix fastboot boot address
@ 2016-09-08 20:51 Peter.Chubb at data61.csiro.au
  2016-09-08 21:07 ` Tom Rini
  0 siblings, 1 reply; 3+ messages in thread
From: Peter.Chubb at data61.csiro.au @ 2016-09-08 20:51 UTC (permalink / raw)
  To: u-boot

Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently
tells do_bootm() to look for an image at $loadaddr.  This breaks if
CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set
loadaddr.

Instead, tell do_bootm() to pick up the image where it was laoded.

Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
---
 drivers/usb/gadget/f_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
index 2160b1c..6d02248 100644
--- a/drivers/usb/gadget/f_fastboot.c
+++ b/drivers/usb/gadget/f_fastboot.c
@@ -553,7 +553,7 @@ static void do_bootm_on_complete(struct usb_ep *ep, struct usb_request *req)
 
 	puts("Booting kernel..\n");
 
-	sprintf(boot_addr_start, "0x%lx", load_addr);
+	sprintf(boot_addr_start, "0x%lx", CONFIG_FASTBOOT_BUF_ADDR);
 	do_bootm(NULL, 0, 2, bootm_args);
 
 	/* This only happens if image is somehow faulty so we start over */
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] Fix fastboot boot address
  2016-09-08 20:51 [U-Boot] [PATCH] Fix fastboot boot address Peter.Chubb at data61.csiro.au
@ 2016-09-08 21:07 ` Tom Rini
  2016-12-30 21:27   ` Steve Rae
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2016-09-08 21:07 UTC (permalink / raw)
  To: u-boot

On Thu, Sep 08, 2016 at 08:51:57PM +0000, Peter.Chubb at data61.csiro.au wrote:

> Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently
> tells do_bootm() to look for an image at $loadaddr.  This breaks if
> CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set
> loadaddr.
> 
> Instead, tell do_bootm() to pick up the image where it was laoded.
> 
> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160908/e62de0ca/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] Fix fastboot boot address
  2016-09-08 21:07 ` Tom Rini
@ 2016-12-30 21:27   ` Steve Rae
  0 siblings, 0 replies; 3+ messages in thread
From: Steve Rae @ 2016-12-30 21:27 UTC (permalink / raw)
  To: u-boot

On Thu, Sep 8, 2016 at 2:07 PM, Tom Rini <trini@konsulko.com> wrote:
> On Thu, Sep 08, 2016 at 08:51:57PM +0000, Peter.Chubb at data61.csiro.au wrote:
>
>> Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently
>> tells do_bootm() to look for an image at $loadaddr.  This breaks if
>> CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set
>> loadaddr.
>>
>> Instead, tell do_bootm() to pick up the image where it was laoded.
>>
>> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> --
> Tom
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Acked-by: Steve Rae <steve.rae@raedomain.com>

Thanks, Steve

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-30 21:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08 20:51 [U-Boot] [PATCH] Fix fastboot boot address Peter.Chubb at data61.csiro.au
2016-09-08 21:07 ` Tom Rini
2016-12-30 21:27   ` Steve Rae

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.