From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> To: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org> Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>, linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org Subject: Re: [PATCH 06/10] dax: provide an iomap based fault handler Date: Sat, 10 Sep 2016 09:36:46 +0200 [thread overview] Message-ID: <20160910073646.GA18547@lst.de> (raw) In-Reply-To: <20160909225557.GF30056@dastard> On Sat, Sep 10, 2016 at 08:55:57AM +1000, Dave Chinner wrote: > THe errors from the above two cases are not acted on. they are > immediately overwritten by: Yes, Robert also pointed this out. Fix below. > Is there a missing "if (error) goto out;" check somewhere here? Just the one above. > I'm also wondering if you've looked at supporting the PMD fault case > with iomap? PMD faults currently don't work at all. Ross has a series to resurrect them, but we'll need to coordinate between the two series somehow. My preference would be to not resurrect them for the bh path and only do it for the iomap version. diff --git a/fs/dax.c b/fs/dax.c index a170a94..5534594 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1440,6 +1440,7 @@ int iomap_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf, default: WARN_ON_ONCE(1); error = -EIO; + goto unlock_entry; } /* Filesystem should not return unwritten buffers to us! */
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Dave Chinner <david@fromorbit.com> Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org, elliott@hpe.com Subject: Re: [PATCH 06/10] dax: provide an iomap based fault handler Date: Sat, 10 Sep 2016 09:36:46 +0200 [thread overview] Message-ID: <20160910073646.GA18547@lst.de> (raw) In-Reply-To: <20160909225557.GF30056@dastard> On Sat, Sep 10, 2016 at 08:55:57AM +1000, Dave Chinner wrote: > THe errors from the above two cases are not acted on. they are > immediately overwritten by: Yes, Robert also pointed this out. Fix below. > Is there a missing "if (error) goto out;" check somewhere here? Just the one above. > I'm also wondering if you've looked at supporting the PMD fault case > with iomap? PMD faults currently don't work at all. Ross has a series to resurrect them, but we'll need to coordinate between the two series somehow. My preference would be to not resurrect them for the bh path and only do it for the iomap version. diff --git a/fs/dax.c b/fs/dax.c index a170a94..5534594 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1440,6 +1440,7 @@ int iomap_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf, default: WARN_ON_ONCE(1); error = -EIO; + goto unlock_entry; } /* Filesystem should not return unwritten buffers to us! */
next prev parent reply other threads:[~2016-09-10 7:36 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-09 16:34 iomap based DAX path Christoph Hellwig [not found] ` <1473438884-674-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2016-09-09 16:34 ` [PATCH 01/10] iomap: add IOMAP_F_NEW flag Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig [not found] ` <1473438884-674-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2016-09-13 22:43 ` Ross Zwisler 2016-09-13 22:43 ` Ross Zwisler 2016-09-14 7:08 ` Christoph Hellwig 2016-09-09 16:34 ` [PATCH 02/10] iomap: expose iomap_apply outside iomap.c Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig [not found] ` <1473438884-674-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2016-09-13 22:48 ` Ross Zwisler 2016-09-13 22:48 ` Ross Zwisler 2016-09-09 16:34 ` [PATCH 03/10] dax: don't pass buffer_head to dax_insert_mapping Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig [not found] ` <1473438884-674-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2016-09-13 22:53 ` Ross Zwisler 2016-09-13 22:53 ` Ross Zwisler 2016-09-09 16:34 ` [PATCH 04/10] dax: don't pass buffer_head to copy_user_dax Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig 2016-09-13 22:54 ` Ross Zwisler 2016-09-09 16:34 ` [PATCH 05/10] dax: provide an iomap based dax read/write path Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig [not found] ` <1473438884-674-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2016-09-13 23:00 ` Ross Zwisler 2016-09-13 23:00 ` Ross Zwisler 2016-09-09 16:34 ` [PATCH 06/10] dax: provide an iomap based fault handler Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig [not found] ` <1473438884-674-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2016-09-09 22:55 ` Dave Chinner 2016-09-09 22:55 ` Dave Chinner 2016-09-10 7:36 ` Christoph Hellwig [this message] 2016-09-10 7:36 ` Christoph Hellwig 2016-09-13 15:51 ` Ross Zwisler [not found] ` <20160913155126.GA10622-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2016-09-14 7:06 ` Christoph Hellwig 2016-09-14 7:06 ` Christoph Hellwig [not found] ` <20160914070633.GA17278-jcswGhMUV9g@public.gmane.org> 2016-09-14 9:53 ` Christoph Hellwig 2016-09-14 9:53 ` Christoph Hellwig 2016-09-23 21:02 ` Ross Zwisler 2016-09-23 21:02 ` Ross Zwisler [not found] ` <20160923210237.GA23346-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2016-09-26 0:08 ` Christoph Hellwig 2016-09-26 0:08 ` Christoph Hellwig [not found] ` <20160926000805.GA32252-jcswGhMUV9g@public.gmane.org> 2016-09-26 14:28 ` Jan Kara 2016-09-26 14:28 ` Jan Kara 2016-09-10 1:38 ` Elliott, Robert (Persistent Memory) 2016-09-10 1:38 ` Elliott, Robert (Persistent Memory) 2016-09-13 23:10 ` Ross Zwisler [not found] ` <20160913231039.GF26002-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2016-09-14 7:19 ` Christoph Hellwig 2016-09-14 7:19 ` Christoph Hellwig [not found] ` <20160914071910.GC17278-jcswGhMUV9g@public.gmane.org> 2016-09-14 17:07 ` Ross Zwisler 2016-09-14 17:07 ` Ross Zwisler [not found] ` <20160914170759.GA14196-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2016-09-15 5:12 ` Christoph Hellwig 2016-09-15 5:12 ` Christoph Hellwig [not found] ` <20160915051229.GD6188-jcswGhMUV9g@public.gmane.org> 2016-09-15 5:30 ` Darrick J. Wong 2016-09-15 5:30 ` Darrick J. Wong 2016-09-26 0:05 ` Christoph Hellwig 2016-09-09 16:34 ` [PATCH 07/10] xfs: fix locking for DAX writes Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig 2016-09-09 16:34 ` [PATCH 08/10] xfs: take the ilock shared if possible in xfs_file_iomap_begin Christoph Hellwig 2016-09-09 16:34 ` Christoph Hellwig 2016-09-09 16:34 ` [PATCH 09/10] xfs: refactor xfs_setfilesize Christoph Hellwig [not found] ` <1473438884-674-10-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2016-09-13 23:12 ` Ross Zwisler 2016-09-13 23:12 ` Ross Zwisler 2016-09-09 16:34 ` [PATCH 10/10] xfs: use iomap to implement DAX Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160910073646.GA18547@lst.de \ --to=hch-jcswghmuv9g@public.gmane.org \ --cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \ --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \ --cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.