* Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree
@ 2016-09-09 13:38 gregkh
[not found] ` <E2E442CB-5C49-400E-9E0E-852AADACF179@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: gregkh @ 2016-09-09 13:38 UTC (permalink / raw)
To: xerofoify, alexander.levin, gregkh, martin.petersen, sumit.saxena
Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
[PATCH 062/135] megaraid: Fix possible NULL pointer deference in
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00 2001
From: Nicholas Krause <xerofoify@gmail.com>
Date: Tue, 5 Jan 2016 14:32:54 -0500
Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer deference in
mraid_mm_ioctl
[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
This adds the needed check after the call to the function
mraid_mm_alloc_kioc in order to make sure that this function has not
returned NULL and therefore makes sure we do not deference a NULL
pointer if one is returned by mraid_mm_alloc_kioc. Further more add
needed comments explaining that this function call can return NULL if
the list head is empty for the pointer passed in order to allow furture
users to understand this required pointer check.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/drivers/scsi/megaraid/megaraid_mm.c
+++ b/drivers/scsi/megaraid/megaraid_mm.c
@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
/*
* The following call will block till a kioc is available
+ * or return NULL if the list head is empty for the pointer
+ * of type mraid_mmapt passed to mraid_mm_alloc_kioc
*/
kioc = mraid_mm_alloc_kioc(adp);
+ if (!kioc)
+ return -ENXIO;
/*
* User sent the old mimd_t ioctl packet. Convert it to uioc_t.
Patches currently in stable-queue which might be from xerofoify@gmail.com are
queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree
[not found] ` <E2E442CB-5C49-400E-9E0E-852AADACF179@gmail.com>
@ 2016-09-10 8:15 ` Greg KH
[not found] ` <13EEF8FE-318F-4C2D-ABDF-A92B2D3B19D4@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-09-10 8:15 UTC (permalink / raw)
To: Nicholas Krause
Cc: alexander.levin, martin.petersen, sumit.saxena, stable, stable-commits
On Fri, Sep 09, 2016 at 01:08:36PM -0400, Nicholas Krause wrote:
>
>
> On September 9, 2016 9:38:13 AM EDT, gregkh@linuxfoundation.org wrote:
> >
> >This is a note to let you know that I've just added the patch titled
> >
> > [PATCH 062/135] megaraid: Fix possible NULL pointer deference in
> >
> >to the 4.4-stable tree which can be found at:
> >http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> >The filename of the patch is:
> > 0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >and it can be found in the queue-4.4 subdirectory.
> >
> >If you, or anyone else, feels it should not be added to the stable
> >tree,
> >please let <stable@vger.kernel.org> know about it.
> >
> >
> >From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00 2001
> >From: Nicholas Krause <xerofoify@gmail.com>
> >Date: Tue, 5 Jan 2016 14:32:54 -0500
> >Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer deference
> >in
> > mraid_mm_ioctl
> >
> >[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
> >
> >This adds the needed check after the call to the function
> >mraid_mm_alloc_kioc in order to make sure that this function has not
> >returned NULL and therefore makes sure we do not deference a NULL
> >pointer if one is returned by mraid_mm_alloc_kioc. Further more add
> >needed comments explaining that this function call can return NULL if
> >the list head is empty for the pointer passed in order to allow furture
> >users to understand this required pointer check.
> >
> >Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
> >Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> >Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> >Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >---
> > drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >--- a/drivers/scsi/megaraid/megaraid_mm.c
> >+++ b/drivers/scsi/megaraid/megaraid_mm.c
> >@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
> >
> > /*
> > * The following call will block till a kioc is available
> >+ * or return NULL if the list head is empty for the pointer
> >+ * of type mraid_mmapt passed to mraid_mm_alloc_kioc
> > */
> > kioc = mraid_mm_alloc_kioc(adp);
> >+ if (!kioc)
> >+ return -ENXIO;
> >
> > /*
> > * User sent the old mimd_t ioctl packet. Convert it to uioc_t.
> >
> >
> >Patches currently in stable-queue which might be from
> >xerofoify@gmail.com are
> >
> >queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> I do not wish any of my work to
> touch the stable kernel tree.
Hahaha, sure, gladly deleted, too funny...
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree
[not found] ` <13EEF8FE-318F-4C2D-ABDF-A92B2D3B19D4@gmail.com>
@ 2016-09-10 15:15 ` Greg KH
[not found] ` <31bbff7b-a07c-6dbc-2ef1-6693f27d18a8@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-09-10 15:15 UTC (permalink / raw)
To: Nicholas Krause
Cc: alexander.levin, martin.petersen, sumit.saxena, stable, stable-commits
On Sat, Sep 10, 2016 at 10:53:01AM -0400, Nicholas Krause wrote:
>
>
> On September 10, 2016 4:15:05 AM EDT, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Fri, Sep 09, 2016 at 01:08:36PM -0400, Nicholas Krause wrote:
> >>
> >>
> >> On September 9, 2016 9:38:13 AM EDT, gregkh@linuxfoundation.org
> >wrote:
> >> >
> >> >This is a note to let you know that I've just added the patch titled
> >> >
> >> > [PATCH 062/135] megaraid: Fix possible NULL pointer deference in
> >> >
> >> >to the 4.4-stable tree which can be found at:
> >>
> >>http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >> >
> >> >The filename of the patch is:
> >> > 0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >> >and it can be found in the queue-4.4 subdirectory.
> >> >
> >> >If you, or anyone else, feels it should not be added to the stable
> >> >tree,
> >> >please let <stable@vger.kernel.org> know about it.
> >> >
> >> >
> >> >From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00
> >2001
> >> >From: Nicholas Krause <xerofoify@gmail.com>
> >> >Date: Tue, 5 Jan 2016 14:32:54 -0500
> >> >Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
> >deference
> >> >in
> >> > mraid_mm_ioctl
> >> >
> >> >[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
> >> >
> >> >This adds the needed check after the call to the function
> >> >mraid_mm_alloc_kioc in order to make sure that this function has not
> >> >returned NULL and therefore makes sure we do not deference a NULL
> >> >pointer if one is returned by mraid_mm_alloc_kioc. Further more add
> >> >needed comments explaining that this function call can return NULL
> >if
> >> >the list head is empty for the pointer passed in order to allow
> >furture
> >> >users to understand this required pointer check.
> >> >
> >> >Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> >Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
> >> >Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> >> >Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> >> >Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> >---
> >> > drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
> >> > 1 file changed, 4 insertions(+)
> >> >
> >> >--- a/drivers/scsi/megaraid/megaraid_mm.c
> >> >+++ b/drivers/scsi/megaraid/megaraid_mm.c
> >> >@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
> >> >
> >> > /*
> >> > * The following call will block till a kioc is available
> >> >+ * or return NULL if the list head is empty for the pointer
> >> >+ * of type mraid_mmapt passed to mraid_mm_alloc_kioc
> >> > */
> >> > kioc = mraid_mm_alloc_kioc(adp);
> >> >+ if (!kioc)
> >> >+ return -ENXIO;
> >> >
> >> > /*
> >> > * User sent the old mimd_t ioctl packet. Convert it to uioc_t.
> >> >
> >> >
> >> >Patches currently in stable-queue which might be from
> >> >xerofoify@gmail.com are
> >> >
> >>
> >>queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >> I do not wish any of my work to
> >> touch the stable kernel tree.
> >
> >Hahaha, sure, gladly deleted, too funny...
> >
> >greg k-h
> On top of that please revert the regression fix. That is also my
> work and therefore shouldn't be touching the stable tree either.
What exactly are you referring to?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree
[not found] ` <31bbff7b-a07c-6dbc-2ef1-6693f27d18a8@gmail.com>
@ 2016-09-10 15:49 ` Greg KH
[not found] ` <9353EE1A-4103-4178-9D19-CDE5E96EE1CB@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-09-10 15:49 UTC (permalink / raw)
To: nick
Cc: alexander.levin, martin.petersen, sumit.saxena, stable, stable-commits
On Sat, Sep 10, 2016 at 11:33:41AM -0400, nick wrote:
>
>
> On 2016-09-10 11:15 AM, Greg KH wrote:
> > On Sat, Sep 10, 2016 at 10:53:01AM -0400, Nicholas Krause wrote:
> >>
> >>
> >> On September 10, 2016 4:15:05 AM EDT, Greg KH <gregkh@linuxfoundation.org> wrote:
> >>> On Fri, Sep 09, 2016 at 01:08:36PM -0400, Nicholas Krause wrote:
> >>>>
> >>>>
> >>>> On September 9, 2016 9:38:13 AM EDT, gregkh@linuxfoundation.org
> >>> wrote:
> >>>>>
> >>>>> This is a note to let you know that I've just added the patch titled
> >>>>>
> >>>>> [PATCH 062/135] megaraid: Fix possible NULL pointer deference in
> >>>>>
> >>>>> to the 4.4-stable tree which can be found at:
> >>>>
> >>>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >>>>>
> >>>>> The filename of the patch is:
> >>>>> 0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >>>>> and it can be found in the queue-4.4 subdirectory.
> >>>>>
> >>>>> If you, or anyone else, feels it should not be added to the stable
> >>>>> tree,
> >>>>> please let <stable@vger.kernel.org> know about it.
> >>>>>
> >>>>>
> >>>> >From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00
> >>> 2001
> >>>>> From: Nicholas Krause <xerofoify@gmail.com>
> >>>>> Date: Tue, 5 Jan 2016 14:32:54 -0500
> >>>>> Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
> >>> deference
> >>>>> in
> >>>>> mraid_mm_ioctl
> >>>>>
> >>>>> [ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
> >>>>>
> >>>>> This adds the needed check after the call to the function
> >>>>> mraid_mm_alloc_kioc in order to make sure that this function has not
> >>>>> returned NULL and therefore makes sure we do not deference a NULL
> >>>>> pointer if one is returned by mraid_mm_alloc_kioc. Further more add
> >>>>> needed comments explaining that this function call can return NULL
> >>> if
> >>>>> the list head is empty for the pointer passed in order to allow
> >>> furture
> >>>>> users to understand this required pointer check.
> >>>>>
> >>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >>>>> Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
> >>>>> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> >>>>> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> >>>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>>>> ---
> >>>>> drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
> >>>>> 1 file changed, 4 insertions(+)
> >>>>>
> >>>>> --- a/drivers/scsi/megaraid/megaraid_mm.c
> >>>>> +++ b/drivers/scsi/megaraid/megaraid_mm.c
> >>>>> @@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
> >>>>>
> >>>>> /*
> >>>>> * The following call will block till a kioc is available
> >>>>> + * or return NULL if the list head is empty for the pointer
> >>>>> + * of type mraid_mmapt passed to mraid_mm_alloc_kioc
> >>>>> */
> >>>>> kioc = mraid_mm_alloc_kioc(adp);
> >>>>> + if (!kioc)
> >>>>> + return -ENXIO;
> >>>>>
> >>>>> /*
> >>>>> * User sent the old mimd_t ioctl packet. Convert it to uioc_t.
> >>>>>
> >>>>>
> >>>>> Patches currently in stable-queue which might be from
> >>>>> xerofoify@gmail.com are
> >>>>>
> >>>>
> >>>> queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >>>> I do not wish any of my work to
> >>>> touch the stable kernel tree.
> >>>
> >>> Hahaha, sure, gladly deleted, too funny...
> >>>
> >>> greg k-h
> >> On top of that please revert the regression fix. That is also my
> >> work and therefore shouldn't be touching the stable tree either.
> >
> > What exactly are you referring to?
> >
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=fbedcaf43fba35677c01a4ae51e6f79edf4049ba
> This commit I want removed from stable as I refuse to have any of my work in the stable tree for now.
Please learn a bit more about git, and how this specific commit isn't in
a "stable tree" before saying stuff like this, there is nothing to do,
unless you want us to revert your changes entirely (and even then, you
can't rewrite history...)
sorry,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree
[not found] ` <9353EE1A-4103-4178-9D19-CDE5E96EE1CB@gmail.com>
@ 2016-09-10 16:05 ` Greg KH
[not found] ` <AF41C82E-0461-41E3-B35B-37C992517E68@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-09-10 16:05 UTC (permalink / raw)
To: Nicholas Krause
Cc: alexander.levin, martin.petersen, sumit.saxena, stable, stable-commits
On Sat, Sep 10, 2016 at 11:53:30AM -0400, Nicholas Krause wrote:
>
>
> On September 10, 2016 11:49:03 AM EDT, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Sat, Sep 10, 2016 at 11:33:41AM -0400, nick wrote:
> >>
> >>
> >> On 2016-09-10 11:15 AM, Greg KH wrote:
> >> > On Sat, Sep 10, 2016 at 10:53:01AM -0400, Nicholas Krause wrote:
> >> >>
> >> >>
> >> >> On September 10, 2016 4:15:05 AM EDT, Greg KH
> ><gregkh@linuxfoundation.org> wrote:
> >> >>> On Fri, Sep 09, 2016 at 01:08:36PM -0400, Nicholas Krause wrote:
> >> >>>>
> >> >>>>
> >> >>>> On September 9, 2016 9:38:13 AM EDT, gregkh@linuxfoundation.org
> >> >>> wrote:
> >> >>>>>
> >> >>>>> This is a note to let you know that I've just added the patch
> >titled
> >> >>>>>
> >> >>>>> [PATCH 062/135] megaraid: Fix possible NULL pointer
> >deference in
> >> >>>>>
> >> >>>>> to the 4.4-stable tree which can be found at:
> >> >>>>
> >> >>>>
> >http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >> >>>>>
> >> >>>>> The filename of the patch is:
> >> >>>>>
> >0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >> >>>>> and it can be found in the queue-4.4 subdirectory.
> >> >>>>>
> >> >>>>> If you, or anyone else, feels it should not be added to the
> >stable
> >> >>>>> tree,
> >> >>>>> please let <stable@vger.kernel.org> know about it.
> >> >>>>>
> >> >>>>>
> >> >>>> >From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17
> >00:00:00
> >> >>> 2001
> >> >>>>> From: Nicholas Krause <xerofoify@gmail.com>
> >> >>>>> Date: Tue, 5 Jan 2016 14:32:54 -0500
> >> >>>>> Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
> >> >>> deference
> >> >>>>> in
> >> >>>>> mraid_mm_ioctl
> >> >>>>>
> >> >>>>> [ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
> >> >>>>>
> >> >>>>> This adds the needed check after the call to the function
> >> >>>>> mraid_mm_alloc_kioc in order to make sure that this function
> >has not
> >> >>>>> returned NULL and therefore makes sure we do not deference a
> >NULL
> >> >>>>> pointer if one is returned by mraid_mm_alloc_kioc. Further
> >more add
> >> >>>>> needed comments explaining that this function call can return
> >NULL
> >> >>> if
> >> >>>>> the list head is empty for the pointer passed in order to allow
> >> >>> furture
> >> >>>>> users to understand this required pointer check.
> >> >>>>>
> >> >>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> >>>>> Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
> >> >>>>> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> >> >>>>> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> >> >>>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> >>>>> ---
> >> >>>>> drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
> >> >>>>> 1 file changed, 4 insertions(+)
> >> >>>>>
> >> >>>>> --- a/drivers/scsi/megaraid/megaraid_mm.c
> >> >>>>> +++ b/drivers/scsi/megaraid/megaraid_mm.c
> >> >>>>> @@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
> >> >>>>>
> >> >>>>> /*
> >> >>>>> * The following call will block till a kioc is available
> >> >>>>> + * or return NULL if the list head is empty for the pointer
> >> >>>>> + * of type mraid_mmapt passed to mraid_mm_alloc_kioc
> >> >>>>> */
> >> >>>>> kioc = mraid_mm_alloc_kioc(adp);
> >> >>>>> + if (!kioc)
> >> >>>>> + return -ENXIO;
> >> >>>>>
> >> >>>>> /*
> >> >>>>> * User sent the old mimd_t ioctl packet. Convert it to
> >uioc_t.
> >> >>>>>
> >> >>>>>
> >> >>>>> Patches currently in stable-queue which might be from
> >> >>>>> xerofoify@gmail.com are
> >> >>>>>
> >> >>>>
> >> >>>>
> >queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >> >>>> I do not wish any of my work to
> >> >>>> touch the stable kernel tree.
> >> >>>
> >> >>> Hahaha, sure, gladly deleted, too funny...
> >> >>>
> >> >>> greg k-h
> >> >> On top of that please revert the regression fix. That is also my
> >> >> work and therefore shouldn't be touching the stable tree either.
> >> >
> >> > What exactly are you referring to?
> >> >
> >>
> >https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=fbedcaf43fba35677c01a4ae51e6f79edf4049ba
> >> This commit I want removed from stable as I refuse to have any of my
> >work in the stable tree for now.
> >
> >Please learn a bit more about git, and how this specific commit isn't
> >in
> >a "stable tree" before saying stuff like this, there is nothing to do,
> >unless you want us to revert your changes entirely (and even then, you
> >can't rewrite history...)
> >
> >sorry,
> >
> >greg k-h
> Then revert it from all git trees then.
Please define "all git trees".
And once you send in a patch, you sometimes don't have a say in where it
ends up, sorry, that's just how open source development works :)
best of luck!
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree
[not found] ` <AF41C82E-0461-41E3-B35B-37C992517E68@gmail.com>
@ 2016-09-11 7:22 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2016-09-11 7:22 UTC (permalink / raw)
To: Nicholas Krause
Cc: alexander.levin, martin.petersen, sumit.saxena, stable, stable-commits
On Sat, Sep 10, 2016 at 08:03:58PM -0400, Nicholas Krause wrote:
>
>
> On September 10, 2016 12:05:57 PM EDT, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Sat, Sep 10, 2016 at 11:53:30AM -0400, Nicholas Krause wrote:
> >>
> >>
> >> On September 10, 2016 11:49:03 AM EDT, Greg KH
> ><gregkh@linuxfoundation.org> wrote:
> >> >On Sat, Sep 10, 2016 at 11:33:41AM -0400, nick wrote:
> >> >>
> >> >>
> >> >> On 2016-09-10 11:15 AM, Greg KH wrote:
> >> >> > On Sat, Sep 10, 2016 at 10:53:01AM -0400, Nicholas Krause wrote:
> >> >> >>
> >> >> >>
> >> >> >> On September 10, 2016 4:15:05 AM EDT, Greg KH
> >> ><gregkh@linuxfoundation.org> wrote:
> >> >> >>> On Fri, Sep 09, 2016 at 01:08:36PM -0400, Nicholas Krause
> >wrote:
> >> >> >>>>
> >> >> >>>>
> >> >> >>>> On September 9, 2016 9:38:13 AM EDT,
> >gregkh@linuxfoundation.org
> >> >> >>> wrote:
> >> >> >>>>>
> >> >> >>>>> This is a note to let you know that I've just added the
> >patch
> >> >titled
> >> >> >>>>>
> >> >> >>>>> [PATCH 062/135] megaraid: Fix possible NULL pointer
> >> >deference in
> >> >> >>>>>
> >> >> >>>>> to the 4.4-stable tree which can be found at:
> >> >> >>>>
> >> >> >>>>
> >>
> >>http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >> >> >>>>>
> >> >> >>>>> The filename of the patch is:
> >> >> >>>>>
> >> >0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >> >> >>>>> and it can be found in the queue-4.4 subdirectory.
> >> >> >>>>>
> >> >> >>>>> If you, or anyone else, feels it should not be added to the
> >> >stable
> >> >> >>>>> tree,
> >> >> >>>>> please let <stable@vger.kernel.org> know about it.
> >> >> >>>>>
> >> >> >>>>>
> >> >> >>>> >From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17
> >> >00:00:00
> >> >> >>> 2001
> >> >> >>>>> From: Nicholas Krause <xerofoify@gmail.com>
> >> >> >>>>> Date: Tue, 5 Jan 2016 14:32:54 -0500
> >> >> >>>>> Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
> >> >> >>> deference
> >> >> >>>>> in
> >> >> >>>>> mraid_mm_ioctl
> >> >> >>>>>
> >> >> >>>>> [ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
> >> >> >>>>>
> >> >> >>>>> This adds the needed check after the call to the function
> >> >> >>>>> mraid_mm_alloc_kioc in order to make sure that this function
> >> >has not
> >> >> >>>>> returned NULL and therefore makes sure we do not deference a
> >> >NULL
> >> >> >>>>> pointer if one is returned by mraid_mm_alloc_kioc. Further
> >> >more add
> >> >> >>>>> needed comments explaining that this function call can
> >return
> >> >NULL
> >> >> >>> if
> >> >> >>>>> the list head is empty for the pointer passed in order to
> >allow
> >> >> >>> furture
> >> >> >>>>> users to understand this required pointer check.
> >> >> >>>>>
> >> >> >>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> >> >>>>> Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
> >> >> >>>>> Signed-off-by: Martin K. Petersen
> ><martin.petersen@oracle.com>
> >> >> >>>>> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> >> >> >>>>> Signed-off-by: Greg Kroah-Hartman
> ><gregkh@linuxfoundation.org>
> >> >> >>>>> ---
> >> >> >>>>> drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
> >> >> >>>>> 1 file changed, 4 insertions(+)
> >> >> >>>>>
> >> >> >>>>> --- a/drivers/scsi/megaraid/megaraid_mm.c
> >> >> >>>>> +++ b/drivers/scsi/megaraid/megaraid_mm.c
> >> >> >>>>> @@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep,
> >unsig
> >> >> >>>>>
> >> >> >>>>> /*
> >> >> >>>>> * The following call will block till a kioc is available
> >> >> >>>>> + * or return NULL if the list head is empty for the
> >pointer
> >> >> >>>>> + * of type mraid_mmapt passed to mraid_mm_alloc_kioc
> >> >> >>>>> */
> >> >> >>>>> kioc = mraid_mm_alloc_kioc(adp);
> >> >> >>>>> + if (!kioc)
> >> >> >>>>> + return -ENXIO;
> >> >> >>>>>
> >> >> >>>>> /*
> >> >> >>>>> * User sent the old mimd_t ioctl packet. Convert it to
> >> >uioc_t.
> >> >> >>>>>
> >> >> >>>>>
> >> >> >>>>> Patches currently in stable-queue which might be from
> >> >> >>>>> xerofoify@gmail.com are
> >> >> >>>>>
> >> >> >>>>
> >> >> >>>>
> >>
> >>queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >> >> >>>> I do not wish any of my work to
> >> >> >>>> touch the stable kernel tree.
> >> >> >>>
> >> >> >>> Hahaha, sure, gladly deleted, too funny...
> >> >> >>>
> >> >> >>> greg k-h
> >> >> >> On top of that please revert the regression fix. That is also
> >my
> >> >> >> work and therefore shouldn't be touching the stable tree
> >either.
> >> >> >
> >> >> > What exactly are you referring to?
> >> >> >
> >> >>
> >>
> >>https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=fbedcaf43fba35677c01a4ae51e6f79edf4049ba
> >> >> This commit I want removed from stable as I refuse to have any of
> >my
> >> >work in the stable tree for now.
> >> >
> >> >Please learn a bit more about git, and how this specific commit
> >isn't
> >> >in
> >> >a "stable tree" before saying stuff like this, there is nothing to
> >do,
> >> >unless you want us to revert your changes entirely (and even then,
> >you
> >> >can't rewrite history...)
> >> >
> >> >sorry,
> >> >
> >> >greg k-h
> >> Then revert it from all git trees then.
> >
> >Please define "all git trees".
> >
> >And once you send in a patch, you sometimes don't have a say in where
> >it
> >ends up, sorry, that's just how open source development works :)
> >
> >best of luck!
> >
> >greg k-h
> From now I don't want any of patches being used as I refuse for my work to be used by such a toxic community toward me.
> Nick
One of the properties of the GPL is that once you have released your
code, or patch, under that license, you can't dictate the rules of
"use", sorry.
Again, I have already dropped this patch from the stable queue so I
don't understand what more we can do here.
Best of luck in the future,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-11 7:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-09 13:38 Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree gregkh
[not found] ` <E2E442CB-5C49-400E-9E0E-852AADACF179@gmail.com>
2016-09-10 8:15 ` Greg KH
[not found] ` <13EEF8FE-318F-4C2D-ABDF-A92B2D3B19D4@gmail.com>
2016-09-10 15:15 ` Greg KH
[not found] ` <31bbff7b-a07c-6dbc-2ef1-6693f27d18a8@gmail.com>
2016-09-10 15:49 ` Greg KH
[not found] ` <9353EE1A-4103-4178-9D19-CDE5E96EE1CB@gmail.com>
2016-09-10 16:05 ` Greg KH
[not found] ` <AF41C82E-0461-41E3-B35B-37C992517E68@gmail.com>
2016-09-11 7:22 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.