All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Matan Barak <matanb@mellanox.com>,
	Parav Pandit <pandit.parav@gmail.com>, Tejun Heo <tj@kernel.org>,
	cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-rdma@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Doug Ledford <dledford@redhat.com>,
	Liran Liss <liranl@mellanox.com>,
	"Hefty, Sean" <sean.hefty@intel.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Jonathan Corbet <corbet@lwn.net>,
	james.l.morris@oracle.com, serge@hallyn.com,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller
Date: Sat, 10 Sep 2016 11:01:51 -0600	[thread overview]
Message-ID: <20160910170151.GA5230@obsidianresearch.com> (raw)
In-Reply-To: <20160910161442.GC29259@lst.de>

On Sat, Sep 10, 2016 at 06:14:42PM +0200, Christoph Hellwig wrote:
> OFVWG meetings have absolutely zero relevance for Linux development.

Well, to be fair there are a fair number of kernel developers on that
particular call..

> More "flexibility" for drivers just means giving up on designing a
> coherent API and leaving it to drivers authors to add crap to their
> own drivers.  That's a major step backwards.

Sadly, it isn't a step backwards, it is status quo - at least as far
as the uapi is concerned.

Every single user space driver has its own private abi file, carefully
hidden in their driver, and dutifully copied over to user space:

providers/cxgb3/iwch-abi.h
providers/cxgb4/cxgb4-abi.h
providers/hfi1verbs/hfi-abi.h
providers/i40iw/i40iw-abi.h
providers/ipathverbs/ipath-abi.h
providers/mlx4/mlx4-abi.h
providers/mlx5/mlx5-abi.h
providers/mthca/mthca-abi.h
providers/nes/nes-abi.h
providers/ocrdma/ocrdma_abi.h
providers/rxe/rxe-abi.h

Just to pick two random examples:

struct mlx5_create_cq {
        struct ibv_create_cq            ibv_cmd;
        __u64                           buf_addr;
        __u64                           db_addr;
        __u32				cqe_size;
};

struct iwch_create_cq {
        struct ibv_create_cq ibv_cmd;
        uint64_t user_rptr_addr;
};

Love to hear ideas on a way forward that doesn't involve rewriting
everything :(

> They should not be using the code in drivers/infiniband.  usnic is such
> an example of a driver that should never have been added in it's current
> form.

+1

Jason

  reply	other threads:[~2016-09-10 17:01 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31  8:37 [PATCHv12 0/3] rdmacg: IB/core: rdma controller support Parav Pandit
2016-08-31  8:37 ` [PATCHv12 1/3] rdmacg: Added rdma cgroup controller Parav Pandit
2016-08-31  9:38   ` Leon Romanovsky
2016-09-07 15:07     ` Parav Pandit
2016-09-08  6:12       ` Leon Romanovsky
2016-09-08 10:20         ` Parav Pandit
2016-09-08 10:20           ` Parav Pandit
2016-08-31 15:07   ` Matan Barak
2016-08-31 15:07     ` Matan Barak
2016-08-31 21:16     ` Tejun Heo
     [not found]       ` <20160831211618.GA12660-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-09-01  7:25         ` Matan Barak
2016-09-01  7:25           ` Matan Barak
2016-09-01  8:44           ` Christoph Hellwig
     [not found]             ` <20160901084406.GA4115-jcswGhMUV9g@public.gmane.org>
2016-09-07  7:55               ` Parav Pandit
2016-09-07  7:55                 ` Parav Pandit
2016-09-07  8:51                 ` Matan Barak
2016-09-07  8:51                   ` Matan Barak
2016-09-07 14:54                   ` Parav Pandit
     [not found]                   ` <ae3adcc4-253e-f87c-6ff6-202c91599f48-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-10 16:14                     ` Christoph Hellwig
2016-09-10 16:14                       ` Christoph Hellwig
2016-09-10 17:01                       ` Jason Gunthorpe [this message]
     [not found]                         ` <20160910170151.GA5230-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-11  8:07                           ` Matan Barak
2016-09-11  8:07                             ` Matan Barak
2016-09-11 13:34                         ` Christoph Hellwig
2016-09-11 14:35                           ` Leon Romanovsky
2016-09-11 17:14                             ` Jason Gunthorpe
2016-09-11 17:24                               ` Christoph Hellwig
2016-09-11 17:52                                 ` Jason Gunthorpe
     [not found]                                   ` <20160911175235.GB13442-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12  5:07                                     ` Leon Romanovsky
2016-09-12  5:07                                       ` Leon Romanovsky
     [not found]                                       ` <20160912050717.GE8812-2ukJVAZIZ/Y@public.gmane.org>
2016-09-14  7:06                                         ` Parav Pandit
2016-09-14  7:06                                           ` Parav Pandit
2016-09-14  8:14                                           ` Matan Barak
2016-09-14  8:14                                             ` Matan Barak
     [not found]                                             ` <13a00119-e629-2d34-d08b-c02bb6beceea-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-14  9:19                                               ` Parav Pandit
2016-09-14  9:19                                                 ` Parav Pandit
     [not found]                                           ` <CAG53R5X4stfy5+Jmg+XReUJqt56Z-zABK+UEswHW1dXhH-9cNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-15 18:56                                             ` Leon Romanovsky
2016-09-15 18:56                                               ` Leon Romanovsky
2016-09-21  4:43                                               ` Parav Pandit
2016-09-21 14:26                                                 ` Tejun Heo
     [not found]                                                   ` <20160921142645.GB10734-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-09-21 16:02                                                     ` Parav Pandit
2016-09-21 16:02                                                       ` Parav Pandit
     [not found]                                                       ` <CAG53R5WMuojhzFGmqk6nHfypd9Hq4dGsWRKjtUyMZ=RezU-LhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-04 18:19                                                         ` Parav Pandit
2016-10-04 18:19                                                           ` Parav Pandit
2016-10-04 18:19                                                           ` Parav Pandit
2016-10-05  6:37                                                           ` Christoph Hellwig
2016-10-05 11:22                                                             ` Leon Romanovsky
2016-10-05 15:36                                                               ` Tejun Heo
     [not found]                                                             ` <20161005063735.GC3086-jcswGhMUV9g@public.gmane.org>
2016-10-06 12:55                                                               ` Parav Pandit
2016-10-06 12:55                                                                 ` Parav Pandit
2016-10-18 20:15                                                           ` Parav Pandit
2016-09-19 13:10                                             ` Dalessandro, Dennis
2016-09-19 13:10                                               ` Dalessandro, Dennis
2016-09-19 17:00                                               ` Parav Pandit
2016-09-19 17:00                                                 ` Parav Pandit
     [not found]                 ` <CAG53R5Ws4BJKqeEYfEoEx5kuaXUmhDKcXfH4Vx=LTMK6tKMG0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-10 16:12                   ` Christoph Hellwig
2016-09-10 16:12                     ` Christoph Hellwig
     [not found]                     ` <20160910161228.GB29259-jcswGhMUV9g@public.gmane.org>
2016-09-11  7:40                       ` Matan Barak
2016-09-11  7:40                         ` Matan Barak
2016-08-31  8:37 ` [PATCHv12 2/3] IB/core: added support to use " Parav Pandit
     [not found] ` <1472632647-1525-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-31  8:37   ` [PATCHv12 3/3] rdmacg: Added documentation for rdmacg Parav Pandit
2016-08-31  8:37     ` Parav Pandit
2016-08-31 13:56   ` [PATCHv12 0/3] rdmacg: IB/core: rdma controller support Tejun Heo
2016-08-31 13:56     ` Tejun Heo
2016-10-05 11:22 ` Leon Romanovsky
     [not found]   ` <20161005112206.GC9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-06 12:59     ` Parav Pandit
2016-10-06 12:59       ` Parav Pandit
2016-10-06 13:49     ` Parav Pandit
     [not found]       ` <CAG53R5VNVb=8-LJbDRqjtOZG347ucPuc420bcfnDgBKMoKqU-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10  4:46         ` Leon Romanovsky
     [not found]           ` <20161010044623.GI9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-10  6:29             ` Parav Pandit
     [not found]               ` <CAG53R5UM6nSTZ7=0S9reKGX45CpNBi8soSDVZyXkN-z0_XXWWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10  7:33                 ` Leon Romanovsky
     [not found]                   ` <20161010073343.GK9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-10  8:35                     ` Parav Pandit
     [not found]                       ` <CAG53R5WeWSrJ5-Gtt-cXpUr0r73zh3bqQM_G5zTue27tPtVEXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10  8:52                         ` Leon Romanovsky
     [not found]                           ` <20161010085241.GL9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-10  9:22                             ` Parav Pandit
2016-10-10 12:25                 ` Tejun Heo
     [not found]                   ` <20161010122545.GA27360-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-10-10 13:13                     ` Parav Pandit
     [not found]                       ` <CAG53R5V5yE4PsDBjP9BieG_=39M0G1kx-AfBEzWK4LUCxNnYBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10 13:20                         ` Tejun Heo
     [not found]                           ` <20161010132014.GD29742-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-10-10 13:32                             ` Parav Pandit
     [not found]                               ` <CAG53R5ULKCqtw45E6t4hYdRV+y_OQqVazf=7A7Ax_XAJ2K0_dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-13 10:34                                 ` Leon Romanovsky
     [not found]                                   ` <20161013103430.GB9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-13 11:04                                     ` Parav Pandit
2016-10-13 23:14                                 ` Tejun Heo
     [not found]                                   ` <20161013231413.GA32534-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-10-18 20:02                                     ` Parav Pandit
     [not found]                                       ` <CAG53R5UciPpa5d8BWyR-tks3LBrBwRCN2NyBbbm1e3EE-OWSYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-18 21:51                                         ` Tejun Heo
     [not found]                                           ` <20161018215134.GB2761-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19  9:34                                             ` Parav Pandit
     [not found]                                               ` <CAG53R5UEvkPBM0yFrR=fvEzyCrku2q=rLZyDVrSs9q+3hgbSmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 14:33                                                 ` Tejun Heo
     [not found]                                                   ` <20161019143345.GA18532-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19 19:03                                                     ` Parav Pandit
     [not found]                                                       ` <CAG53R5WUyA7JBn=PeivUc5F5k210xf_HccPXFt3r7ZGYHOPaGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 19:20                                                         ` Tejun Heo
     [not found]                                                           ` <20161019192006.GB3044-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19 19:54                                                             ` Parav Pandit
     [not found]                                                               ` <CAG53R5X5dyo7J-UkeMxi_mSxgv=c54fV=anuCZtmf9kaYwDbPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 20:05                                                                 ` Tejun Heo
     [not found]                                                                   ` <20161019200536.GC3044-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19 20:18                                                                     ` Parav Pandit
     [not found]                                                                       ` <CAG53R5XkRKdo-SCaREZvov3AGp5MSd18RpQ+0HEu-htUzqwOOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-31  6:54                                                                         ` Leon Romanovsky
     [not found]                                                                           ` <20161031065441.GY3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-01 11:03                                                                             ` Parav Pandit
     [not found]                                                                               ` <CAG53R5VKwntDHX101+5aaGoyKMKQuiKQWam575iFAxhmKxhE1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-01 14:07                                                                                 ` Leon Romanovsky
     [not found]                                                                                   ` <20161101140732.GC3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-02  4:34                                                                                     ` Parav Pandit
2016-11-03 18:00                                                                                 ` Leon Romanovsky
     [not found]                                                                                   ` <20161103180006.GL3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-04  4:20                                                                                     ` Leon Romanovsky
2016-11-04  4:20                                                                                     ` Liran Liss
     [not found]                                                                                       ` <AM4PR0501MB2802030EE9E359133E04439CB1A20-dp/nxUn679jTOi/YP668sMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-04  4:47                                                                                         ` Parav Pandit
     [not found]                                                                                           ` <CAG53R5Vd58wEBKgAajp9VvJmB5sO2Umii0JE4XaLYKbfrJrxyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-04  4:52                                                                                             ` Liran Liss
     [not found]                                                                                               ` <AM4PR0501MB2802E87F709F41DDEC20B7C9B1A20-dp/nxUn679jTOi/YP668sMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-04  4:57                                                                                                 ` Parav Pandit
     [not found]                                                                                                   ` <CAG53R5UyZPh9wduPZGRg2P09n2Og8oODqb+QW=7ryAPqJDa6Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-04  5:06                                                                                                     ` Liran Liss
     [not found]                                                                                                       ` <AM4PR0501MB28025BE002CBA9D04675A5A5B1A20-dp/nxUn679jTOi/YP668sMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-04  5:44                                                                                                         ` Parav Pandit
     [not found]                                                                                                           ` <CAG53R5WdauHpML66g-O6zj+j_DUYWJMPjmL1xDaSxwDmPPYm2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-08  8:12                                                                                                             ` Liran Liss
     [not found]                                                                                                               ` <HE1PR0501MB2812298C05431B08B0F408EEB1A60-692Kmc8YnlIVrnpjwTCbp8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-10  7:41                                                                                                                 ` Parav Pandit
     [not found]                                                                                                                   ` <CAG53R5XqZwrYsdX=JQ1D4cDB0h65RDQVb=VCiaR5TXuf_uoO0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-10 16:38                                                                                                                     ` Leon Romanovsky
     [not found]                                                                                                                       ` <20161110163837.GE28957-2ukJVAZIZ/Y@public.gmane.org>
2016-11-10 16:46                                                                                                                         ` Tejun Heo
     [not found]                                                                                                                           ` <20161110164638.GC26105-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-11-10 17:04                                                                                                                             ` Parav Pandit
     [not found]                                                                                                                               ` <CAG53R5UGfhGHc3-jgUjH5taFzTHg3BOgXi25QjuQfUFc0U7tgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-10 17:32                                                                                                                                 ` Tejun Heo
     [not found]                                                                                                                                   ` <20161110173217.GD26105-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-11-10 17:56                                                                                                                                     ` Parav Pandit
2016-11-10 19:23                                                                                                                                       ` Tejun Heo
     [not found]                                                                                                                                         ` <20161110192344.GA4805-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-11-11 13:00                                                                                                                                           ` Parav Pandit
2016-11-04  4:28                                                                                     ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160910170151.GA5230@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=dledford@redhat.com \
    --cc=haggaie@mellanox.com \
    --cc=hannes@cmpxchg.org \
    --cc=hch@lst.de \
    --cc=james.l.morris@oracle.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=liranl@mellanox.com \
    --cc=lizefan@huawei.com \
    --cc=matanb@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=pandit.parav@gmail.com \
    --cc=sean.hefty@intel.com \
    --cc=serge@hallyn.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.