All of lore.kernel.org
 help / color / mirror / Atom feed
From: Parav Pandit <pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Liran Liss <liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"Hefty,
	Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCHv12 0/3] rdmacg: IB/core: rdma controller support
Date: Wed, 19 Oct 2016 15:04:52 +0530	[thread overview]
Message-ID: <CAG53R5UEvkPBM0yFrR=fvEzyCrku2q=rLZyDVrSs9q+3hgbSmQ@mail.gmail.com> (raw)
In-Reply-To: <20161018215134.GB2761-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>

Hi Tejun,

On Wed, Oct 19, 2016 at 3:21 AM, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Hello,
>
> On Wed, Oct 19, 2016 at 01:32:01AM +0530, Parav Pandit wrote:
>> On Fri, Oct 14, 2016 at 4:44 AM, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>> > I think what you want is just a way to specify absolute limits using
>> > percentages of what's available at the time of configuration -
>> > e.g. being able to say "allow upto 30% of what's available in the
>> > parent".
>>
>> Yes. I am concerned about how to configure < 1% value to avoid
>> floating point math in kernel as thats discouraged.
>> Configuring in range of 1 to 100% for a given resource limits to only
>> 100 or less cgroup instances which I think is not desired.
>
> Heh, we can go for per-mil and use %0 as the suffix if absolutely
> necessary but is this a real issue?
>
We need to provide current version to exceed the 100 containers limit first. :-)
Please let me know if such user interface already exist as reference point.
I prefer to avoid introducing such configuration.

>> > If so, the simplest way would be simply updating the
>> > existing knobs to accept % inputs in addition to absolute values on
>> > writes.
>>
>> I was not sure to overload rdma.max file for accepting % inputs as
>> thats not done in other cgroups. So I was thinking more of weights
>> interface which avoids floating point problem and also allows much
>> wider configuration range.
>
> I think it's a lot more consistent to implement all absoulte limits
> through max.
I agree. I will implement reporting actual max values instead of
reporting "max" string so that percentage configuration can be done by
the user space tools.
(post merging of v12).
Waiting for direction from Doug.

> weight is for actual proportional control which this
> isn't.  It's just a fancy way of specifying absolute limits.
>
> Thanks.
>
> --
> tejun

  parent reply	other threads:[~2016-10-19  9:34 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31  8:37 [PATCHv12 0/3] rdmacg: IB/core: rdma controller support Parav Pandit
2016-08-31  8:37 ` [PATCHv12 1/3] rdmacg: Added rdma cgroup controller Parav Pandit
2016-08-31  9:38   ` Leon Romanovsky
2016-09-07 15:07     ` Parav Pandit
2016-09-08  6:12       ` Leon Romanovsky
2016-09-08 10:20         ` Parav Pandit
2016-09-08 10:20           ` Parav Pandit
2016-08-31 15:07   ` Matan Barak
2016-08-31 15:07     ` Matan Barak
2016-08-31 21:16     ` Tejun Heo
     [not found]       ` <20160831211618.GA12660-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-09-01  7:25         ` Matan Barak
2016-09-01  7:25           ` Matan Barak
2016-09-01  8:44           ` Christoph Hellwig
     [not found]             ` <20160901084406.GA4115-jcswGhMUV9g@public.gmane.org>
2016-09-07  7:55               ` Parav Pandit
2016-09-07  7:55                 ` Parav Pandit
2016-09-07  8:51                 ` Matan Barak
2016-09-07  8:51                   ` Matan Barak
2016-09-07 14:54                   ` Parav Pandit
     [not found]                   ` <ae3adcc4-253e-f87c-6ff6-202c91599f48-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-10 16:14                     ` Christoph Hellwig
2016-09-10 16:14                       ` Christoph Hellwig
2016-09-10 17:01                       ` Jason Gunthorpe
     [not found]                         ` <20160910170151.GA5230-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-11  8:07                           ` Matan Barak
2016-09-11  8:07                             ` Matan Barak
2016-09-11 13:34                         ` Christoph Hellwig
2016-09-11 14:35                           ` Leon Romanovsky
2016-09-11 17:14                             ` Jason Gunthorpe
2016-09-11 17:24                               ` Christoph Hellwig
2016-09-11 17:52                                 ` Jason Gunthorpe
     [not found]                                   ` <20160911175235.GB13442-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12  5:07                                     ` Leon Romanovsky
2016-09-12  5:07                                       ` Leon Romanovsky
     [not found]                                       ` <20160912050717.GE8812-2ukJVAZIZ/Y@public.gmane.org>
2016-09-14  7:06                                         ` Parav Pandit
2016-09-14  7:06                                           ` Parav Pandit
2016-09-14  8:14                                           ` Matan Barak
2016-09-14  8:14                                             ` Matan Barak
     [not found]                                             ` <13a00119-e629-2d34-d08b-c02bb6beceea-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-14  9:19                                               ` Parav Pandit
2016-09-14  9:19                                                 ` Parav Pandit
     [not found]                                           ` <CAG53R5X4stfy5+Jmg+XReUJqt56Z-zABK+UEswHW1dXhH-9cNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-15 18:56                                             ` Leon Romanovsky
2016-09-15 18:56                                               ` Leon Romanovsky
2016-09-21  4:43                                               ` Parav Pandit
2016-09-21 14:26                                                 ` Tejun Heo
     [not found]                                                   ` <20160921142645.GB10734-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-09-21 16:02                                                     ` Parav Pandit
2016-09-21 16:02                                                       ` Parav Pandit
     [not found]                                                       ` <CAG53R5WMuojhzFGmqk6nHfypd9Hq4dGsWRKjtUyMZ=RezU-LhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-04 18:19                                                         ` Parav Pandit
2016-10-04 18:19                                                           ` Parav Pandit
2016-10-04 18:19                                                           ` Parav Pandit
2016-10-05  6:37                                                           ` Christoph Hellwig
2016-10-05 11:22                                                             ` Leon Romanovsky
2016-10-05 15:36                                                               ` Tejun Heo
     [not found]                                                             ` <20161005063735.GC3086-jcswGhMUV9g@public.gmane.org>
2016-10-06 12:55                                                               ` Parav Pandit
2016-10-06 12:55                                                                 ` Parav Pandit
2016-10-18 20:15                                                           ` Parav Pandit
2016-09-19 13:10                                             ` Dalessandro, Dennis
2016-09-19 13:10                                               ` Dalessandro, Dennis
2016-09-19 17:00                                               ` Parav Pandit
2016-09-19 17:00                                                 ` Parav Pandit
     [not found]                 ` <CAG53R5Ws4BJKqeEYfEoEx5kuaXUmhDKcXfH4Vx=LTMK6tKMG0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-10 16:12                   ` Christoph Hellwig
2016-09-10 16:12                     ` Christoph Hellwig
     [not found]                     ` <20160910161228.GB29259-jcswGhMUV9g@public.gmane.org>
2016-09-11  7:40                       ` Matan Barak
2016-09-11  7:40                         ` Matan Barak
2016-08-31  8:37 ` [PATCHv12 2/3] IB/core: added support to use " Parav Pandit
     [not found] ` <1472632647-1525-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-31  8:37   ` [PATCHv12 3/3] rdmacg: Added documentation for rdmacg Parav Pandit
2016-08-31  8:37     ` Parav Pandit
2016-08-31 13:56   ` [PATCHv12 0/3] rdmacg: IB/core: rdma controller support Tejun Heo
2016-08-31 13:56     ` Tejun Heo
2016-10-05 11:22 ` Leon Romanovsky
     [not found]   ` <20161005112206.GC9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-06 12:59     ` Parav Pandit
2016-10-06 12:59       ` Parav Pandit
2016-10-06 13:49     ` Parav Pandit
     [not found]       ` <CAG53R5VNVb=8-LJbDRqjtOZG347ucPuc420bcfnDgBKMoKqU-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10  4:46         ` Leon Romanovsky
     [not found]           ` <20161010044623.GI9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-10  6:29             ` Parav Pandit
     [not found]               ` <CAG53R5UM6nSTZ7=0S9reKGX45CpNBi8soSDVZyXkN-z0_XXWWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10  7:33                 ` Leon Romanovsky
     [not found]                   ` <20161010073343.GK9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-10  8:35                     ` Parav Pandit
     [not found]                       ` <CAG53R5WeWSrJ5-Gtt-cXpUr0r73zh3bqQM_G5zTue27tPtVEXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10  8:52                         ` Leon Romanovsky
     [not found]                           ` <20161010085241.GL9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-10  9:22                             ` Parav Pandit
2016-10-10 12:25                 ` Tejun Heo
     [not found]                   ` <20161010122545.GA27360-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-10-10 13:13                     ` Parav Pandit
     [not found]                       ` <CAG53R5V5yE4PsDBjP9BieG_=39M0G1kx-AfBEzWK4LUCxNnYBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10 13:20                         ` Tejun Heo
     [not found]                           ` <20161010132014.GD29742-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-10-10 13:32                             ` Parav Pandit
     [not found]                               ` <CAG53R5ULKCqtw45E6t4hYdRV+y_OQqVazf=7A7Ax_XAJ2K0_dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-13 10:34                                 ` Leon Romanovsky
     [not found]                                   ` <20161013103430.GB9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-13 11:04                                     ` Parav Pandit
2016-10-13 23:14                                 ` Tejun Heo
     [not found]                                   ` <20161013231413.GA32534-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-10-18 20:02                                     ` Parav Pandit
     [not found]                                       ` <CAG53R5UciPpa5d8BWyR-tks3LBrBwRCN2NyBbbm1e3EE-OWSYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-18 21:51                                         ` Tejun Heo
     [not found]                                           ` <20161018215134.GB2761-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19  9:34                                             ` Parav Pandit [this message]
     [not found]                                               ` <CAG53R5UEvkPBM0yFrR=fvEzyCrku2q=rLZyDVrSs9q+3hgbSmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 14:33                                                 ` Tejun Heo
     [not found]                                                   ` <20161019143345.GA18532-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19 19:03                                                     ` Parav Pandit
     [not found]                                                       ` <CAG53R5WUyA7JBn=PeivUc5F5k210xf_HccPXFt3r7ZGYHOPaGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 19:20                                                         ` Tejun Heo
     [not found]                                                           ` <20161019192006.GB3044-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19 19:54                                                             ` Parav Pandit
     [not found]                                                               ` <CAG53R5X5dyo7J-UkeMxi_mSxgv=c54fV=anuCZtmf9kaYwDbPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 20:05                                                                 ` Tejun Heo
     [not found]                                                                   ` <20161019200536.GC3044-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-10-19 20:18                                                                     ` Parav Pandit
     [not found]                                                                       ` <CAG53R5XkRKdo-SCaREZvov3AGp5MSd18RpQ+0HEu-htUzqwOOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-31  6:54                                                                         ` Leon Romanovsky
     [not found]                                                                           ` <20161031065441.GY3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-01 11:03                                                                             ` Parav Pandit
     [not found]                                                                               ` <CAG53R5VKwntDHX101+5aaGoyKMKQuiKQWam575iFAxhmKxhE1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-01 14:07                                                                                 ` Leon Romanovsky
     [not found]                                                                                   ` <20161101140732.GC3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-02  4:34                                                                                     ` Parav Pandit
2016-11-03 18:00                                                                                 ` Leon Romanovsky
     [not found]                                                                                   ` <20161103180006.GL3617-2ukJVAZIZ/Y@public.gmane.org>
2016-11-04  4:20                                                                                     ` Leon Romanovsky
2016-11-04  4:20                                                                                     ` Liran Liss
     [not found]                                                                                       ` <AM4PR0501MB2802030EE9E359133E04439CB1A20-dp/nxUn679jTOi/YP668sMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-04  4:47                                                                                         ` Parav Pandit
     [not found]                                                                                           ` <CAG53R5Vd58wEBKgAajp9VvJmB5sO2Umii0JE4XaLYKbfrJrxyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-04  4:52                                                                                             ` Liran Liss
     [not found]                                                                                               ` <AM4PR0501MB2802E87F709F41DDEC20B7C9B1A20-dp/nxUn679jTOi/YP668sMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-04  4:57                                                                                                 ` Parav Pandit
     [not found]                                                                                                   ` <CAG53R5UyZPh9wduPZGRg2P09n2Og8oODqb+QW=7ryAPqJDa6Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-04  5:06                                                                                                     ` Liran Liss
     [not found]                                                                                                       ` <AM4PR0501MB28025BE002CBA9D04675A5A5B1A20-dp/nxUn679jTOi/YP668sMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-04  5:44                                                                                                         ` Parav Pandit
     [not found]                                                                                                           ` <CAG53R5WdauHpML66g-O6zj+j_DUYWJMPjmL1xDaSxwDmPPYm2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-08  8:12                                                                                                             ` Liran Liss
     [not found]                                                                                                               ` <HE1PR0501MB2812298C05431B08B0F408EEB1A60-692Kmc8YnlIVrnpjwTCbp8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-11-10  7:41                                                                                                                 ` Parav Pandit
     [not found]                                                                                                                   ` <CAG53R5XqZwrYsdX=JQ1D4cDB0h65RDQVb=VCiaR5TXuf_uoO0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-10 16:38                                                                                                                     ` Leon Romanovsky
     [not found]                                                                                                                       ` <20161110163837.GE28957-2ukJVAZIZ/Y@public.gmane.org>
2016-11-10 16:46                                                                                                                         ` Tejun Heo
     [not found]                                                                                                                           ` <20161110164638.GC26105-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-11-10 17:04                                                                                                                             ` Parav Pandit
     [not found]                                                                                                                               ` <CAG53R5UGfhGHc3-jgUjH5taFzTHg3BOgXi25QjuQfUFc0U7tgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-10 17:32                                                                                                                                 ` Tejun Heo
     [not found]                                                                                                                                   ` <20161110173217.GD26105-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-11-10 17:56                                                                                                                                     ` Parav Pandit
2016-11-10 19:23                                                                                                                                       ` Tejun Heo
     [not found]                                                                                                                                         ` <20161110192344.GA4805-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-11-11 13:00                                                                                                                                           ` Parav Pandit
2016-11-04  4:28                                                                                     ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAG53R5UEvkPBM0yFrR=fvEzyCrku2q=rLZyDVrSs9q+3hgbSmQ@mail.gmail.com' \
    --to=pandit.parav-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.