* [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:01 ` Andy Yan
0 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2016-09-10 9:01 UTC (permalink / raw)
To: heiko
Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland, Andy Yan
PX3 board is designed by Rockchip for automotive field,
which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
video input/output interface, WIFI/BT/GPS(on a module
named S500 which based on MT6620), Gsensor BMA250E and
light&proximity sensor STK3410.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/rk3188-px3.dts | 337 +++++++++++++++++++++
3 files changed, 342 insertions(+)
create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
index 6668645..e680105 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.txt
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
Required root node properties:
- compatible = "radxa,rock", "rockchip,rk3188";
+- Rockchip PX3 board:
+ Required root node properties:
+ - compatible = "rockchip,px3", "rockchip,rk3188";
+
- Radxa Rock2 Square board:
Required root node properties:
- compatible = "radxa,rock2-square", "rockchip,rk3288";
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index faacd52..72cd3f5 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -620,6 +620,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
rk3066a-marsboard.dtb \
rk3066a-rayeager.dtb \
rk3188-radxarock.dtb \
+ rk3188-px3.dtb \
rk3228-evb.dtb \
rk3229-evb.dtb \
rk3288-evb-act8846.dtb \
diff --git a/arch/arm/boot/dts/rk3188-px3.dts b/arch/arm/boot/dts/rk3188-px3.dts
new file mode 100644
index 0000000..ece45d7
--- /dev/null
+++ b/arch/arm/boot/dts/rk3188-px3.dts
@@ -0,0 +1,337 @@
+/*
+ * Copyright (c) 2016 Andy Yan <andy.yan@rock-chips.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include <dt-bindings/input/input.h>
+#include "rk3188.dtsi"
+
+/ {
+ model = "Rockchip PX3";
+ compatible = "rockchip,px3", "rockchip,rk3188";
+
+ chosen {
+ bootargs = "console=ttyS2,115200 earlyprintk";
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x60000000 0x80000000>;
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+
+ power {
+ gpios = <&gpio0 4 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_POWER>;
+ label = "GPIO Key Power";
+ linux,input-type = <1>;
+ wakeup-source;
+ debounce-interval = <100>;
+ };
+ };
+
+ vcc_sys: vsys-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vsys";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-boot-on;
+ };
+};
+
+&cpu0 {
+ cpu0-supply = <&vdd_cpu>;
+};
+
+&i2c0 {
+ status = "okay";
+
+ /* Accelerometer */
+ bma250@18 {
+ compatible = "bma250";
+ reg = <0x18>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
+ };
+
+ stk3410@48 {
+ compatible = "STK3310";
+ reg = <0x48>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
+ };
+};
+
+&i2c1 {
+ status = "okay";
+ clock-frequency = <400000>;
+ rk808: pmic@1c {
+ compatible = "rockchip,rk818";
+ reg = <0x1c>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ rockchip,system-power-controller;
+ wakeup-source;
+ #clock-cells = <1>;
+ clock-output-names = "xin32k", "rk808-clkout2";
+
+ vcc1-supply = <&vcc_sys>;
+ vcc2-supply = <&vcc_sys>;
+ vcc3-supply = <&vcc_sys>;
+ vcc4-supply = <&vcc_sys>;
+ vcc6-supply = <&vcc_sys>;
+ vcc7-supply = <&vcc_sys>;
+ vcc8-supply = <&vcc_io>;
+ vcc9-supply = <&vcc_io>;
+
+ regulators {
+ vdd_cpu: DCDC_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-name = "vdd_arm";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_gpu: DCDC_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-name = "vdd_gpu";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1000000>;
+ };
+ };
+
+ vcc_ddr: DCDC_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc_ddr";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vcc_io: DCDC_REG4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_io";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+
+ vcc_cif: LDO_REG1 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_cif";
+ };
+
+ vcc_jetta33: LDO_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_jetta33";
+ };
+
+ vdd_10: LDO_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-name = "vdd_10";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1000000>;
+ };
+ };
+
+ lvds_12: LDO_REG4 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "lvds_12";
+ };
+
+ lvds_25: LDO_REG5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "lvds_25";
+ };
+
+ cif_18: LDO_REG6 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-name = "cif_18";
+ };
+
+ vcc_sd: LDO_REG7 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_sd";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+
+ wl_18: LDO_REG8 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "wl_18";
+ };
+
+ lcd_33: SWITCH_REG1 {
+ regulator-name = "lcd_33";
+ };
+ };
+ };
+
+};
+
+&i2c2 {
+ gsl1680: touchscreen@40 {
+ compatible = "gsl1680";
+ reg = <0x40>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+ power-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
+ touchscreen-size-x = <800>;
+ touchscreen-size-y = <1280>;
+ silead,max-fingers = <5>;
+ };
+};
+
+&emmc {
+ bus-width = <8>;
+ cap-mmc-highspeed;
+ disable-wp;
+ non-removable;
+ num-slots = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&emmc_clk>, <&emmc_cmd>, <&emmc_rst>;
+ status = "okay";
+};
+
+&mmc0 {
+ num-slots = <1>;
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
+ vmmc-supply = <&vcc_sd>;
+
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ disable-wp;
+};
+
+&pwm1 {
+ status = "okay";
+};
+
+&pwm2 {
+ status = "okay";
+};
+
+&pwm3 {
+ status = "okay";
+};
+
+&pinctrl {
+ pcfg_output_low: pcfg-output-low {
+ output-low;
+ };
+
+ usb {
+ host_vbus_drv: host-vbus-drv {
+ rockchip,pins = <0 3 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ otg_vbus_drv: otg-vbus-drv {
+ rockchip,pins = <2 31 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&uart1 {
+ status = "okay";
+};
+
+&uart2 {
+ status = "okay";
+};
+
+&uart3 {
+ status = "okay";
+};
+
+&usbphy {
+ status = "okay";
+};
+
+&usb_host {
+ status = "okay";
+};
+
+&usb_otg {
+ status = "okay";
+};
+
+&wdt {
+ status = "okay";
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:01 ` Andy Yan
0 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2016-09-10 9:01 UTC (permalink / raw)
To: heiko-4mtYJXux2i+zQB+pC5nmwQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
briannorris-F7+t8E8rja9g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
Andy Yan
PX3 board is designed by Rockchip for automotive field,
which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
video input/output interface, WIFI/BT/GPS(on a module
named S500 which based on MT6620), Gsensor BMA250E and
light&proximity sensor STK3410.
Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/rk3188-px3.dts | 337 +++++++++++++++++++++
3 files changed, 342 insertions(+)
create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
index 6668645..e680105 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.txt
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
Required root node properties:
- compatible = "radxa,rock", "rockchip,rk3188";
+- Rockchip PX3 board:
+ Required root node properties:
+ - compatible = "rockchip,px3", "rockchip,rk3188";
+
- Radxa Rock2 Square board:
Required root node properties:
- compatible = "radxa,rock2-square", "rockchip,rk3288";
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index faacd52..72cd3f5 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -620,6 +620,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
rk3066a-marsboard.dtb \
rk3066a-rayeager.dtb \
rk3188-radxarock.dtb \
+ rk3188-px3.dtb \
rk3228-evb.dtb \
rk3229-evb.dtb \
rk3288-evb-act8846.dtb \
diff --git a/arch/arm/boot/dts/rk3188-px3.dts b/arch/arm/boot/dts/rk3188-px3.dts
new file mode 100644
index 0000000..ece45d7
--- /dev/null
+++ b/arch/arm/boot/dts/rk3188-px3.dts
@@ -0,0 +1,337 @@
+/*
+ * Copyright (c) 2016 Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include <dt-bindings/input/input.h>
+#include "rk3188.dtsi"
+
+/ {
+ model = "Rockchip PX3";
+ compatible = "rockchip,px3", "rockchip,rk3188";
+
+ chosen {
+ bootargs = "console=ttyS2,115200 earlyprintk";
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x60000000 0x80000000>;
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+
+ power {
+ gpios = <&gpio0 4 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_POWER>;
+ label = "GPIO Key Power";
+ linux,input-type = <1>;
+ wakeup-source;
+ debounce-interval = <100>;
+ };
+ };
+
+ vcc_sys: vsys-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vsys";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-boot-on;
+ };
+};
+
+&cpu0 {
+ cpu0-supply = <&vdd_cpu>;
+};
+
+&i2c0 {
+ status = "okay";
+
+ /* Accelerometer */
+ bma250@18 {
+ compatible = "bma250";
+ reg = <0x18>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
+ };
+
+ stk3410@48 {
+ compatible = "STK3310";
+ reg = <0x48>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
+ };
+};
+
+&i2c1 {
+ status = "okay";
+ clock-frequency = <400000>;
+ rk808: pmic@1c {
+ compatible = "rockchip,rk818";
+ reg = <0x1c>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ rockchip,system-power-controller;
+ wakeup-source;
+ #clock-cells = <1>;
+ clock-output-names = "xin32k", "rk808-clkout2";
+
+ vcc1-supply = <&vcc_sys>;
+ vcc2-supply = <&vcc_sys>;
+ vcc3-supply = <&vcc_sys>;
+ vcc4-supply = <&vcc_sys>;
+ vcc6-supply = <&vcc_sys>;
+ vcc7-supply = <&vcc_sys>;
+ vcc8-supply = <&vcc_io>;
+ vcc9-supply = <&vcc_io>;
+
+ regulators {
+ vdd_cpu: DCDC_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-name = "vdd_arm";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_gpu: DCDC_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-name = "vdd_gpu";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1000000>;
+ };
+ };
+
+ vcc_ddr: DCDC_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc_ddr";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vcc_io: DCDC_REG4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_io";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+
+ vcc_cif: LDO_REG1 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_cif";
+ };
+
+ vcc_jetta33: LDO_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_jetta33";
+ };
+
+ vdd_10: LDO_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-name = "vdd_10";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1000000>;
+ };
+ };
+
+ lvds_12: LDO_REG4 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "lvds_12";
+ };
+
+ lvds_25: LDO_REG5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "lvds_25";
+ };
+
+ cif_18: LDO_REG6 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-name = "cif_18";
+ };
+
+ vcc_sd: LDO_REG7 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_sd";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+
+ wl_18: LDO_REG8 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "wl_18";
+ };
+
+ lcd_33: SWITCH_REG1 {
+ regulator-name = "lcd_33";
+ };
+ };
+ };
+
+};
+
+&i2c2 {
+ gsl1680: touchscreen@40 {
+ compatible = "gsl1680";
+ reg = <0x40>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+ power-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
+ touchscreen-size-x = <800>;
+ touchscreen-size-y = <1280>;
+ silead,max-fingers = <5>;
+ };
+};
+
+&emmc {
+ bus-width = <8>;
+ cap-mmc-highspeed;
+ disable-wp;
+ non-removable;
+ num-slots = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&emmc_clk>, <&emmc_cmd>, <&emmc_rst>;
+ status = "okay";
+};
+
+&mmc0 {
+ num-slots = <1>;
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
+ vmmc-supply = <&vcc_sd>;
+
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ disable-wp;
+};
+
+&pwm1 {
+ status = "okay";
+};
+
+&pwm2 {
+ status = "okay";
+};
+
+&pwm3 {
+ status = "okay";
+};
+
+&pinctrl {
+ pcfg_output_low: pcfg-output-low {
+ output-low;
+ };
+
+ usb {
+ host_vbus_drv: host-vbus-drv {
+ rockchip,pins = <0 3 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ otg_vbus_drv: otg-vbus-drv {
+ rockchip,pins = <2 31 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&uart1 {
+ status = "okay";
+};
+
+&uart2 {
+ status = "okay";
+};
+
+&uart3 {
+ status = "okay";
+};
+
+&usbphy {
+ status = "okay";
+};
+
+&usb_host {
+ status = "okay";
+};
+
+&usb_otg {
+ status = "okay";
+};
+
+&wdt {
+ status = "okay";
+};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: Add PX5 board
2016-09-10 9:01 ` Andy Yan
(?)
@ 2016-09-10 9:05 ` Andy Yan
-1 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2016-09-10 9:05 UTC (permalink / raw)
To: heiko
Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland, Andy Yan
PX5 board is designed by Rockchip for automotive field,
which intergrated with CVBS(TP2825)/MIPI DSI/CSI/LVDS
HDMI video input/output interface, audio codec ES8396,
WIFI/BT(on RTL8723BS), Gsensor BMA250E and light&proximity
sensor STK3410.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
arch/arm64/boot/dts/rockchip/Makefile | 1 +
arch/arm64/boot/dts/rockchip/rk3368-px5.dts | 304 +++++++++++++++++++++
3 files changed, 309 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-px5.dts
diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
index e680105..06de682 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.txt
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -107,6 +107,10 @@ Rockchip platforms device tree bindings
Required root node properties:
- compatible = "rockchip,r88", "rockchip,rk3368";
+- Rockchip PX5 board:
+ Required root node properties:
+ - compatible = "rockchip,px5", "rockchip,rk3368";
+
- Rockchip RK3228 Evaluation board:
Required root node properties:
- compatible = "rockchip,rk3228-evb", "rockchip,rk3228";
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 7037a16..2fddf70 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -1,6 +1,7 @@
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-evb-act8846.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-geekbox.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb
always := $(dtb-y)
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-px5.dts b/arch/arm64/boot/dts/rockchip/rk3368-px5.dts
new file mode 100644
index 0000000..d862667
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3368-px5.dts
@@ -0,0 +1,304 @@
+/*
+ * Copyright (c) 2016 Fuzhou Rockchip Electronics Co., Ltd
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "rk3368.dtsi"
+#include <dt-bindings/input/input.h>
+
+/ {
+ model = "Rockchip PX5";
+ compatible = "rockchip,px5", "rockchip,rk3368";
+
+ chosen {
+ stdout-path = "serial4:115200n8";
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x80000000>;
+ };
+
+ keys: gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwr_key>;
+
+ power {
+ gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
+ label = "GPIO Power";
+ linux,code = <KEY_POWER>;
+ wakeup-source;
+ };
+ };
+
+ vcc_sys: vcc-sys-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_sys";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&emmc {
+ status = "okay";
+ bus-width = <8>;
+ cap-mmc-highspeed;
+ clock-frequency = <150000000>;
+ disable-wp;
+ keep-power-in-suspend;
+ non-removable;
+ num-slots = <1>;
+ vmmc-supply = <&vcc_io>;
+ vqmmc-supply = <&vcc18_flash>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&emmc_clk>, <&emmc_cmd>, <&emmc_bus8>;
+};
+
+&i2c0 {
+ status = "okay";
+
+ rk808: pmic@1b {
+ compatible = "rockchip,rk808";
+ reg = <0x1b>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_int>, <&pmic_sleep>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
+ rockchip,system-power-controller;
+ vcc1-supply = <&vcc_sys>;
+ vcc2-supply = <&vcc_sys>;
+ vcc3-supply = <&vcc_sys>;
+ vcc4-supply = <&vcc_sys>;
+ vcc6-supply = <&vcc_sys>;
+ vcc7-supply = <&vcc_sys>;
+ vcc8-supply = <&vcc_io>;
+ vcc9-supply = <&vcc_sys>;
+ vcc10-supply = <&vcc_sys>;
+ vcc11-supply = <&vcc_sys>;
+ vcc12-supply = <&vcc_io>;
+ clock-output-names = "xin32k", "rk808-clkout2";
+ #clock-cells = <1>;
+
+ regulators {
+ vdd_cpu: DCDC_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-name = "vdd_cpu";
+ };
+
+ vdd_log: DCDC_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <700000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-name = "vdd_log";
+ };
+
+ vcc_ddr: DCDC_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc_ddr";
+ };
+
+ vcc_io: DCDC_REG4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_io";
+ };
+
+ vcc18_flash: LDO_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc18_flash";
+ };
+
+ vcca_33: LDO_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcca_33";
+ };
+
+ vdd_10: LDO_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-name = "vdd_10";
+ };
+
+ avdd_33: LDO_REG4 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "avdd_33";
+ };
+
+ vccio_sd: LDO_REG5 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vccio_sd";
+ };
+
+ vdd10_lcd: LDO_REG6 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-name = "vdd10_lcd";
+ };
+
+ vcc_18: LDO_REG7 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc_18";
+ };
+
+ vcc18_lcd: LDO_REG8 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc18_lcd";
+ };
+
+ vcc_sd: SWITCH_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc_sd";
+ };
+
+ vcc33_lcd: SWITCH_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc33_lcd";
+ };
+ };
+ };
+};
+
+&i2c1 {
+ status = "okay";
+
+ /* Accelerometer */
+ bma250@18 {
+ compatible = "bma250";
+ reg = <0x18>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
+ };
+
+ stk3410@48 {
+ compatible = "STK3310";
+ reg = <0x48>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+ };
+};
+
+&i2c2 {
+ status = "okay";
+
+ gsl1680: touchscreen@40 {
+ compatible = "gsl1680";
+ reg = <0x40>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
+ power-gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>;
+ touchscreen-size-x = <800>;
+ touchscreen-size-y = <1280>;
+ silead,max-fingers = <5>;
+ };
+};
+
+&pinctrl {
+
+ keys {
+ pwr_key: pwr-key {
+ rockchip,pins = <0 2 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
+ pmic {
+ pmic_sleep: pmic-sleep {
+ rockchip,pins = <0 0 RK_FUNC_2 &pcfg_pull_none>;
+ };
+
+ pmic_int: pmic-int {
+ rockchip,pins = <0 5 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+};
+
+&tsadc {
+ status = "okay";
+ rockchip,hw-tshut-mode = <0>; /* CRU */
+ rockchip,hw-tshut-polarity = <1>; /* high */
+};
+
+&uart4 {
+ status = "okay";
+};
+
+&usb_host0_ehci {
+ status = "okay";
+};
+
+&usb_otg {
+ status = "okay";
+};
+
+&wdt {
+ status = "okay";
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:15 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 9:15 UTC (permalink / raw)
To: Andy Yan; +Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland
Hi Andy,
Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> PX3 board is designed by Rockchip for automotive field,
> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> video input/output interface, WIFI/BT/GPS(on a module
> named S500 which based on MT6620), Gsensor BMA250E and
> light&proximity sensor STK3410.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/rk3188-px3.dts | 337
> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> b/Documentation/devicetree/bindings/arm/rockchip.txt index 6668645..e680105
> 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
> Required root node properties:
> - compatible = "radxa,rock", "rockchip,rk3188";
>
> +- Rockchip PX3 board:
> + Required root node properties:
> + - compatible = "rockchip,px3", "rockchip,rk3188";
Just like to confirm the naming.
I read the announcement of both the PX3 and PX5 socs, are the boards really
also named only px3 + px5 - same as the socs they carry, or are they more
likely to be called px3-evb or similar?
The dts themself look fine on first glance.
Thanks
Heiko
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:15 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 9:15 UTC (permalink / raw)
To: Andy Yan
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
briannorris-F7+t8E8rja9g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8
Hi Andy,
Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> PX3 board is designed by Rockchip for automotive field,
> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> video input/output interface, WIFI/BT/GPS(on a module
> named S500 which based on MT6620), Gsensor BMA250E and
> light&proximity sensor STK3410.
>
> Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
>
> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/rk3188-px3.dts | 337
> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> b/Documentation/devicetree/bindings/arm/rockchip.txt index 6668645..e680105
> 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
> Required root node properties:
> - compatible = "radxa,rock", "rockchip,rk3188";
>
> +- Rockchip PX3 board:
> + Required root node properties:
> + - compatible = "rockchip,px3", "rockchip,rk3188";
Just like to confirm the naming.
I read the announcement of both the PX3 and PX5 socs, are the boards really
also named only px3 + px5 - same as the socs they carry, or are they more
likely to be called px3-evb or similar?
The dts themself look fine on first glance.
Thanks
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
2016-09-10 9:15 ` Heiko Stuebner
@ 2016-09-10 9:37 ` Andy Yan
-1 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2016-09-10 9:37 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland
Hi Heiko:
On 2016年09月10日 17:15, Heiko Stuebner wrote:
> Hi Andy,
>
> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
>> PX3 board is designed by Rockchip for automotive field,
>> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
>> video input/output interface, WIFI/BT/GPS(on a module
>> named S500 which based on MT6620), Gsensor BMA250E and
>> light&proximity sensor STK3410.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>>
>> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/rk3188-px3.dts | 337
>> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
>> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
>> b/Documentation/devicetree/bindings/arm/rockchip.txt index 6668645..e680105
>> 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
>> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
>> Required root node properties:
>> - compatible = "radxa,rock", "rockchip,rk3188";
>>
>> +- Rockchip PX3 board:
>> + Required root node properties:
>> + - compatible = "rockchip,px3", "rockchip,rk3188";
> Just like to confirm the naming.
>
> I read the announcement of both the PX3 and PX5 socs, are the boards really
> also named only px3 + px5 - same as the socs they carry, or are they more
> likely to be called px3-evb or similar?
>
> The dts themself look fine on first glance.
>
We call them px3 or px5 development board in the internal development.
Of course I can change them to px3/px5-evb if you desire.
> Thanks
> Heiko
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:37 ` Andy Yan
0 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2016-09-10 9:37 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
briannorris-F7+t8E8rja9g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8
Hi Heiko:
On 2016年09月10日 17:15, Heiko Stuebner wrote:
> Hi Andy,
>
> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
>> PX3 board is designed by Rockchip for automotive field,
>> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
>> video input/output interface, WIFI/BT/GPS(on a module
>> named S500 which based on MT6620), Gsensor BMA250E and
>> light&proximity sensor STK3410.
>>
>> Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>> ---
>>
>> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/rk3188-px3.dts | 337
>> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
>> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
>> b/Documentation/devicetree/bindings/arm/rockchip.txt index 6668645..e680105
>> 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
>> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
>> Required root node properties:
>> - compatible = "radxa,rock", "rockchip,rk3188";
>>
>> +- Rockchip PX3 board:
>> + Required root node properties:
>> + - compatible = "rockchip,px3", "rockchip,rk3188";
> Just like to confirm the naming.
>
> I read the announcement of both the PX3 and PX5 socs, are the boards really
> also named only px3 + px5 - same as the socs they carry, or are they more
> likely to be called px3-evb or similar?
>
> The dts themself look fine on first glance.
>
We call them px3 or px5 development board in the internal development.
Of course I can change them to px3/px5-evb if you desire.
> Thanks
> Heiko
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:45 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 9:45 UTC (permalink / raw)
To: Andy Yan; +Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland
Am Samstag, 10. September 2016, 17:37:41 CEST schrieb Andy Yan:
> Hi Heiko:
>
> On 2016年09月10日 17:15, Heiko Stuebner wrote:
> > Hi Andy,
> >
> > Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> >> PX3 board is designed by Rockchip for automotive field,
> >> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> >> video input/output interface, WIFI/BT/GPS(on a module
> >> named S500 which based on MT6620), Gsensor BMA250E and
> >> light&proximity sensor STK3410.
> >>
> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> >> ---
> >>
> >> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
> >> arch/arm/boot/dts/Makefile | 1 +
> >> arch/arm/boot/dts/rk3188-px3.dts | 337
> >>
> >> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
> >>
> >> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> >> b/Documentation/devicetree/bindings/arm/rockchip.txt index
> >> 6668645..e680105
> >> 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> >> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
> >>
> >> Required root node properties:
> >> - compatible = "radxa,rock", "rockchip,rk3188";
> >>
> >> +- Rockchip PX3 board:
> >> + Required root node properties:
> >> + - compatible = "rockchip,px3", "rockchip,rk3188";
> >
> > Just like to confirm the naming.
> >
> > I read the announcement of both the PX3 and PX5 socs, are the boards
> > really
> > also named only px3 + px5 - same as the socs they carry, or are they more
> > likely to be called px3-evb or similar?
> >
> > The dts themself look fine on first glance.
>
> We call them px3 or px5 development board in the internal development.
> Of course I can change them to px3/px5-evb if you desire.
I think I would prefer that ... to not confuse socs with boards :-)
All the other Rockchip devboards are always called evb, so I guess it would be
the same for the px3+px5 ones.
so I guess the compatible would be
- compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188";
Heiko
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:45 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 9:45 UTC (permalink / raw)
To: Andy Yan
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
briannorris-F7+t8E8rja9g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8
Am Samstag, 10. September 2016, 17:37:41 CEST schrieb Andy Yan:
> Hi Heiko:
>
> On 2016年09月10日 17:15, Heiko Stuebner wrote:
> > Hi Andy,
> >
> > Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> >> PX3 board is designed by Rockchip for automotive field,
> >> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> >> video input/output interface, WIFI/BT/GPS(on a module
> >> named S500 which based on MT6620), Gsensor BMA250E and
> >> light&proximity sensor STK3410.
> >>
> >> Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> >> ---
> >>
> >> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
> >> arch/arm/boot/dts/Makefile | 1 +
> >> arch/arm/boot/dts/rk3188-px3.dts | 337
> >>
> >> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
> >>
> >> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> >> b/Documentation/devicetree/bindings/arm/rockchip.txt index
> >> 6668645..e680105
> >> 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> >> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
> >>
> >> Required root node properties:
> >> - compatible = "radxa,rock", "rockchip,rk3188";
> >>
> >> +- Rockchip PX3 board:
> >> + Required root node properties:
> >> + - compatible = "rockchip,px3", "rockchip,rk3188";
> >
> > Just like to confirm the naming.
> >
> > I read the announcement of both the PX3 and PX5 socs, are the boards
> > really
> > also named only px3 + px5 - same as the socs they carry, or are they more
> > likely to be called px3-evb or similar?
> >
> > The dts themself look fine on first glance.
>
> We call them px3 or px5 development board in the internal development.
> Of course I can change them to px3/px5-evb if you desire.
I think I would prefer that ... to not confuse socs with boards :-)
All the other Rockchip devboards are always called evb, so I guess it would be
the same for the px3+px5 ones.
so I guess the compatible would be
- compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188";
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
2016-09-10 9:45 ` Heiko Stuebner
@ 2016-09-10 9:46 ` Andy Yan
-1 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2016-09-10 9:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland
Hi Heiko:
On 2016年09月10日 17:45, Heiko Stuebner wrote:
> Am Samstag, 10. September 2016, 17:37:41 CEST schrieb Andy Yan:
>> Hi Heiko:
>>
>> On 2016年09月10日 17:15, Heiko Stuebner wrote:
>>> Hi Andy,
>>>
>>> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
>>>> PX3 board is designed by Rockchip for automotive field,
>>>> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
>>>> video input/output interface, WIFI/BT/GPS(on a module
>>>> named S500 which based on MT6620), Gsensor BMA250E and
>>>> light&proximity sensor STK3410.
>>>>
>>>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>>> ---
>>>>
>>>> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
>>>> arch/arm/boot/dts/Makefile | 1 +
>>>> arch/arm/boot/dts/rk3188-px3.dts | 337
>>>>
>>>> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
>>>>
>>>> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> b/Documentation/devicetree/bindings/arm/rockchip.txt index
>>>> 6668645..e680105
>>>> 100644
>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
>>>>
>>>> Required root node properties:
>>>> - compatible = "radxa,rock", "rockchip,rk3188";
>>>>
>>>> +- Rockchip PX3 board:
>>>> + Required root node properties:
>>>> + - compatible = "rockchip,px3", "rockchip,rk3188";
>>> Just like to confirm the naming.
>>>
>>> I read the announcement of both the PX3 and PX5 socs, are the boards
>>> really
>>> also named only px3 + px5 - same as the socs they carry, or are they more
>>> likely to be called px3-evb or similar?
>>>
>>> The dts themself look fine on first glance.
>> We call them px3 or px5 development board in the internal development.
>> Of course I can change them to px3/px5-evb if you desire.
> I think I would prefer that ... to not confuse socs with boards :-)
> All the other Rockchip devboards are always called evb, so I guess it would be
> the same for the px3+px5 ones.
>
> so I guess the compatible would be
> - compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188";
>
Okay, I will send a V2 with that
> Heiko
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 9:46 ` Andy Yan
0 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2016-09-10 9:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
briannorris-F7+t8E8rja9g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8
Hi Heiko:
On 2016年09月10日 17:45, Heiko Stuebner wrote:
> Am Samstag, 10. September 2016, 17:37:41 CEST schrieb Andy Yan:
>> Hi Heiko:
>>
>> On 2016年09月10日 17:15, Heiko Stuebner wrote:
>>> Hi Andy,
>>>
>>> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
>>>> PX3 board is designed by Rockchip for automotive field,
>>>> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
>>>> video input/output interface, WIFI/BT/GPS(on a module
>>>> named S500 which based on MT6620), Gsensor BMA250E and
>>>> light&proximity sensor STK3410.
>>>>
>>>> Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>>>> ---
>>>>
>>>> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
>>>> arch/arm/boot/dts/Makefile | 1 +
>>>> arch/arm/boot/dts/rk3188-px3.dts | 337
>>>>
>>>> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
>>>>
>>>> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> b/Documentation/devicetree/bindings/arm/rockchip.txt index
>>>> 6668645..e680105
>>>> 100644
>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
>>>>
>>>> Required root node properties:
>>>> - compatible = "radxa,rock", "rockchip,rk3188";
>>>>
>>>> +- Rockchip PX3 board:
>>>> + Required root node properties:
>>>> + - compatible = "rockchip,px3", "rockchip,rk3188";
>>> Just like to confirm the naming.
>>>
>>> I read the announcement of both the PX3 and PX5 socs, are the boards
>>> really
>>> also named only px3 + px5 - same as the socs they carry, or are they more
>>> likely to be called px3-evb or similar?
>>>
>>> The dts themself look fine on first glance.
>> We call them px3 or px5 development board in the internal development.
>> Of course I can change them to px3/px5-evb if you desire.
> I think I would prefer that ... to not confuse socs with boards :-)
> All the other Rockchip devboards are always called evb, so I guess it would be
> the same for the px3+px5 ones.
>
> so I guess the compatible would be
> - compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188";
>
Okay, I will send a V2 with that
> Heiko
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
2016-09-10 9:01 ` Andy Yan
` (2 preceding siblings ...)
(?)
@ 2016-09-10 10:03 ` Heiko Stuebner
2016-09-10 10:07 ` Heiko Stuebner
-1 siblings, 1 reply; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 10:03 UTC (permalink / raw)
To: Andy Yan; +Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland
Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> PX3 board is designed by Rockchip for automotive field,
> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> video input/output interface, WIFI/BT/GPS(on a module
> named S500 which based on MT6620), Gsensor BMA250E and
> light&proximity sensor STK3410.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
[...]
> diff --git a/arch/arm/boot/dts/rk3188-px3.dts
> b/arch/arm/boot/dts/rk3188-px3.dts new file mode 100644
> index 0000000..ece45d7
> --- /dev/null
> +++ b/arch/arm/boot/dts/rk3188-px3.dts
> @@ -0,0 +1,337 @@
> +/*
> + * Copyright (c) 2016 Andy Yan <andy.yan@rock-chips.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +#include <dt-bindings/input/input.h>
> +#include "rk3188.dtsi"
> +
> +/ {
> + model = "Rockchip PX3";
> + compatible = "rockchip,px3", "rockchip,rk3188";
> +
> + chosen {
> + bootargs = "console=ttyS2,115200 earlyprintk";
> + };
setting bootargs isn't favoured, you can instead use
stdout-path = "serial2:115200n8";
to define the default console
> +&i2c0 {
> + status = "okay";
> +
> + /* Accelerometer */
> + bma250@18 {
> + compatible = "bma250";
> + reg = <0x18>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> + };
driver seems to be missing a devicetree binding (module_id_table
and dt-binding document)
> + stk3410@48 {
> + compatible = "STK3310";
> + reg = <0x48>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> + };
> +};
driver seems to be missing a devicetree binding (module_id_table
and dt-binding document)
> +&i2c2 {
> + gsl1680: touchscreen@40 {
> + compatible = "gsl1680";
> + reg = <0x40>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> + power-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> + touchscreen-size-x = <800>;
> + touchscreen-size-y = <1280>;
> + silead,max-fingers = <5>;
> + };
this should probably be
"silead,gsl1680"
see https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
2016-09-10 10:03 ` Heiko Stuebner
@ 2016-09-10 10:07 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 10:07 UTC (permalink / raw)
To: Andy Yan; +Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland
Am Samstag, 10. September 2016, 12:03:38 CEST schrieb Heiko Stuebner:
> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> > PX3 board is designed by Rockchip for automotive field,
> > which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> > video input/output interface, WIFI/BT/GPS(on a module
> > named S500 which based on MT6620), Gsensor BMA250E and
> > light&proximity sensor STK3410.
> >
> > Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/rk3188-px3.dts
> > b/arch/arm/boot/dts/rk3188-px3.dts new file mode 100644
> > index 0000000..ece45d7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/rk3188-px3.dts
> > @@ -0,0 +1,337 @@
> > +/*
> > + * Copyright (c) 2016 Andy Yan <andy.yan@rock-chips.com>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + * a) This file is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of the
> > + * License, or (at your option) any later version.
> > + *
> > + * This file is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + * b) Permission is hereby granted, free of charge, to any person
> > + * obtaining a copy of this software and associated documentation
> > + * files (the "Software"), to deal in the Software without
> > + * restriction, including without limitation the rights to use,
> > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > + * sell copies of the Software, and to permit persons to whom the
> > + * Software is furnished to do so, subject to the following
> > + * conditions:
> > + *
> > + * The above copyright notice and this permission notice shall be
> > + * included in all copies or substantial portions of the Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + * OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/input/input.h>
> > +#include "rk3188.dtsi"
> > +
> > +/ {
> > + model = "Rockchip PX3";
> > + compatible = "rockchip,px3", "rockchip,rk3188";
> > +
> > + chosen {
> > + bootargs = "console=ttyS2,115200 earlyprintk";
> > + };
>
> setting bootargs isn't favoured, you can instead use
> stdout-path = "serial2:115200n8";
>
> to define the default console
>
> > +&i2c0 {
> > + status = "okay";
> > +
> > + /* Accelerometer */
> > + bma250@18 {
> > + compatible = "bma250";
> > + reg = <0x18>;
> > + interrupt-parent = <&gpio0>;
> > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> > + };
>
> driver seems to be missing a devicetree binding (module_id_table
> and dt-binding document)
found it, should be
bosch,bma250
according to Documentation/devicetree/bindings/iio/accel/bma180.txt
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 10:07 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 10:07 UTC (permalink / raw)
To: Andy Yan
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
briannorris-F7+t8E8rja9g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8
Am Samstag, 10. September 2016, 12:03:38 CEST schrieb Heiko Stuebner:
> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> > PX3 board is designed by Rockchip for automotive field,
> > which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> > video input/output interface, WIFI/BT/GPS(on a module
> > named S500 which based on MT6620), Gsensor BMA250E and
> > light&proximity sensor STK3410.
> >
> > Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/rk3188-px3.dts
> > b/arch/arm/boot/dts/rk3188-px3.dts new file mode 100644
> > index 0000000..ece45d7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/rk3188-px3.dts
> > @@ -0,0 +1,337 @@
> > +/*
> > + * Copyright (c) 2016 Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + * a) This file is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of the
> > + * License, or (at your option) any later version.
> > + *
> > + * This file is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + * b) Permission is hereby granted, free of charge, to any person
> > + * obtaining a copy of this software and associated documentation
> > + * files (the "Software"), to deal in the Software without
> > + * restriction, including without limitation the rights to use,
> > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > + * sell copies of the Software, and to permit persons to whom the
> > + * Software is furnished to do so, subject to the following
> > + * conditions:
> > + *
> > + * The above copyright notice and this permission notice shall be
> > + * included in all copies or substantial portions of the Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + * OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/input/input.h>
> > +#include "rk3188.dtsi"
> > +
> > +/ {
> > + model = "Rockchip PX3";
> > + compatible = "rockchip,px3", "rockchip,rk3188";
> > +
> > + chosen {
> > + bootargs = "console=ttyS2,115200 earlyprintk";
> > + };
>
> setting bootargs isn't favoured, you can instead use
> stdout-path = "serial2:115200n8";
>
> to define the default console
>
> > +&i2c0 {
> > + status = "okay";
> > +
> > + /* Accelerometer */
> > + bma250@18 {
> > + compatible = "bma250";
> > + reg = <0x18>;
> > + interrupt-parent = <&gpio0>;
> > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> > + };
>
> driver seems to be missing a devicetree binding (module_id_table
> and dt-binding document)
found it, should be
bosch,bma250
according to Documentation/devicetree/bindings/iio/accel/bma180.txt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
2016-09-10 10:07 ` Heiko Stuebner
(?)
@ 2016-09-10 13:10 ` 闫孝军
2016-09-10 13:27 ` Heiko Stuebner
-1 siblings, 1 reply; 17+ messages in thread
From: 闫孝军 @ 2016-09-10 13:10 UTC (permalink / raw)
To: HeikoStübner
Cc: devicetree, briannorris, linux-kernel, robh+dt, mark.rutland
[-- Attachment #1: Type: text/plain, Size: 4154 bytes --]
Hi Heiko：
From: Heiko Stuebner
Date: 2016-09-10 18:07
To: Andy Yan
CC: devicetree; briannorris; linux-kernel; robh+dt; mark.rutland
Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
Am Samstag, 10. September 2016, 12:03:38 CEST schrieb Heiko Stuebner:
> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> > PX3 board is designed by Rockchip for automotive field,
> > which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> > video input/output interface, WIFI/BT/GPS(on a module
> > named S500 which based on MT6620), Gsensor BMA250E and
> > light&proximity sensor STK3410.
> >
> > Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/rk3188-px3.dts
> > b/arch/arm/boot/dts/rk3188-px3.dts new file mode 100644
> > index 0000000..ece45d7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/rk3188-px3.dts
> > @@ -0,0 +1,337 @@
> > +/*
> > + * Copyright (c) 2016 Andy Yan <andy.yan@rock-chips.com>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + * a) This file is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of the
> > + * License, or (at your option) any later version.
> > + *
> > + * This file is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + * b) Permission is hereby granted, free of charge, to any person
> > + * obtaining a copy of this software and associated documentation
> > + * files (the "Software"), to deal in the Software without
> > + * restriction, including without limitation the rights to use,
> > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > + * sell copies of the Software, and to permit persons to whom the
> > + * Software is furnished to do so, subject to the following
> > + * conditions:
> > + *
> > + * The above copyright notice and this permission notice shall be
> > + * included in all copies or substantial portions of the Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + * OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/input/input.h>
> > +#include "rk3188.dtsi"
> > +
> > +/ {
> > + model = "Rockchip PX3";
> > + compatible = "rockchip,px3", "rockchip,rk3188";
> > +
> > + chosen {
> > + bootargs = "console=ttyS2,115200 earlyprintk";
> > + };
>
> setting bootargs isn't favoured, you can instead use
> stdout-path = "serial2:115200n8";
>
> to define the default console
>
> > +&i2c0 {
> > + status = "okay";
> > +
> > + /* Accelerometer */
> > + bma250@18 {
> > + compatible = "bma250";
> > + reg = <0x18>;
> > + interrupt-parent = <&gpio0>;
> > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> > + };
>
> driver seems to be missing a devicetree binding (module_id_table
> and dt-binding document)
found it, should be
bosch,bma250
according to Documentation/devicetree/bindings/iio/accel/bma180.txt
But I found the i2c_device_id in the source code is "bma250", not "bosch,bma250"
according to drivers/iio/accel/bma180.c
[-- Attachment #2: Type: text/html, Size: 7920 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 13:27 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 13:27 UTC (permalink / raw)
To: 闫孝军
Cc: devicetree, briannorris, linux-kernel, robh+dt, mark. rutland
Hi Andy,
Am Samstag, 10. September 2016, 21:10:35 CEST schrieb 闫孝军:
> Hi Heiko：
> From: Heiko Stuebner
> Date: 2016-09-10 18:07
> To: Andy Yan
> CC: devicetree; briannorris; linux-kernel; robh+dt; mark.rutland
> Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
> Am Samstag, 10. September 2016, 12:03:38 CEST schrieb Heiko Stuebner:
>
> > Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> >
> > > PX3 board is designed by Rockchip for automotive field,
> > > which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> > > video input/output interface, WIFI/BT/GPS(on a module
> > > named S500 which based on MT6620), Gsensor BMA250E and
> > > light&proximity sensor STK3410.
> > >
> > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> >
> >
> > [...]
> >
> >
> > > diff --git a/arch/arm/boot/dts/rk3188-px3.dts
> > > b/arch/arm/boot/dts/rk3188-px3.dts new file mode 100644
> > > index 0000000..ece45d7
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/rk3188-px3.dts
> > > @@ -0,0 +1,337 @@
> > > +/*
> > > + * Copyright (c) 2016 Andy Yan <andy.yan@rock-chips.com>
> > > + *
> > > + * This file is dual-licensed: you can use it either under the terms
> > > + * of the GPL or the X11 license, at your option. Note that this dual
> > > + * licensing only applies to this file, and not this project as a
> > > + * whole.
> > > + *
> > > + * a) This file is free software; you can redistribute it and/or
> > > + * modify it under the terms of the GNU General Public License as
> > > + * published by the Free Software Foundation; either version 2 of
> > > the
> > > + * License, or (at your option) any later version.
> > > + *
> > > + * This file is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * Or, alternatively,
> > > + *
> > > + * b) Permission is hereby granted, free of charge, to any person
> > > + * obtaining a copy of this software and associated documentation
> > > + * files (the "Software"), to deal in the Software without
> > > + * restriction, including without limitation the rights to use,
> > > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > > + * sell copies of the Software, and to permit persons to whom the
> > > + * Software is furnished to do so, subject to the following
> > > + * conditions:
> > > + *
> > > + * The above copyright notice and this permission notice shall be
> > > + * included in all copies or substantial portions of the Software.
> > > + *
> > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > > + * OTHER DEALINGS IN THE SOFTWARE.
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include <dt-bindings/input/input.h>
> > > +#include "rk3188.dtsi"
> > > +
> > > +/ {
> > > + model = "Rockchip PX3";
> > > + compatible = "rockchip,px3", "rockchip,rk3188";
> > > +
> > > + chosen {
> > > + bootargs = "console=ttyS2,115200 earlyprintk";
> > > + };
> >
> >
> > setting bootargs isn't favoured, you can instead use
> > stdout-path = "serial2:115200n8";
> >
> > to define the default console
> >
> >
> > > +&i2c0 {
> > > + status = "okay";
> > > +
> > > + /* Accelerometer */
> > > + bma250@18 {
> > > + compatible = "bma250";
> > > + reg = <0x18>;
> > > + interrupt-parent = <&gpio0>;
> > > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> > > + };
> >
> >
> > driver seems to be missing a devicetree binding (module_id_table
> > and dt-binding document)
>
>
> found it, should be
>
> bosch,bma250
>
> according to Documentation/devicetree/bindings/iio/accel/bma180.txt
>
>
>
>
> But I found the i2c_device_id in the source code is "bma250", not
> "bosch,bma250"
> according to drivers/iio/accel/bma180.c
According to [0]:
"If it is i2c, i2c has the quirk that it will match drv name to
compatible string with vendor prefix dropped."
so the driver itself doesn't need to specifiy the full compatible after all.
Still there should be a binding document and the devicetree side should
_always_ specify the full vendor,chip format.
So you do "bosch,bma250" in the dts according to the binding document, the
i2c-core automatically tries "bma250" from that to match against the driver.
The STK3310 can be done similarly, you only need to add a dts binding
document.
[0] https://patchwork.kernel.org/patch/9285405/
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
@ 2016-09-10 13:27 ` Heiko Stuebner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stuebner @ 2016-09-10 13:27 UTC (permalink / raw)
To: 闫孝军
Cc: devicetree, briannorris, linux-kernel, robh+dt, mark. rutland
Hi Andy,
Am Samstag, 10. September 2016, 21:10:35 CEST schrieb 闫孝军:
> Hi Heiko：
> From: Heiko Stuebner
> Date: 2016-09-10 18:07
> To: Andy Yan
> CC: devicetree; briannorris; linux-kernel; robh+dt; mark.rutland
> Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
> Am Samstag, 10. September 2016, 12:03:38 CEST schrieb Heiko Stuebner:
>
> > Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> >
> > > PX3 board is designed by Rockchip for automotive field,
> > > which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> > > video input/output interface, WIFI/BT/GPS(on a module
> > > named S500 which based on MT6620), Gsensor BMA250E and
> > > light&proximity sensor STK3410.
> > >
> > > Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> >
> >
> > [...]
> >
> >
> > > diff --git a/arch/arm/boot/dts/rk3188-px3.dts
> > > b/arch/arm/boot/dts/rk3188-px3.dts new file mode 100644
> > > index 0000000..ece45d7
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/rk3188-px3.dts
> > > @@ -0,0 +1,337 @@
> > > +/*
> > > + * Copyright (c) 2016 Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> > > + *
> > > + * This file is dual-licensed: you can use it either under the terms
> > > + * of the GPL or the X11 license, at your option. Note that this dual
> > > + * licensing only applies to this file, and not this project as a
> > > + * whole.
> > > + *
> > > + * a) This file is free software; you can redistribute it and/or
> > > + * modify it under the terms of the GNU General Public License as
> > > + * published by the Free Software Foundation; either version 2 of
> > > the
> > > + * License, or (at your option) any later version.
> > > + *
> > > + * This file is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * Or, alternatively,
> > > + *
> > > + * b) Permission is hereby granted, free of charge, to any person
> > > + * obtaining a copy of this software and associated documentation
> > > + * files (the "Software"), to deal in the Software without
> > > + * restriction, including without limitation the rights to use,
> > > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > > + * sell copies of the Software, and to permit persons to whom the
> > > + * Software is furnished to do so, subject to the following
> > > + * conditions:
> > > + *
> > > + * The above copyright notice and this permission notice shall be
> > > + * included in all copies or substantial portions of the Software.
> > > + *
> > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > > + * OTHER DEALINGS IN THE SOFTWARE.
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include <dt-bindings/input/input.h>
> > > +#include "rk3188.dtsi"
> > > +
> > > +/ {
> > > + model = "Rockchip PX3";
> > > + compatible = "rockchip,px3", "rockchip,rk3188";
> > > +
> > > + chosen {
> > > + bootargs = "console=ttyS2,115200 earlyprintk";
> > > + };
> >
> >
> > setting bootargs isn't favoured, you can instead use
> > stdout-path = "serial2:115200n8";
> >
> > to define the default console
> >
> >
> > > +&i2c0 {
> > > + status = "okay";
> > > +
> > > + /* Accelerometer */
> > > + bma250@18 {
> > > + compatible = "bma250";
> > > + reg = <0x18>;
> > > + interrupt-parent = <&gpio0>;
> > > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> > > + };
> >
> >
> > driver seems to be missing a devicetree binding (module_id_table
> > and dt-binding document)
>
>
> found it, should be
>
> bosch,bma250
>
> according to Documentation/devicetree/bindings/iio/accel/bma180.txt
>
>
>
>
> But I found the i2c_device_id in the source code is "bma250", not
> "bosch,bma250"
> according to drivers/iio/accel/bma180.c
According to [0]:
"If it is i2c, i2c has the quirk that it will match drv name to
compatible string with vendor prefix dropped."
so the driver itself doesn't need to specifiy the full compatible after all.
Still there should be a binding document and the devicetree side should
_always_ specify the full vendor,chip format.
So you do "bosch,bma250" in the dts according to the binding document, the
i2c-core automatically tries "bma250" from that to match against the driver.
The STK3310 can be done similarly, you only need to add a dts binding
document.
[0] https://patchwork.kernel.org/patch/9285405/
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2016-09-10 13:27 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-10 9:01 [PATCH 1/2] ARM: dts: add rockchip PX3 board Andy Yan
2016-09-10 9:01 ` Andy Yan
2016-09-10 9:05 ` [PATCH 2/2] arm64: dts: rockchip: Add PX5 board Andy Yan
2016-09-10 9:15 ` [PATCH 1/2] ARM: dts: add rockchip PX3 board Heiko Stuebner
2016-09-10 9:15 ` Heiko Stuebner
2016-09-10 9:37 ` Andy Yan
2016-09-10 9:37 ` Andy Yan
2016-09-10 9:45 ` Heiko Stuebner
2016-09-10 9:45 ` Heiko Stuebner
2016-09-10 9:46 ` Andy Yan
2016-09-10 9:46 ` Andy Yan
2016-09-10 10:03 ` Heiko Stuebner
2016-09-10 10:07 ` Heiko Stuebner
2016-09-10 10:07 ` Heiko Stuebner
2016-09-10 13:10 ` 闫孝军
2016-09-10 13:27 ` Heiko Stuebner
2016-09-10 13:27 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.