* [PATCH] video: fbdev: add missing \n at end of printk error message
@ 2016-09-12 10:24 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2016-09-12 10:24 UTC (permalink / raw)
To: Kristoffer Ericson, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The message is missing a \n, add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/s1d13xxxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
index 96aa46d..6a271d8 100644
--- a/drivers/video/fbdev/s1d13xxxfb.c
+++ b/drivers/video/fbdev/s1d13xxxfb.c
@@ -929,7 +929,7 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
s1dfb->disp_save = kmalloc(info->fix.smem_len, GFP_KERNEL);
if (!s1dfb->disp_save) {
- printk(KERN_ERR PFX "no memory to save screen");
+ printk(KERN_ERR PFX "no memory to save screen\n");
return -ENOMEM;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: fbdev: add missing \n at end of printk error message
@ 2016-09-12 10:24 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2016-09-12 10:24 UTC (permalink / raw)
To: Kristoffer Ericson, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The message is missing a \n, add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/s1d13xxxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
index 96aa46d..6a271d8 100644
--- a/drivers/video/fbdev/s1d13xxxfb.c
+++ b/drivers/video/fbdev/s1d13xxxfb.c
@@ -929,7 +929,7 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
s1dfb->disp_save = kmalloc(info->fix.smem_len, GFP_KERNEL);
if (!s1dfb->disp_save) {
- printk(KERN_ERR PFX "no memory to save screen");
+ printk(KERN_ERR PFX "no memory to save screen\n");
return -ENOMEM;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: add missing \n at end of printk error message
2016-09-12 10:24 ` Colin King
@ 2016-09-27 8:08 ` Tomi Valkeinen
-1 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2016-09-27 8:08 UTC (permalink / raw)
To: Colin King, Kristoffer Ericson, linux-fbdev; +Cc: linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]
On 12/09/16 13:24, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The message is missing a \n, add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/video/fbdev/s1d13xxxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
> index 96aa46d..6a271d8 100644
> --- a/drivers/video/fbdev/s1d13xxxfb.c
> +++ b/drivers/video/fbdev/s1d13xxxfb.c
> @@ -929,7 +929,7 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
> s1dfb->disp_save = kmalloc(info->fix.smem_len, GFP_KERNEL);
>
> if (!s1dfb->disp_save) {
> - printk(KERN_ERR PFX "no memory to save screen");
> + printk(KERN_ERR PFX "no memory to save screen\n");
> return -ENOMEM;
> }
>
>
Thanks, queued for 4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: add missing \n at end of printk error message
@ 2016-09-27 8:08 ` Tomi Valkeinen
0 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2016-09-27 8:08 UTC (permalink / raw)
To: Colin King, Kristoffer Ericson, linux-fbdev; +Cc: linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]
On 12/09/16 13:24, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The message is missing a \n, add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/video/fbdev/s1d13xxxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
> index 96aa46d..6a271d8 100644
> --- a/drivers/video/fbdev/s1d13xxxfb.c
> +++ b/drivers/video/fbdev/s1d13xxxfb.c
> @@ -929,7 +929,7 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
> s1dfb->disp_save = kmalloc(info->fix.smem_len, GFP_KERNEL);
>
> if (!s1dfb->disp_save) {
> - printk(KERN_ERR PFX "no memory to save screen");
> + printk(KERN_ERR PFX "no memory to save screen\n");
> return -ENOMEM;
> }
>
>
Thanks, queued for 4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-27 8:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 10:24 [PATCH] video: fbdev: add missing \n at end of printk error message Colin King
2016-09-12 10:24 ` Colin King
2016-09-27 8:08 ` Tomi Valkeinen
2016-09-27 8:08 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.