All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-java][PATCH] xpp[23]: fix/remove bashism
@ 2016-09-12  8:14 Sujith H
  2016-09-12  9:47 ` sujith h
  0 siblings, 1 reply; 3+ messages in thread
From: Sujith H @ 2016-09-12  8:14 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

This was breaking on hosts with dash as /bin/sh.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 recipes-core/xml-commons/xpp2_2.1.10.bb    | 2 +-
 recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-core/xml-commons/xpp2_2.1.10.bb b/recipes-core/xml-commons/xpp2_2.1.10.bb
index d3baca4..c926722 100644
--- a/recipes-core/xml-commons/xpp2_2.1.10.bb
+++ b/recipes-core/xml-commons/xpp2_2.1.10.bb
@@ -19,7 +19,7 @@ do_compile() {
 
     sourcepath="src/java/drivers/jaxp11:src/java/drivers/sax2:src/java/impl/factory:src/java/impl/format:src/java/impl/node:src/java/impl/pullparser:src/java/impl/tag:src/java/intf"
 
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name "*.java"`
 
diff --git a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
index bedb8a9..f264022 100644
--- a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
+++ b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
@@ -19,7 +19,7 @@ do_compile() {
     mkdir -p build-oe
 
     sourcepath="src/java/api:src/java/builder:src/java/dom2_builder:src/java/mxp1_min:src/java/mxp1_standard:src/java/parser_pool:src/java/sax2_driver:src/java/serializer_impl:src/java/util:src/java/wrapper"
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name "*.java"`
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [meta-java][PATCH] xpp[23]: fix/remove bashism
  2016-09-12  8:14 [meta-java][PATCH] xpp[23]: fix/remove bashism Sujith H
@ 2016-09-12  9:47 ` sujith h
  2016-09-12 12:11   ` Maxin B. John
  0 siblings, 1 reply; 3+ messages in thread
From: sujith h @ 2016-09-12  9:47 UTC (permalink / raw)
  To: openembedded-devel

Hi,

Hope the patch looks ok. Else do let me know I can work on the same.

Thanks,
Sujith H

On Mon, Sep 12, 2016 at 1:44 PM, Sujith H <sujith.h@gmail.com> wrote:

> From: Christopher Larson <chris_larson@mentor.com>
>
> This was breaking on hosts with dash as /bin/sh.
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
>  recipes-core/xml-commons/xpp2_2.1.10.bb    | 2 +-
>  recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-core/xml-commons/xpp2_2.1.10.bb
> b/recipes-core/xml-commons/xpp2_2.1.10.bb
> index d3baca4..c926722 100644
> --- a/recipes-core/xml-commons/xpp2_2.1.10.bb
> +++ b/recipes-core/xml-commons/xpp2_2.1.10.bb
> @@ -19,7 +19,7 @@ do_compile() {
>
>      sourcepath="src/java/drivers/jaxp11:src/java/drivers/sax2:
> src/java/impl/factory:src/java/impl/format:src/java/
> impl/node:src/java/impl/pullparser:src/java/impl/tag:src/java/intf"
>
> -    findpath="${sourcepath//:/ }"
> +    findpath="$(echo "$sourcepath" | tr : " ")"
>
>      javac -sourcepath $sourcepath -d build-oe `find $findpath -name
> "*.java"`
>
> diff --git a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> index bedb8a9..f264022 100644
> --- a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> +++ b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> @@ -19,7 +19,7 @@ do_compile() {
>      mkdir -p build-oe
>
>      sourcepath="src/java/api:src/java/builder:src/java/dom2_
> builder:src/java/mxp1_min:src/java/mxp1_standard:src/java/
> parser_pool:src/java/sax2_driver:src/java/serializer_
> impl:src/java/util:src/java/wrapper"
> -    findpath="${sourcepath//:/ }"
> +    findpath="$(echo "$sourcepath" | tr : " ")"
>
>      javac -sourcepath $sourcepath -d build-oe `find $findpath -name
> "*.java"`
>
> --
> 1.9.1
>
>


-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [meta-java][PATCH] xpp[23]: fix/remove bashism
  2016-09-12  9:47 ` sujith h
@ 2016-09-12 12:11   ` Maxin B. John
  0 siblings, 0 replies; 3+ messages in thread
From: Maxin B. John @ 2016-09-12 12:11 UTC (permalink / raw)
  To: openembedded-devel

Hi Sujith,

On Mon, Sep 12, 2016 at 03:17:34PM +0530, sujith h wrote:
> Hi,
> 
> Hope the patch looks ok. Else do let me know I can work on the same.

Yes, it looks good. Pushed to master.

> Thanks,
> Sujith H

Best Regards,
Maxin

> On Mon, Sep 12, 2016 at 1:44 PM, Sujith H <sujith.h@gmail.com> wrote:
> 
> > From: Christopher Larson <chris_larson@mentor.com>
> >
> > This was breaking on hosts with dash as /bin/sh.
> >
> > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> > ---
> >  recipes-core/xml-commons/xpp2_2.1.10.bb    | 2 +-
> >  recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes-core/xml-commons/xpp2_2.1.10.bb
> > b/recipes-core/xml-commons/xpp2_2.1.10.bb
> > index d3baca4..c926722 100644
> > --- a/recipes-core/xml-commons/xpp2_2.1.10.bb
> > +++ b/recipes-core/xml-commons/xpp2_2.1.10.bb
> > @@ -19,7 +19,7 @@ do_compile() {
> >
> >      sourcepath="src/java/drivers/jaxp11:src/java/drivers/sax2:
> > src/java/impl/factory:src/java/impl/format:src/java/
> > impl/node:src/java/impl/pullparser:src/java/impl/tag:src/java/intf"
> >
> > -    findpath="${sourcepath//:/ }"
> > +    findpath="$(echo "$sourcepath" | tr : " ")"
> >
> >      javac -sourcepath $sourcepath -d build-oe `find $findpath -name
> > "*.java"`
> >
> > diff --git a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> > b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> > index bedb8a9..f264022 100644
> > --- a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> > +++ b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> > @@ -19,7 +19,7 @@ do_compile() {
> >      mkdir -p build-oe
> >
> >      sourcepath="src/java/api:src/java/builder:src/java/dom2_
> > builder:src/java/mxp1_min:src/java/mxp1_standard:src/java/
> > parser_pool:src/java/sax2_driver:src/java/serializer_
> > impl:src/java/util:src/java/wrapper"
> > -    findpath="${sourcepath//:/ }"
> > +    findpath="$(echo "$sourcepath" | tr : " ")"
> >
> >      javac -sourcepath $sourcepath -d build-oe `find $findpath -name
> > "*.java"`
> >
> > --
> > 1.9.1
> >
> >
> 
> 
> -- 
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-12 12:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12  8:14 [meta-java][PATCH] xpp[23]: fix/remove bashism Sujith H
2016-09-12  9:47 ` sujith h
2016-09-12 12:11   ` Maxin B. John

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.