* [PATCH][V2] dma-mapping: add in missing white space in error message text
@ 2016-09-12 13:09 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2016-09-12 13:09 UTC (permalink / raw)
To: Russell King, Vineet Gupta, Hans-Christian Noren Egtvedt,
Joerg Roedel, Robin Murphy, Jesper Nilsson, Krzysztof Kozlowski,
linux-arm-kernel
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A dev_warn message spans two lines and the literal string is missing
a white space between words. Add the white space and reformat the
message to not span multiple lines.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/arm/common/dmabounce.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 3012816..afeb5e3 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -546,9 +546,7 @@ void dmabounce_unregister_dev(struct device *dev)
set_dma_ops(dev, NULL);
if (!device_info) {
- dev_warn(dev,
- "Never registered with dmabounce but attempting"
- "to unregister!\n");
+ dev_warn(dev, "Never registered with dmabounce but attempting to unregister!\n");
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH][V2] dma-mapping: add in missing white space in error message text
@ 2016-09-12 13:09 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2016-09-12 13:09 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
A dev_warn message spans two lines and the literal string is missing
a white space between words. Add the white space and reformat the
message to not span multiple lines.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/arm/common/dmabounce.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 3012816..afeb5e3 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -546,9 +546,7 @@ void dmabounce_unregister_dev(struct device *dev)
set_dma_ops(dev, NULL);
if (!device_info) {
- dev_warn(dev,
- "Never registered with dmabounce but attempting"
- "to unregister!\n");
+ dev_warn(dev, "Never registered with dmabounce but attempting to unregister!\n");
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][V2] dma-mapping: add in missing white space in error message text
2016-09-12 13:09 ` Colin King
@ 2016-09-12 14:28 ` Russell King - ARM Linux
-1 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2016-09-12 14:28 UTC (permalink / raw)
To: Colin King
Cc: Vineet Gupta, Hans-Christian Noren Egtvedt, Joerg Roedel,
Robin Murphy, Jesper Nilsson, Krzysztof Kozlowski,
linux-arm-kernel, linux-kernel
On Mon, Sep 12, 2016 at 02:09:52PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space and reformat the
> message to not span multiple lines.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/arm/common/dmabounce.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..afeb5e3 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -546,9 +546,7 @@ void dmabounce_unregister_dev(struct device *dev)
> set_dma_ops(dev, NULL);
>
> if (!device_info) {
> - dev_warn(dev,
> - "Never registered with dmabounce but attempting"
> - "to unregister!\n");
> + dev_warn(dev, "Never registered with dmabounce but attempting to unregister!\n");
Almost!
dev_warn(dev,
"Never registered with dmabounce but attempting to unregister!\n");
The point is that the string is as greppable as possible, while trying to
keep to the rest of the style.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH][V2] dma-mapping: add in missing white space in error message text
@ 2016-09-12 14:28 ` Russell King - ARM Linux
0 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2016-09-12 14:28 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 12, 2016 at 02:09:52PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space and reformat the
> message to not span multiple lines.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/arm/common/dmabounce.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..afeb5e3 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -546,9 +546,7 @@ void dmabounce_unregister_dev(struct device *dev)
> set_dma_ops(dev, NULL);
>
> if (!device_info) {
> - dev_warn(dev,
> - "Never registered with dmabounce but attempting"
> - "to unregister!\n");
> + dev_warn(dev, "Never registered with dmabounce but attempting to unregister!\n");
Almost!
dev_warn(dev,
"Never registered with dmabounce but attempting to unregister!\n");
The point is that the string is as greppable as possible, while trying to
keep to the rest of the style.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-12 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 13:09 [PATCH][V2] dma-mapping: add in missing white space in error message text Colin King
2016-09-12 13:09 ` Colin King
2016-09-12 14:28 ` Russell King - ARM Linux
2016-09-12 14:28 ` Russell King - ARM Linux
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.