* [PATCH v2] staging: dgnc: dgnc_cls.c: usleep_range is preferred over udelay
@ 2016-09-13 7:58 Anchal Jain
2016-09-13 12:42 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Anchal Jain @ 2016-09-13 7:58 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, lidza.louina
According to Documentation/timers/timers-howto.txt"
udelay() is only called once from a place where sleeping is allowed.
We can replace it with a call to usleep_range()
with a reasonable upper limit
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
Change in v2:
-By mistake another patch was mixed so, Remove that patch file
drivers/staging/dgnc/dgnc_cls.c | 6 +++---
drivers/staging/wilc1000/linux_mon.c | 11 +++++++++++
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 4e1e0dc6..1b07255 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -410,7 +410,7 @@ static void cls_assert_modem_signals(struct channel_t *ch)
writeb(out, &ch->ch_cls_uart->mcr);
/* Give time for the UART to actually drop the signals */
- udelay(10);
+ usleep_range(10, 20);
}
static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
@@ -632,7 +632,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
* Presumably, this is a bug in this UART.
*/
- udelay(10);
+ usleep_delay(10, 20);
}
/*
@@ -1104,7 +1104,7 @@ static void cls_uart_init(struct channel_t *ch)
writeb(UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT,
&ch->ch_cls_uart->isr_fcr);
- udelay(10);
+ usleep_delay(10, 20);
ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: dgnc: dgnc_cls.c: usleep_range is preferred over udelay
2016-09-13 7:58 [PATCH v2] staging: dgnc: dgnc_cls.c: usleep_range is preferred over udelay Anchal Jain
@ 2016-09-13 12:42 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-09-13 12:42 UTC (permalink / raw)
To: Anchal Jain; +Cc: outreachy-kernel, lidza.louina
On Tue, Sep 13, 2016 at 01:28:39PM +0530, Anchal Jain wrote:
> According to Documentation/timers/timers-howto.txt"
> udelay() is only called once from a place where sleeping is allowed.
> We can replace it with a call to usleep_range()
> with a reasonable upper limit
>
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
>
> Change in v2:
> -By mistake another patch was mixed so, Remove that patch file
> drivers/staging/dgnc/dgnc_cls.c | 6 +++---
> drivers/staging/wilc1000/linux_mon.c | 11 +++++++++++
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 4e1e0dc6..1b07255 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -410,7 +410,7 @@ static void cls_assert_modem_signals(struct channel_t *ch)
> writeb(out, &ch->ch_cls_uart->mcr);
>
> /* Give time for the UART to actually drop the signals */
> - udelay(10);
> + usleep_range(10, 20);
> }
>
> static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
As others pointed out, this isn't ok to change, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-13 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 7:58 [PATCH v2] staging: dgnc: dgnc_cls.c: usleep_range is preferred over udelay Anchal Jain
2016-09-13 12:42 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.