* [PATCH v2 5/6] staging: media: lirc: lirc_imon: Add space around the operators
@ 2016-09-13 11:18 Anchal Jain
2016-09-13 11:21 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Anchal Jain @ 2016-09-13 11:18 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, mchehab
CHECK: Add space around the operators { "<<", "*"}.
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
changes in v2:
-add cc
drivers/staging/media/lirc/lirc_imon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index e44f841..ee12da2 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -561,7 +561,7 @@ static void submit_data(struct imon_context *context)
value |= PULSE_BIT;
for (i = 0; i < 4; ++i)
- buf[i] = value>>(i*8);
+ buf[i] = value >> (i * 8);
lirc_buffer_write(context->driver->rbuf, buf);
wake_up(&context->driver->rbuf->wait_poll);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 5/6] staging: media: lirc: lirc_imon: Add space around the operators
2016-09-13 11:18 [PATCH v2 5/6] staging: media: lirc: lirc_imon: Add space around the operators Anchal Jain
@ 2016-09-13 11:21 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-13 11:21 UTC (permalink / raw)
To: Anchal Jain; +Cc: gregkh, outreachy-kernel, mchehab
On Tue, 13 Sep 2016, Anchal Jain wrote:
> CHECK: Add space around the operators { "<<", "*"}.
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
This looks better.
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> changes in v2:
> -add cc
> drivers/staging/media/lirc/lirc_imon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
> index e44f841..ee12da2 100644
> --- a/drivers/staging/media/lirc/lirc_imon.c
> +++ b/drivers/staging/media/lirc/lirc_imon.c
> @@ -561,7 +561,7 @@ static void submit_data(struct imon_context *context)
> value |= PULSE_BIT;
>
> for (i = 0; i < 4; ++i)
> - buf[i] = value>>(i*8);
> + buf[i] = value >> (i * 8);
>
> lirc_buffer_write(context->driver->rbuf, buf);
> wake_up(&context->driver->rbuf->wait_poll);
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160913111752.GA10774%40life-desktop.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-13 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 11:18 [PATCH v2 5/6] staging: media: lirc: lirc_imon: Add space around the operators Anchal Jain
2016-09-13 11:21 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.