All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	kernel-team@fb.com, Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: Autofs and mount namespaces
Date: Tue, 13 Sep 2016 18:25:33 -0700	[thread overview]
Message-ID: <20160914012533.GA27760@vader.dhcp.thefacebook.com> (raw)
In-Reply-To: <1473814617.3333.11.camel@themaw.net>

On Wed, Sep 14, 2016 at 08:56:57AM +0800, Ian Kent wrote:

[snip]

> > > > Hi, Ian,
> > > > 
> > > > Just wanted to check on the status of this fix. Is this still the
> > > > approach you wanted to take/is there anything else you wanted to do with
> > > > this?
> > > 
> > > The problem is that someone tested this back ported to an older kernel and
> > > claimed it caused file system corruption.
> > > 
> > > That leaves me in a bad place indeed.
> > > 
> > > Ian
> > 
> > Hi, Ian,
> > 
> > Dredging this up again because I forgot to reply in a timely manner last
> > time. Do you have more details on that report? I'm having a hard time
> > seeing how this change would cause filesystem corruption, and I still
> > think a fix for this really needs to go in.
> 
> You and me both.
> 
> I recently re-factored the patch a bit and I'm thinking the best thing to do is
> to send it to Andrew Morton so it can get plenty of testing before being
> considered for mainline.
> 
> I ran the kernel with the patches for several days without problem but didn't do
> a lot with autofs during that time.
> 
> I'll also have another look at it based on a comment from All Viro but I
> couldn't see anything wrong with it myself, perhaps he will comment further when
> I send it over to Andrew.
> 
> Ian

Awesome, please Cc me on the patch and I'll take it for a spin on some
of our servers.

-- 
Omar

WARNING: multiple messages have this Message-ID (diff)
From: Omar Sandoval <osandov@osandov.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	kernel-team@fb.com, Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: Autofs and mount namespaces
Date: Tue, 13 Sep 2016 18:25:33 -0700	[thread overview]
Message-ID: <20160914012533.GA27760@vader.dhcp.thefacebook.com> (raw)
In-Reply-To: <1473814617.3333.11.camel@themaw.net>

On Wed, Sep 14, 2016 at 08:56:57AM +0800, Ian Kent wrote:

[snip]

> > > > Hi, Ian,
> > > > 
> > > > Just wanted to check on the status of this fix. Is this still the
> > > > approach you wanted to take/is there anything else you wanted to do with
> > > > this?
> > > 
> > > The problem is that someone tested this back ported to an older kernel and
> > > claimed it caused file system corruption.
> > > 
> > > That leaves me in a bad place indeed.
> > > 
> > > Ian
> > 
> > Hi, Ian,
> > 
> > Dredging this up again because I forgot to reply in a timely manner last
> > time. Do you have more details on that report? I'm having a hard time
> > seeing how this change would cause filesystem corruption, and I still
> > think a fix for this really needs to go in.
> 
> You and me both.
> 
> I recently re-factored the patch a bit and I'm thinking the best thing to do is
> to send it to Andrew Morton so it can get plenty of testing before being
> considered for mainline.
> 
> I ran the kernel with the patches for several days without problem but didn't do
> a lot with autofs during that time.
> 
> I'll also have another look at it based on a comment from All Viro but I
> couldn't see anything wrong with it myself, perhaps he will comment further when
> I send it over to Andrew.
> 
> Ian

Awesome, please Cc me on the patch and I'll take it for a spin on some
of our servers.

-- 
Omar
--
To unsubscribe from this list: send the line "unsubscribe autofs" in

  reply	other threads:[~2016-09-14  1:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 18:19 Autofs and mount namespaces Omar Sandoval
2016-04-07 18:19 ` Omar Sandoval
2016-04-07 19:08 ` kbuild test robot
2016-04-07 19:42   ` Omar Sandoval
2016-04-08  0:51 ` Ian Kent
2016-04-08  0:51   ` Ian Kent
2016-04-08  1:04   ` Ian Kent
2016-04-08 20:21   ` Omar Sandoval
2016-04-08 20:21     ` Omar Sandoval
2016-04-10  2:53     ` Ian Kent
2016-04-10  2:53       ` Ian Kent
2016-07-05 18:47   ` Omar Sandoval
2016-07-05 23:35     ` Ian Kent
2016-09-13 18:19       ` Omar Sandoval
2016-09-13 18:19         ` Omar Sandoval
2016-09-14  0:56         ` Ian Kent
2016-09-14  1:25           ` Omar Sandoval [this message]
2016-09-14  1:25             ` Omar Sandoval
2016-04-08  1:21 ` Ian Kent
2016-04-08  1:21   ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914012533.GA27760@vader.dhcp.thefacebook.com \
    --to=osandov@osandov.com \
    --cc=akpm@linux-foundation.org \
    --cc=autofs@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=raven@themaw.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.